Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multitenant: enumerate tenant capability names #97619

Closed
ecwall opened this issue Feb 24, 2023 · 0 comments · Fixed by #97620
Closed

multitenant: enumerate tenant capability names #97619

ecwall opened this issue Feb 24, 2023 · 0 comments · Fixed by #97620
Assignees
@ecwall
Labels
A-multitenancy Related to multi-tenancy C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@ecwall
Copy link
Contributor

ecwall commented Feb 24, 2023 •
edited by exalate-issue-sync bot
Loading

Tenant capability names are defined in the tenantcapabilitiespb package as string constants.

Add a new pseudo-enum type for them to increase type safety.

Original request:
https://reviewable.io/reviews/cockroachdb/cockroach/97567#-NOykIyb0S3tbRaMlb9V

Jira issue: CRDB-24792

Epic CRDB-23344
@ecwall ecwall added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-multitenancy Related to multi-tenancy T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) labels Feb 24, 2023
@ecwall ecwall self-assigned this Feb 24, 2023
@ecwall ecwall mentioned this issue Feb 24, 2023
Merged
craig bot pushed a commit that referenced this issue Feb 24, 2023
@ecwall
Merge #97620
769eac6 
97620: multitenant: enumerate tenant capability names r=arulajmani a=ecwall

Fixes #97619

Change tenant capability names from string constants to enums to increase
type safety.

Release note: None

Co-authored-by: Evan Wall <[email protected]>
@craig craig bot closed this as completed in 111298e Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ecwall ecwall

Labels
A-multitenancy Related to multi-tenancy C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

multitenant: enumerate tenant capability names
1 participant
@ecwall