Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: splits/load/uniform/nodes=3 failed #97494

Closed
cockroach-teamcity opened this issue Feb 22, 2023 · 2 comments · Fixed by #97542
Closed

roachtest: splits/load/uniform/nodes=3 failed #97494

cockroach-teamcity opened this issue Feb 22, 2023 · 2 comments · Fixed by #97542
Assignees
@kvoli
Labels
A-kv Anything in KV that doesn't belong in a more specific category. branch-master Failures and bugs on the master branch. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. T-kv KV Team
Milestone
23.1

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Feb 22, 2023 •
edited by cockroach-jira-scripts
Loading

roachtest.splits/load/uniform/nodes=3 failed with artifacts on master @ 286b3e235171a39b8f9910555affcc7ce310741a:

test artifacts and logs in: /artifacts/splits/load/uniform/nodes=3/run_1
(monitor.go:127).Wait: monitor failure: monitor task failed: kv.kv has 4 ranges, expected between 11 and 2147483647 splits

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=4 , ROACHTEST_encrypted=false , ROACHTEST_fs=ext4 , ROACHTEST_localSSD=true , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

/cc @cockroachdb/kv-triage

This test on roachdash | Improve this report!

Jira issue: CRDB-24726
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Feb 22, 2023
@cockroach-teamcity cockroach-teamcity added this to the 23.1 milestone Feb 22, 2023
@blathers-crl blathers-crl bot added the T-kv KV Team label Feb 22, 2023
@kvoli
Copy link
Collaborator

kvoli commented Feb 23, 2023

Caused by #97424. I'll look into this.

@kvoli kvoli mentioned this issue Feb 23, 2023
Merged
@cockroach-teamcity
Copy link
Member Author

roachtest.splits/load/uniform/nodes=3 failed with artifacts on master @ e028ce5b14505dfd17ef8b13001c0ab8ac811e3c:

test artifacts and logs in: /artifacts/splits/load/uniform/nodes=3/run_1
(monitor.go:127).Wait: monitor failure: monitor task failed: kv.kv has 4 ranges, expected between 11 and 2147483647 splits

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=4 , ROACHTEST_encrypted=false , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

This test on roachdash | Improve this report!

craig bot pushed a commit that referenced this issue Feb 23, 2023
@kvoli
Merge #97542
2efb369 
97542: roachtest: use qps splitting for splits/load tests r=shralex a=kvoli

This commit updates the clusters used in `splits/load` roachtests to use
QPS load based splitting, rather than CPU, which was enabled by default
in #97424.

These tests were failing as they assumed QPS load based splitting when
calculating the number of final ranges to assert against.

These tests should be run against all load based split objectives, this
is tracked in #97540.

Resolves: #97494
Resolves: #97455
Informs:  #97540

Co-authored-by: Austen McClernon <[email protected]>
@craig craig bot closed this as completed in 0df5ea5 Feb 23, 2023
@pav-kv pav-kv added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-kv Anything in KV that doesn't belong in a more specific category. and removed release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kvoli kvoli

Labels
A-kv Anything in KV that doesn't belong in a more specific category. branch-master Failures and bugs on the master branch. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. T-kv KV Team
Projects
None yet
Milestone
23.1
Development

Successfully merging a pull request may close this issue.

roachtest: use qps splitting for splits/load tests kvoli/cockroach
3 participants
@pav-kv @cockroach-teamcity @kvoli