bench: BenchmarkFuncExprTypeCheck fails on master

[yuzefovich]

On 4806560 I get the following:

yuzefovich@crlMBP-YN9GWF6WF7NTI1 cockroach % ./dev bench pkg/bench -f=BenchmarkFuncExprTypeCheck -v --stream-output
$ bazel test pkg/bench:all --test_arg -test.run=- --test_arg -test.bench=BenchmarkFuncExprTypeCheck --test_sharding_strategy=disabled --test_arg -test.v --crdb_test_off --test_output streamed
INFO: Invocation ID: b39f29a0-15bb-4ea5-932b-7423e43f80c6
WARNING: Streamed test output requested. All tests will be run locally, without sharding, one at a time
INFO: Analyzed 3 targets (1 packages loaded, 216 targets configured).
INFO: Found 2 targets and 1 test target...
I230221 17:41:05.799887 1 (gostd) rand.go:199  [T1] 1  random seed: 2662163393425416388
goos: darwin
goarch: arm64
BenchmarkFuncExprTypeCheck
    test_log_scope.go:161: test logs captured to: /Users/yuzefovich/go/src/github.com/cockroachdb/cockroach/tmp/_tmp/43bfbdbe7df5c7b3e2a2cb71efa9af4e/logBenchmarkFuncExprTypeCheck242956656
    test_log_scope.go:79: use -show-logs to present logs inline
    bench_test.go:1443: error executing 'CREATE FUNCTION abs(val INT) RETURNS INT CALLED ON NULL INPUT LANGUAGE SQL AS $$ SELECT val $$': pq: cannot perform schema change on function abs(val: int) -> int because it is required by the database system
    panic.go:522: -- test log scope end --
test logs left over in: /Users/yuzefovich/go/src/github.com/cockroachdb/cockroach/tmp/_tmp/43bfbdbe7df5c7b3e2a2cb71efa9af4e/logBenchmarkFuncExprTypeCheck242956656
--- FAIL: BenchmarkFuncExprTypeCheck
FAIL
I230221 17:41:06.168402 1 (gostd) testmain.go:136  [T1] 1  Test //pkg/bench:bench_test exited with error code 1
FAIL: //pkg/bench:bench_test (see /private/var/tmp/_bazel_yahor/e311b1c2454b7c301a6b73bddff450e7/execroot/com_github_cockroachdb_cockroach/bazel-out/darwin_arm64-fastbuild/testlogs/pkg/bench/bench_test/test.log)
INFO: Elapsed time: 24.825s, Critical Path: 24.33s
INFO: 35 processes: 1 internal, 34 darwin-sandbox.
INFO: Build completed, 1 test FAILED, 35 total actions
//pkg/bench:bench_test                                                   FAILED in 1.7s
  /private/var/tmp/_bazel_yahor/e311b1c2454b7c301a6b73bddff450e7/execroot/com_github_cockroachdb_cockroach/bazel-out/darwin_arm64-fastbuild/testlogs/pkg/bench/bench_test/test.log

INFO: Build completed, 1 test FAILED, 35 total actions
ERROR: exit status 3

I'll skip the failing stuff for now.

Jira issue: CRDB-24682

[blathers-crl]

Hi @chengxiong-ruan, please add branch-* labels to identify which branch(es) this release-blocker affects.

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}

[chengxiong-ruan]

woof...this was introduced recently I think, I'll have a fix for this. Basically UDF need to shadow builtins...