Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: TestPebbleMetricEventListener failed #96638

Closed
cockroach-teamcity opened this issue Feb 6, 2023 · 0 comments
Closed

storage: TestPebbleMetricEventListener failed #96638

cockroach-teamcity opened this issue Feb 6, 2023 · 0 comments
Assignees
@jbowens
Labels
branch-release-22.2 Used to mark GA and release blockers, technical advisories, and bugs for 22.2 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-storage Storage Team
Milestone
22.2

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Feb 6, 2023 •
edited by cockroach-jira-scripts
Loading

storage.TestPebbleMetricEventListener failed with artifacts on release-22.2 @ 94796359a4a73690b8e39484d8ecc515b64db77b:

=== RUN   TestPebbleMetricEventListener
    test_log_scope.go:161: test logs captured to: /artifacts/tmp/_tmp/c5eb8fc8b8e683c19f3c3e4238f64094/logTestPebbleMetricEventListener1760716648
    test_log_scope.go:79: use -show-logs to present logs inline
    pebble_test.go:272: -- test log scope end --
    test_log_scope.go:412: unlinkat /artifacts/tmp/_tmp/c5eb8fc8b8e683c19f3c3e4238f64094/logTestPebbleMetricEventListener1760716648: directory not empty
--- FAIL: TestPebbleMetricEventListener (0.01s)

Parameters: TAGS=bazel,gss,deadlock

Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

/cc @cockroachdb/storage

This test on roachdash | Improve this report!

Jira issue: CRDB-24257
@cockroach-teamcity cockroach-teamcity added branch-release-22.2 Used to mark GA and release blockers, technical advisories, and bugs for 22.2 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels Feb 6, 2023
@cockroach-teamcity cockroach-teamcity added this to the 22.2 milestone Feb 6, 2023
@blathers-crl blathers-crl bot added the T-storage Storage Team label Feb 6, 2023
@jbowens jbowens self-assigned this Feb 6, 2023
jbowens added a commit to jbowens/cockroach that referenced this issue Feb 6, 2023
@jbowens
storage: fix TestPebbleMetricEventListener
40c5ba6 
In cockroachdb#96096 handling of disk slow events was made asynchronous. This introduced a
race during Close where the goroutine logging could still be inflight.

Fix cockroachdb#96638.
Epic: None
Release note: None
@jbowens jbowens mentioned this issue Feb 6, 2023
Merged
@jbowens jbowens closed this as completed Feb 7, 2023
@jbowens jbowens moved this to Done in [Deprecated] Storage Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbowens jbowens

Labels
branch-release-22.2 Used to mark GA and release blockers, technical advisories, and bugs for 22.2 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-storage Storage Team
Projects
No open projects
[Deprecated] Storage
Archived in project
Milestone
22.2
Development

No branches or pull requests
2 participants
@jbowens @cockroach-teamcity