roachtest: typeorm failed #96098

cockroach-teamcity · 2023-01-27T16:04:43Z

roachtest.typeorm failed with artifacts on master @ 95a3a11f11b09481bbdf56820eea4420120f04f9:

test artifacts and logs in: /artifacts/typeorm/run_1
(typeorm.go:176).func1: COMMAND_PROBLEM: ssh verbose log retained in ssh_154440.631266472_n1_cd-mntdata1typeorm-n.log: exit status 1

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=4 , ROACHTEST_encrypted=false , ROACHTEST_fs=ext4 , ROACHTEST_localSSD=true , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

roachtest: typeorm failed #88706 roachtest: typeorm failed [C-test-failure O-roachtest O-robot branch-release-22.1]

/cc @cockroachdb/sql-sessions _{This test on roachdash | Improve this report!

Jira issue: CRDB-23947}

The text was updated successfully, but these errors were encountered:

cockroach-teamcity · 2023-01-28T15:45:48Z

roachtest.typeorm failed with artifacts on master @ 78fe59d0536be35fcec68280142746fb91515551:

test artifacts and logs in: /artifacts/typeorm/run_1
(typeorm.go:176).func1: COMMAND_PROBLEM: ssh verbose log retained in ssh_152508.691806454_n1_cd-mntdata1typeorm-n.log: exit status 1

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=4 , ROACHTEST_encrypted=false , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

roachtest: typeorm failed #88706 roachtest: typeorm failed [C-test-failure O-roachtest O-robot branch-release-22.1]

_{This test on roachdash | Improve this report!}

cockroach-teamcity · 2023-01-29T16:07:58Z

roachtest.typeorm failed with artifacts on master @ 69dd453d0e61e258f402c5751de310405743cd18:

test artifacts and logs in: /artifacts/typeorm/run_1
(typeorm.go:176).func1: COMMAND_PROBLEM: ssh verbose log retained in ssh_154802.395152194_n1_cd-mntdata1typeorm-n.log: exit status 1

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=4 , ROACHTEST_encrypted=false , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

roachtest: typeorm failed #88706 roachtest: typeorm failed [C-test-failure O-roachtest O-robot branch-release-22.1]

_{This test on roachdash | Improve this report!}

cockroach-teamcity · 2023-01-30T13:34:52Z

roachtest.typeorm failed with artifacts on master @ 69dd453d0e61e258f402c5751de310405743cd18:

test artifacts and logs in: /artifacts/typeorm/run_1
(typeorm.go:176).func1: COMMAND_PROBLEM: ssh verbose log retained in ssh_131337.738170725_n1_cd-mntdata1typeorm-n.log: exit status 1

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=4 , ROACHTEST_encrypted=false , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

roachtest: typeorm failed #88706 roachtest: typeorm failed [C-test-failure O-roachtest O-robot branch-release-22.1]

_{This test on roachdash | Improve this report!}

cockroach-teamcity · 2023-01-31T15:50:30Z

roachtest.typeorm failed with artifacts on master @ 1fb7236f7b1f53e28bde833c28bed83a976138cf:

test artifacts and logs in: /artifacts/typeorm/run_1
(typeorm.go:176).func1: COMMAND_PROBLEM: ssh verbose log retained in ssh_153059.893077969_n1_cd-mntdata1typeorm-n.log: exit status 1

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=4 , ROACHTEST_encrypted=false , ROACHTEST_fs=ext4 , ROACHTEST_localSSD=true , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

roachtest: typeorm failed #88706 roachtest: typeorm failed [C-test-failure O-roachtest O-robot branch-release-22.1]

_{This test on roachdash | Improve this report!}

cockroach-teamcity · 2023-02-01T13:41:34Z

roachtest.typeorm failed with artifacts on master @ b59fa09d971e92b8b5bcc874437159ef252e0313:

test artifacts and logs in: /artifacts/typeorm/run_1
(typeorm.go:176).func1: COMMAND_PROBLEM: ssh verbose log retained in ssh_132156.365755231_n1_cd-mntdata1typeorm-n.log: exit status 1

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=4 , ROACHTEST_encrypted=false , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

roachtest: typeorm failed #88706 roachtest: typeorm failed [C-test-failure O-roachtest O-robot branch-release-22.1]

_{This test on roachdash | Improve this report!}

cockroach-teamcity · 2023-02-02T17:02:04Z

roachtest.typeorm failed with artifacts on master @ 22244a780dcfaca48162dde8e0f90b5ba9b6bb9c:

test artifacts and logs in: /artifacts/typeorm/run_1
(typeorm.go:176).func1: COMMAND_PROBLEM: ssh verbose log retained in ssh_164148.854130806_n1_cd-mntdata1typeorm-n.log: exit status 1

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=4 , ROACHTEST_encrypted=false , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

roachtest: typeorm failed #88706 roachtest: typeorm failed [C-test-failure O-roachtest O-robot branch-release-22.1]

_{This test on roachdash | Improve this report!}

cockroach-teamcity · 2023-02-03T16:57:22Z

roachtest.typeorm failed with artifacts on master @ 44d9f3c8b7bd46839187cea69eaec640c080ac05:

test artifacts and logs in: /artifacts/typeorm/run_1
(typeorm.go:176).func1: COMMAND_PROBLEM: ssh verbose log retained in ssh_163742.954344279_n1_cd-mntdata1typeorm-n.log: exit status 1

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=4 , ROACHTEST_encrypted=false , ROACHTEST_fs=ext4 , ROACHTEST_localSSD=true , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

roachtest: typeorm failed #88706 roachtest: typeorm failed [C-test-failure O-roachtest O-robot branch-release-22.1]

_{This test on roachdash | Improve this report!}

cockroach-teamcity · 2023-02-04T13:38:46Z

roachtest.typeorm failed with artifacts on master @ 5fbcd8a8deac0205c7df38e340c1eb9692854383:

test artifacts and logs in: /artifacts/typeorm/run_1
(typeorm.go:176).func1: COMMAND_PROBLEM: ssh verbose log retained in ssh_131905.213248996_n1_cd-mntdata1typeorm-n.log: exit status 1

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=4 , ROACHTEST_encrypted=false , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

roachtest: typeorm failed #88706 roachtest: typeorm failed [C-test-failure O-roachtest O-robot branch-release-22.1]

_{This test on roachdash | Improve this report!}

cockroach-teamcity · 2023-02-05T11:51:45Z

roachtest.typeorm failed with artifacts on master @ 8e24570fa366ed038c6ae65f50db5d8e22826db0:

test artifacts and logs in: /artifacts/typeorm/run_1
(typeorm.go:176).func1: COMMAND_PROBLEM: ssh verbose log retained in ssh_113042.870750173_n1_cd-mntdata1typeorm-n.log: exit status 1

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=4 , ROACHTEST_encrypted=false , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

roachtest: typeorm failed #88706 roachtest: typeorm failed [C-test-failure O-roachtest O-robot branch-release-22.1]

_{This test on roachdash | Improve this report!}

cockroach-teamcity · 2023-02-06T13:47:11Z

roachtest.typeorm failed with artifacts on master @ 8e24570fa366ed038c6ae65f50db5d8e22826db0:

test artifacts and logs in: /artifacts/typeorm/run_1
(typeorm.go:176).func1: COMMAND_PROBLEM: ssh verbose log retained in ssh_132716.220172267_n1_cd-mntdata1typeorm-n.log: exit status 1

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=4 , ROACHTEST_encrypted=false , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

roachtest: typeorm failed #88706 roachtest: typeorm failed [C-test-failure O-roachtest O-robot branch-release-22.1]

_{This test on roachdash | Improve this report!}

rafiss · 2023-02-06T16:17:50Z

It seems that #94153 is causing a test to fail:

  1) github issues > #7110: Typeorm Migrations ignore existing default value on column`
       double type conversion in default value
         does not generate when no model changes:

      ALTER TABLE "foo_test" ALTER COLUMN "displayId" SET DEFAULT concat(chr(65), FMU000)
      + expected - actual

      -1
      +0
      
      at /mnt/data1/typeorm/test/github-issues/7110/issue-7110.ts:45:60
      at runMicrotasks (<anonymous>)
      at processTicksAndRejections (node:internal/process/task_queues:96:5)
      at async Promise.all (index 0)

It looks related to this typeorm code, which is expecting the ::: syntax in the column default value reported in information_schema.columns: https://github.com/typeorm/typeorm/blob/c814b07653578f033808d01776293138751cc02e/src/driver/cockroachdb/CockroachQueryRunner.ts#L2654-L2661

rafiss · 2023-02-06T17:10:06Z

Actually, it's not related to the ::: syntax being removed. The change in #94153 is causing other differences in information_schema.columns. This diff is from that PR:

diff --git a/pkg/sql/logictest/testdata/logic_test/information_schema b/pkg/sql/logictest/testdata/logic_test/information_schema
index a7c41d2800..381089066b 100644
--- a/pkg/sql/logictest/testdata/logic_test/information_schema
+++ b/pkg/sql/logictest/testdata/logic_test/information_schema
@@ -2329,8 +2340,8 @@ FROM information_schema.columns
 WHERE table_schema = 'public' AND table_name = 'with_defaults'
 ----
 table_name     column_name  column_default
-with_defaults  a            9:::INT8
-with_defaults  b            'default':::STRING
+with_defaults  a            9
+with_defaults  b            default

The single quotes around 'default' should still be there.

cc @e-mbrown @ZhouXing19

fixes cockroachdb#96098 In bc3fccd, the format flags were changed to use FmtPgWireText for information_schema.columns(column_default). This does not work for string literals, since that format does not wrap literals in single quotes. Now we've changed to FmtParsableNumerics, which does properly add quotes, and also avoids adding the `:::` type annotation as FmtPgWireText does. No release note since this bug was never released. Release note: None

96562: cli/sql: assorted CLI shell and autocompletion bug fixes r=ZhouXing19 a=knz See the individual commits for details. Epic: None 96660: sql: fix column_default in info_schema so literals are quoted r=e-mbrown a=rafiss fixes #96098 In bc3fccd, the format flags were changed to use FmtPgWireText for information_schema.columns(column_default). This does not work for string literals, since that format does not wrap literals in single quotes. Now we've changed to FmtParsableNumerics, which does properly add quotes, and also avoids adding the `:::` type annotation as FmtPgWireText does. No release note since this bug was never released. Release note: None 96668: allocator: fix panic when accessing nil store descriptor r=kvoli a=aliher1911 Previously allocator was trying to update store descriptor counters on unitialized stores. Instead of checking if detail is nil which should never happen, it should check if descriptor in detail is not nil as it is only eventually populated by gossip. Release note: None Fixes #96654 Co-authored-by: Raphael 'kena' Poss <[email protected]> Co-authored-by: Rafi Shamim <[email protected]> Co-authored-by: Oleg Afanasyev <[email protected]>

cockroach-teamcity added this to the 23.1 milestone Jan 27, 2023

ZhouXing19 removed the release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. label Jan 30, 2023

rafiss mentioned this issue Feb 6, 2023

sql: fix column_default in info_schema so literals are quoted #96660

Merged

craig bot closed this as completed in ea3342d Feb 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

roachtest: typeorm failed #96098

roachtest: typeorm failed #96098

cockroach-teamcity commented Jan 27, 2023 •

edited by cockroach-jira-scripts

Loading

cockroach-teamcity commented Jan 28, 2023

cockroach-teamcity commented Jan 29, 2023

cockroach-teamcity commented Jan 30, 2023

cockroach-teamcity commented Jan 31, 2023

cockroach-teamcity commented Feb 1, 2023

cockroach-teamcity commented Feb 2, 2023

cockroach-teamcity commented Feb 3, 2023

cockroach-teamcity commented Feb 4, 2023

cockroach-teamcity commented Feb 5, 2023

cockroach-teamcity commented Feb 6, 2023

rafiss commented Feb 6, 2023

rafiss commented Feb 6, 2023

roachtest: typeorm failed #96098

roachtest: typeorm failed #96098

Comments

cockroach-teamcity commented Jan 27, 2023 • edited by cockroach-jira-scripts Loading

cockroach-teamcity commented Jan 28, 2023

cockroach-teamcity commented Jan 29, 2023

cockroach-teamcity commented Jan 30, 2023

cockroach-teamcity commented Jan 31, 2023

cockroach-teamcity commented Feb 1, 2023

cockroach-teamcity commented Feb 2, 2023

cockroach-teamcity commented Feb 3, 2023

cockroach-teamcity commented Feb 4, 2023

cockroach-teamcity commented Feb 5, 2023

cockroach-teamcity commented Feb 6, 2023

rafiss commented Feb 6, 2023

rafiss commented Feb 6, 2023

cockroach-teamcity commented Jan 27, 2023 •

edited by cockroach-jira-scripts

Loading