Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kv: rollback to savepoint does not release locks acquired during sub-transaction #94731

Open
nvanbenschoten opened this issue Jan 4, 2023 · 0 comments
Open

kv: rollback to savepoint does not release locks acquired during sub-transaction #94731

nvanbenschoten opened this issue Jan 4, 2023 · 0 comments
Labels
A-kv-transactions Relating to MVCC and the transactional model. A-sql-pgcompat Semantic compatibility with PostgreSQL C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) P-3 Issues/test failures with no fix SLA T-kv KV Team

Comments

@nvanbenschoten
Copy link
Member

nvanbenschoten commented Jan 4, 2023 •
edited by exalate-issue-sync bot
Loading

At the time of the original savepoint design, this was a deliberate decision. See the RFC.

We should reconsider it, especially if we plan to use savepoints internally to support per-statement retries.

Jira issue: CRDB-23106
@nvanbenschoten nvanbenschoten added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-sql-pgcompat Semantic compatibility with PostgreSQL A-kv-transactions Relating to MVCC and the transactional model. T-kv KV Team labels Jan 4, 2023
@exalate-issue-sync exalate-issue-sync bot added the P-3 Issues/test failures with no fix SLA label Dec 7, 2023
nvanbenschoten added a commit to nvanbenschoten/cockroach that referenced this issue Mar 25, 2024
@nvanbenschoten
kv: add TODO for savepoint seqNum exclusivity
b1224b9 
Informs cockroachdb#94731.

This probably isn't working correctly. Make a note of it in the code.

Release note: None
nvanbenschoten added a commit to nvanbenschoten/cockroach that referenced this issue Mar 26, 2024
@nvanbenschoten
kv: add TODO for savepoint seqNum exclusivity
8fa0f00 
Informs cockroachdb#94731.

This probably isn't working correctly. Make a note of it in the code.

Release note: None
@nvanbenschoten nvanbenschoten mentioned this issue Apr 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-kv-transactions Relating to MVCC and the transactional model. A-sql-pgcompat Semantic compatibility with PostgreSQL C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) P-3 Issues/test failures with no fix SLA T-kv KV Team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nvanbenschoten