Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: transfer-leases/drain-other-node failed #94058

Closed
cockroach-teamcity opened this issue Dec 21, 2022 · 1 comment · Fixed by #94073
Closed

roachtest: transfer-leases/drain-other-node failed #94058

cockroach-teamcity opened this issue Dec 21, 2022 · 1 comment · Fixed by #94073
Assignees
@mgartner
Labels
A-testing Testing tools and infrastructure branch-master Failures and bugs on the master branch. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. T-kv KV Team
Milestone
23.1

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Dec 21, 2022 •
edited by cockroach-jira-scripts
Loading

roachtest.transfer-leases/drain-other-node failed with artifacts on master @ 10266a323f94c3cf397d5de590e512d987e63e22:

test artifacts and logs in: /artifacts/transfer-leases/drain-other-node/run_1
(test_impl.go:291).Fatal: pq: invalid syntax @1

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=4 , ROACHTEST_encrypted=false , ROACHTEST_fs=ext4 , ROACHTEST_localSSD=true , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

/cc @cockroachdb/kv-triage

This test on roachdash | Improve this report!

Jira issue: CRDB-22670
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Dec 21, 2022
@cockroach-teamcity cockroach-teamcity added this to the 23.1 milestone Dec 21, 2022
@blathers-crl blathers-crl bot added the T-kv KV Team label Dec 21, 2022
@knz
Copy link
Contributor

knz commented Dec 21, 2022

Fallout from #93754.
cc @mgartner

@mgartner mgartner self-assigned this Dec 21, 2022
@mgartner mgartner removed the release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. label Dec 21, 2022
@blathers-crl blathers-crl bot added the T-sql-queries SQL Queries Team label Dec 21, 2022
This was referenced Dec 21, 2022
Merged
Closed
craig bot pushed a commit that referenced this issue Dec 21, 2022
@rafiss @sumeerbhola
@yuzefovich @mgartner
Merge #93991 #94025 #94031 #94073
8d3a94e 
93991: tree: correct mutation/DDL property for some opaque operators r=ZhouXing19 a=rafiss

fixes #91713

In ed733ad, a framework was added to mark certain opaque operators as DDL or mutations.

This was enhanced in 06581b3, but that change wasn't exhaustive since it marked some statements as read-only, even if they could perform DDL.

With the addition of `StatementType()` in
8962176, we can make this a little more correct.

This allows the check at
https://github.com/cockroachdb/cockroach/blob/48ef0d89e6179c0d348a5236ad308d81fa392f7c/pkg/sql/opt/exec/execbuilder/relational.go#L163 to work correctly, and reject operations that shouldn't be allowed when using a read-only transaction.

To explain each change:
- BACKUP can modify job state and write to userfiles, so shouldn't be allowed in read-only mode.
- SET commands are always allowed in read-only mode in order to match Postgres behavior, and since those changes are all in-memory and session setting modifications don't respect transactions anyway.
- The crdb_internal tenant functions modify system tables.
- GRANT, REVOKE, and many other privilege-related statements are "DCL" (data control language), and all modify system tables or descriptors.

Release note (bug fix): CREATE ROLE, DELETE ROLE, GRANT, and REVOKE statements no longer work when the transaction is in read-only mode.

94025: storage: return error from {MVCC,Engine}Iterator.Value r=mgartner,nicktrav a=sumeerbhola

Informs cockroachdb/pebble#1170

Epic: CRDB-20378

Release note: None

94031: kvstreamer: fix the usage of the range iterator r=yuzefovich a=yuzefovich

Previously, after `Seek`ing the range iterator to the next key in the batch of requests in the streamer we forgot to check the validity of the iterator. In particular, this could lead to a crash of the process if `Seek` encountered an error for whatever reason. In practice, I've only observed this when running TPCH with high concurrency when GOMEMLIMIT is set.

The bug was introduced in an innocently-looking refactor in 041b104.

Epic: None

Release note (bug fix): CockroachDB could previously crash in rare circumstances when evaluating lookup and index joins. The bug is present since 22.2.0 release. Temporary workaround without upgrading to the release with this fix is changing the value of undocumented cluster setting `sql.distsql.use_streamer.enabled` to `false`.

94073: roachtest: replace ordinal column reference in transfer-leases r=mgartner a=mgartner

This commit fixes a broken roachtest caused by #93754.

Fixes #94058

Release note: None

Co-authored-by: Rafi Shamim <[email protected]>
Co-authored-by: sumeerbhola <[email protected]>
Co-authored-by: Yahor Yuzefovich <[email protected]>
Co-authored-by: Marcus Gartner <[email protected]>
@craig craig bot closed this as completed in 3613d7b Dec 21, 2022
@exalate-issue-sync exalate-issue-sync bot removed the T-sql-queries SQL Queries Team label Dec 21, 2022
adityamaru pushed a commit to adityamaru/cockroach that referenced this issue Dec 22, 2022
@mgartner @adityamaru
roachtest: replace ordinal column reference in transfer-leases
0d68533 
This commit fixes a broken roachtest caused by cockroachdb#93754.

Fixes cockroachdb#94058

Release note: None
@erikgrinaker erikgrinaker added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-testing Testing tools and infrastructure labels Jan 4, 2023
@mgartner mgartner moved this to Done in SQL Queries Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mgartner mgartner

Labels
A-testing Testing tools and infrastructure branch-master Failures and bugs on the master branch. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. T-kv KV Team
Projects
SQL Queries
Archived in project
Milestone
23.1
Development

Successfully merging a pull request may close this issue.

roachtest: replace ordinal column reference in transfer-leases mgartner/cockroach
4 participants
@knz @erikgrinaker @mgartner @cockroach-teamcity