Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: copy/bank/rows=100000,nodes=5,txn=true failed #93703

Closed
cockroach-teamcity opened this issue Dec 15, 2022 · 10 comments · Fixed by #93974
Closed

roachtest: copy/bank/rows=100000,nodes=5,txn=true failed #93703

cockroach-teamcity opened this issue Dec 15, 2022 · 10 comments · Fixed by #93974
Assignees
@pav-kv
Labels
A-testing Testing tools and infrastructure branch-master Failures and bugs on the master branch. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. T-kv KV Team
Milestone
23.1

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Dec 15, 2022 •
edited by exalate-issue-sync bot
Loading

roachtest.copy/bank/rows=100000,nodes=5,txn=true failed with artifacts on master @ d6f98e90684894fd36f53596e6aac355676d232e:

test artifacts and logs in: /artifacts/copy/bank/rows=100000_nodes=5_txn=true/run_1
(test_impl.go:291).Fatal: monitor failure: monitor task failed: empty bank table split over multiple ranges

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=4 , ROACHTEST_encrypted=false , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

/cc @cockroachdb/kv-triage

This test on roachdash | Improve this report!

Jira issue: CRDB-22488

Epic CRDB-18656
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Dec 15, 2022
@cockroach-teamcity cockroach-teamcity added this to the 23.1 milestone Dec 15, 2022
@blathers-crl blathers-crl bot added the T-kv KV Team label Dec 15, 2022
@cockroach-teamcity
Copy link
Member Author

roachtest.copy/bank/rows=100000,nodes=5,txn=true failed with artifacts on master @ dcdf599e9eaee8010137167f419509ccb7627406:

test artifacts and logs in: /artifacts/copy/bank/rows=100000_nodes=5_txn=true/run_1
(test_impl.go:291).Fatal: monitor failure: monitor task failed: empty bank table split over multiple ranges

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=4 , ROACHTEST_encrypted=false , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

roachtest.copy/bank/rows=100000,nodes=5,txn=true failed with artifacts on master @ 7c8e7012b73a598f3aa1da9bbf422e833706f5d3:

test artifacts and logs in: /artifacts/copy/bank/rows=100000_nodes=5_txn=true/run_1
(test_impl.go:291).Fatal: monitor failure: monitor task failed: empty bank table split over multiple ranges

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=4 , ROACHTEST_encrypted=false , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

roachtest.copy/bank/rows=100000,nodes=5,txn=true failed with artifacts on master @ 93ed65565357538c9048ff45c878a493f2ed9b45:

test artifacts and logs in: /artifacts/copy/bank/rows=100000_nodes=5_txn=true/run_1
(test_impl.go:291).Fatal: monitor failure: monitor task failed: empty bank table split over multiple ranges

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=4 , ROACHTEST_encrypted=false , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

roachtest.copy/bank/rows=100000,nodes=5,txn=true failed with artifacts on master @ 94e03c016955dfd64d4e15358ea92226a8f362aa:

test artifacts and logs in: /artifacts/copy/bank/rows=100000_nodes=5_txn=true/run_1
(test_impl.go:291).Fatal: monitor failure: monitor task failed: empty bank table split over multiple ranges

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=4 , ROACHTEST_encrypted=false , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

roachtest.copy/bank/rows=100000,nodes=5,txn=true failed with artifacts on master @ 61f7c816574848f804f1adf7f42f7315bfcaaeba:

test artifacts and logs in: /artifacts/copy/bank/rows=100000_nodes=5_txn=true/run_1
(test_impl.go:291).Fatal: monitor failure: monitor task failed: empty bank table split over multiple ranges

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=4 , ROACHTEST_encrypted=false , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

This test on roachdash | Improve this report!

@pav-kv
Copy link
Collaborator

pav-kv commented Dec 20, 2022 •
edited
Loading

Looks similar to #91339. The error is different though.

@pav-kv pav-kv mentioned this issue Dec 20, 2022
Closed
@pav-kv
Copy link
Collaborator

pav-kv commented Dec 20, 2022

@knz This test started failing the day after your change 5604fea in SHOW RANGES, on a line that runs such a query. Could these events be related?

@erikgrinaker
Copy link
Contributor

erikgrinaker commented Dec 20, 2022 •
edited
Loading

@knz This test started failing the day after your change 5604fea in SHOW RANGES, on a line that runs such a query. Could these events be related?

Nice find, pretty sure it is. The test asserts that SHOW RANGES only returns a single range, but SHOW RANGES now includes secondary index ranges by default.

cockroach/pkg/cmd/roachtest/tests/copy.go

Line 74 in 21a286f

const q = "SELECT count(*) FROM [SHOW RANGES FROM TABLE bank.bank]"

The test can be fixed by changing the query to only consider the primary index, and ignore the secondary indexes, which is effectively what we did before that change:

SELECT count(*) FROM [SHOW RANGES FROM INDEX bank.bank@primary]

@pav-kv
Copy link
Collaborator

pav-kv commented Dec 20, 2022

Will send the fix, thanks for the suggestion!

@pav-kv pav-kv mentioned this issue Dec 20, 2022
Merged
@pav-kv pav-kv added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-testing Testing tools and infrastructure and removed release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Dec 20, 2022
@pav-kv pav-kv self-assigned this Dec 20, 2022
craig bot pushed a commit that referenced this issue Dec 20, 2022
@mgartner @pav-kv @jayshrivastava
Merge #90009 #93974 #93976
48ef0d8 
90009: util/intsets: use new intsets.Sparse implementation for util.FastIntSet r=mgartner a=mgartner

#### util: move FastIntSet to new pkg/util/intsets

Release note: None

#### intsets: rename FastIntSet to Fast

Release note: None

#### intsets: move bitmap into a separate file

Release note: None

#### intsets: add Sparse and use it in Fast

This commit replaces usages of the Sparse type in
golang.org/x/tools/container/intsets with a new `intsets.Sparse` type.
The new type is inspired by the `x/tools` type, but differs in several
ways:

  1. The new `Sparse` type provides a smaller API than the `x/tools`
     `Sparse` type, only containing the methods required by
     `intsets.Fast`.
  2. The new `Sparse` type is implemented as a singly-linked list of
     blocks rather than a circular, doubly-linked list.
  3. The new `Sparse` type reuses the `bitmap` type used in
     `intsets.Fast`. As a result, each block can store up to 128
     integers instead of 256.

This simpler implementation yields a performance boost in query
optimization of some types of queries.

Release note: None

#### intsets: do not shift values in Fast.large

Previously, `intsets.Fast` shifted values by 128 when storing them in
`Fast.large` to minimize allocations within `Fast.large` (see the
deleted comments in the diff). Now that `intsets.Sparse`'s uses
blocks with 128-bit bitmaps instead of 256-bit bitmaps, this shift no
longer provides any benefit, so it has been removed.

Release note: None

Epic: None


93974: roachtest: query only primary index in SHOW RANGES r=erikgrinaker a=pavelkalinnikov

The semantics of SHOW RANGES has changed in 5604fea, it now includes ranges of the secondary indicies. This change fixes the query to only request ranges of the primary index, to support the original assertion.

Fixes #93703
Release note: None

93976: sqlsmith: add crdb_internal.job_payload_type to blocklist r=jayshrivastava a=jayshrivastava

Previously, we would test the `crdb_internal.job_payload_type` builtin function with random values. Since this function unmarshals a `jobspb.Payload`, calling it with random bytes will always produce an error. We do not need to test this function under the smither.

Epic: none
Fixes: #93843

Release note: None

Co-authored-by: Marcus Gartner <[email protected]>
Co-authored-by: Pavel Kalinnikov <[email protected]>
Co-authored-by: Jayant Shrivastava <[email protected]>
@craig craig bot closed this as completed in 7b92c4e Dec 20, 2022
@knz
Copy link
Contributor

knz commented Dec 20, 2022

Thanks sorry i didn't catch thism

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pav-kv pav-kv

Labels
A-testing Testing tools and infrastructure branch-master Failures and bugs on the master branch. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. T-kv KV Team
Projects
None yet
Milestone
23.1
Development

Successfully merging a pull request may close this issue.

roachtest: query only primary index in SHOW RANGES pav-kv/cockroach
4 participants
@knz @erikgrinaker @pav-kv @cockroach-teamcity