Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multitenant: improve admin function RELOCATE {NON_}VOTING test cases #93420

Closed
ecwall opened this issue Dec 12, 2022 · 0 comments · Fixed by #93421
Closed

multitenant: improve admin function RELOCATE {NON_}VOTING test cases #93420

ecwall opened this issue Dec 12, 2022 · 0 comments · Fixed by #93421
Assignees
@ecwall
Labels
A-multitenancy Related to multi-tenancy C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@ecwall
Copy link
Contributor

ecwall commented Dec 12, 2022 •
edited by exalate-issue-sync bot
Loading

Address the TODO comments on these test cases fix the invalid test setup.

// TODO(ewall): Set up test to avoid "trying to add a voter to a store that already has a VOTER_FULL" error.

// TODO(ewall): Set up test to avoid "type of replica being removed (VOTER_FULL) does not match expectation for change" error.

// TODO(ewall): Set up test to avoid "list of voter targets overlaps with the list of non-voter targets" error.

Jira issue: CRDB-22327

Epic CRDB-16746
@ecwall ecwall added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-multitenancy Related to multi-tenancy T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) labels Dec 12, 2022
@ecwall ecwall self-assigned this Dec 12, 2022
@ecwall ecwall mentioned this issue Dec 12, 2022
Merged
craig bot pushed a commit that referenced this issue Dec 20, 2022
@ecwall @yuzefovich
Merge #93421 #93953
9890516 
93421: multitenant: improve admin function RELOCATE {NON_}VOTING test cases r=knz a=ecwall

Fixes #93420
    
Address the TODO comments on these test cases fix the invalid test setup.
    
Release note: None

93953: colflow: fix stale comments r=yuzefovich a=yuzefovich

This commit updates the comments that have become stale as of 661296f.

Epic: None

Release note: None

Co-authored-by: Evan Wall <[email protected]>
Co-authored-by: Yahor Yuzefovich <[email protected]>
@craig craig bot closed this as completed in 6297920 Dec 20, 2022
@exalate-issue-sync exalate-issue-sync bot reopened this Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ecwall ecwall

Labels
A-multitenancy Related to multi-tenancy C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

multitenant: improve admin function RELOCATE {NON_}VOTING test cases
1 participant
@ecwall