opt: remove unnecessary assignment casts on UDF return values #93210
Assignees
Labels
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Comments
mgartner
added
the
C-bug
craig bot
pushed a commit
that referenced
this issue
Dec 8, 2022
92628: sql: add SHOW TENANT name WITH REPLICATION STATUS r=lidorcarmel a=lidorcarmel Extending SHOW TENANT to also allow showing replication status which contains info such as the protected timestamp on the destination cluster and the source cluster name. Command output right after the destination cluster is created: ``` [email protected]:26257/defaultdb> show tenant dest5 with replication status; id | name | status | source_tenant_name | source_cluster_uri | replication_job_id | replicated_time | retained_time -----+-------+--------+--------------------+--------------------+--------------------+-----------------+---------------- 7 | dest5 | ADD | NULL | NULL | 819890711267737601 | NULL | NULL (1 row) ``` A bit later we have most stats (manually adjusting the source_cluster_uri): ``` [email protected]:26257/defaultdb> show tenant dest5 with replication status; id | name | status | source_tenant_name | source_cluster_uri | replication_job_id | replicated_time | retained_time -----+-------+--------+--------------------+-------------------------------------------------------+--------------------+-----------------+----------------------------- 7 | dest5 | ADD | src | postgresql://[email protected]:26257/defaultdb?ssl...crt | 819890711267737601 | NULL | 2022-12-05 23:00:04.516331 (1 row) ``` And a moment later the replication time is populated. Fixes: #91261 Epic: CRDB-18749 Release note: None 92774: scrun: added a cluster setting to skip planner sanity checks in prod r=Xiang-Gu a=Xiang-Gu Previously, there is a niche case where we might run into a backward incompatible issue (see #91528). We decided to fix it by relaxing the sanity check that caused the issue and backport the change to relase-22.2, so this backward incompatibility issue is contained only between release-22.2.0 and master, which we think should be a rare occurrance in the wild. Fixes: #91528 Release note: None 93103: roachprod: remove COCKROACH_UI_RELEASE_NOTES_SIGNUP_DISMISSED r=nkodali,herkolategan a=srosenberg Remove COCKROACH_UI_RELEASE_NOTES_SIGNUP_DISMISSED which had previously been used by roachprod circa 2020, until it got reverted in [1]. It has no effect after the PR which reverted the related change. Release note: None Epic: None [1] #57003 93150: ui: remove feedback survey link r=Santamaura a=Santamaura This change removes the survey feedback link from the admin ui due to the AppCues survey being retired. Fixes: #92867 Release note (ui change): remove feedback survey link 93215: opt: omit unnecessary assignment casts for UDF return values r=mgartner a=mgartner Previously, UDF return values were being assignment-casted to the return type of the UDF function when the types were identical. These casts are no longer created. Epic: CRDB-20370 Fixes #93210 Release note: None 93255: cli: flag doc updates r=andreimatei a=knz See the individual commits for details. Epic: None Co-authored-by: Lidor Carmel <[email protected]> Co-authored-by: Xiang Gu <[email protected]> Co-authored-by: Stan Rosenberg <[email protected]> Co-authored-by: Santamaura <[email protected]> Co-authored-by: Marcus Gartner <[email protected]> Co-authored-by: Raphael 'kena' Poss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In some cases an unnecessary cast is added to UDF returns values. This can prevent some optimizations from occurring. With the changes in #92955, the assignment casts prevent join decorrelation so UDFs are inlined as apply-joins rather than more efficient types of joins.
Epic: CRDB-20370
Jira issue: CRDB-22220
The text was updated successfully, but these errors were encountered: