Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loqrecovery: stage replica recovery plans on nodes #93044

Closed
aliher1911 opened this issue Dec 5, 2022 · 1 comment · Fixed by #95405
Closed

loqrecovery: stage replica recovery plans on nodes #93044

aliher1911 opened this issue Dec 5, 2022 · 1 comment · Fixed by #95405
Assignees
Labels
A-kv-replication Relating to Raft, consensus, and coordination. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@aliher1911
Copy link
Contributor

aliher1911 commented Dec 5, 2022

Add plan stading as described in RFC.

Add Admin RPC to stage plan on all cluster nodes. Staging includes discovering all cluster nodes, verifying that there's no conflicting plan already staged and sending plan to every nodes. Every nodes then saves plan locally if there's any data in the plan eligible for application on that node, it also updated decommissioned status for nodes removed in local tombstone storage.

Extend apply-plan command to distribute plan in half-online mode.

Part of #77273

Jira issue: CRDB-22132

Epic CRDB-14205

@aliher1911 aliher1911 added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-kv-replication Relating to Raft, consensus, and coordination. T-kv-replication labels Dec 5, 2022
@blathers-crl
Copy link

blathers-crl bot commented Dec 5, 2022

cc @cockroachdb/replication

craig bot pushed a commit that referenced this issue Jan 23, 2023
94390: loqrecovery: add storage for staged plans r=erikgrinaker a=aliher1911

Note: only the last commit belongs to this PR.

This commit adds storage mechanism to persist replica update plans
in the store directory to be able to apply upon node restart.

Release note: None

Part of #93044

94958: add CDC to add-to-project r=jlinder a=shermanCRL

Issues & PRs will be added to the [new CDC project](https://github.com/orgs/cockroachdb/projects/38). GitHub Projects v2 has a different (non-REST) API and blathers doesn't do that.


https://github.com/actions/add-to-project

Epic: none

95675: backupccl: handle placeholders for revision_history r=benbardin,adityamaru a=stevendanna

With the addition of ALTER BACKUP SCHEDULE, the revision_history option was changed to take an expression. However, we didn't update a few locations where we need to evaluate that expression.

As a result, you could create a scheduled backup using a placeholder for the value of revision_history, but that scheduled backup would always fail because the placeholder value isn't available when the job is created.

Epic: none

Release note: Fix a bug in which CREATE SCHEDULE would not properly handle a placeholder for the revision_history option.

Co-authored-by: Oleg Afanasyev <[email protected]>
Co-authored-by: Matt Sherman <[email protected]>
Co-authored-by: Steven Danna <[email protected]>
@craig craig bot closed this as completed in c8d92f3 Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-kv-replication Relating to Raft, consensus, and coordination. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant