Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest failures after upgrading jepsen core to 0.1.19 #92743

Closed
smg260 opened this issue Nov 30, 2022 · 2 comments
Closed

roachtest failures after upgrading jepsen core to 0.1.19 #92743

smg260 opened this issue Nov 30, 2022 · 2 comments
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. O-roachtest T-testeng TestEng Team

Comments

@smg260
Copy link
Contributor

smg260 commented Nov 30, 2022

Describe the problem

Nightly GCE jepsen roachtests consistently fail on master after merge of #92124

To Reproduce

On master -> roachtest run jepsen

Also, you can view daily failures in TC. e.g. Nov 28

image

Latest: #90695 (comment)

Jira issue: CRDB-21947

@smg260 smg260 added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. O-roachtest labels Nov 30, 2022
smg260 pushed a commit to smg260/cockroach that referenced this issue Nov 30, 2022
This reverts commit 4d1b9fc.
See cockroachdb#92743

Release note: None
Epic: None
@smg260 smg260 added the T-testeng TestEng Team label Nov 30, 2022
@blathers-crl
Copy link

blathers-crl bot commented Nov 30, 2022

cc @cockroachdb/test-eng

craig bot pushed a commit that referenced this issue Nov 30, 2022
92741: Revert "roachtest: update jepsen core to 0.1.19" r=smg260 a=smg260

This reverts commit 4d1b9fc.

See #92743

92767: cli: avoid generating ballast files for standalone SQL servers r=jaylim-crl a=knz

Fixes #92500.

In a previous PR, we merged the startup code path between `cockroach start` and `cockroach mt start-sql`. Doing so also (mostly) merged the default store config. This was incorrect, as standalone SQL servers should not receive an emergency ballast.

This patch fixes that.

Release note: None

Co-authored-by: Miral Gadani <[email protected]>
Co-authored-by: Raphael 'kena' Poss <[email protected]>
@smg260
Copy link
Contributor Author

smg260 commented Jan 12, 2023

Upgrade commit was reverted successfully.

@smg260 smg260 closed this as completed Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. O-roachtest T-testeng TestEng Team
Projects
None yet
Development

No branches or pull requests

1 participant