Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kv,server: tenant-scope nodes endpoint #92065

Closed
THardy98 opened this issue Nov 17, 2022 · 2 comments · Fixed by #93268
Closed

kv,server: tenant-scope nodes endpoint #92065

THardy98 opened this issue Nov 17, 2022 · 2 comments · Fixed by #93268
Assignees
@matthewtodd
Labels
A-kv-observability A-sql-observability Related to observability of the SQL layer C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@THardy98
Copy link

THardy98 commented Nov 17, 2022 •
edited by cockroach-jira-scripts
Loading

We would like to tenant-scope the /_status/nodes endpoint for use on our serverless platform. The endpoint should return the number of SQL nodes being used by the tenant.

Jira issue: CRDB-21557
@THardy98 THardy98 added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-kv-observability labels Nov 17, 2022
@matthewtodd matthewtodd mentioned this issue Nov 21, 2022
Closed
@matthewtodd matthewtodd self-assigned this Nov 30, 2022
@matthewtodd matthewtodd added A-sql-observability Related to observability of the SQL layer T-sql-observability labels Nov 30, 2022
@kevin-v-ngo
Copy link

@matthewtodd, in our triage, we discussed reassigning and requesting support from KV or Obs Inf on this. If so, feel free to update the 'Projects' to the appropriate team.

@matthewtodd
Copy link
Contributor

Thanks, @kevin-v-ngo, I took a crack at it today and will socialize what I learned tomorrow.

@matthewtodd matthewtodd mentioned this issue Dec 8, 2022
Merged
craig bot pushed a commit that referenced this issue Dec 9, 2022
@matthewtodd
Merge #93268
4a641ac 
93268: statusccl: temporarily serve /_status/nodes to tenants r=matthewtodd a=matthewtodd

Fixes #92065
Part of #89949

Our current UI architecture has many of the SQL Activity pages mapping node or sql instance ids to regions at page load time, using the response from this `/_status/nodes` endpoint to get the information it needs.

This approach is problematic for ephemeral serverless tenants but will need a broader reimagining, probably ending up with us storing locality information directly in many of the sqlstats tables, which will probably require something like sending instance localities along in the distsql tracing. An initial exploration in this direction happened in #92259.

In the meantime, as a stop-gap measure, we implement a reduced version of this `/_status/nodes` endpoint for tenants, keeping the SQL Activity pages somewhat working for multiregion tenants.

Release note: None

Co-authored-by: Matthew Todd <[email protected]>
@craig craig bot closed this as completed in 3750ea6 Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthewtodd matthewtodd

Labels
A-kv-observability A-sql-observability Related to observability of the SQL layer C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

statusccl: temporarily serve /_status/nodes to tenants
3 participants
@matthewtodd @THardy98 @kevin-v-ngo