sql: flake in TestCCLLogic_regional_by_row due to error in colflow.(*vectorizedFlow).Cleanup()
#91845
Assignees
Labels
A-sql-execution
Relating to SQL execution.
C-test-failure
Broken test (automatically or manually discovered).
T-sql-queries
SQL Queries Team
Comments
knz
added
C-test-failure
craig bot
pushed a commit
that referenced
this issue
Nov 14, 2022
91635: jobs: add a comment about the Resumer contract r=andreimatei a=andreimatei Release note: None Epic: None 91754: zip: move `--redact-logs` deprecation warning to end of zip output r=dhartunian a=abarganier This patch simply moves the deprecation notice for the `--redact-logs` flag to the bottom of the debug zip output. Previously, the message was logged at the beginning of the output, which was quickly drowned out by the rest of the output indicating the debug zip progress. Release note: none Addresses #91685 Epic: CRDB-12732 91830: sql/importer: skip a flaky test r=rafiss a=knz Informs #91828. Informs #91845. Informs #91850. Co-authored-by: Andrei Matei <[email protected]> Co-authored-by: Alex Barganier <[email protected]> Co-authored-by: Raphael 'kena' Poss <[email protected]>
craig bot
pushed a commit
that referenced
this issue
Nov 14, 2022
91160: sql: do not print stack trace when logging if txn is not open r=yuzefovich a=yuzefovich After executing each statement, that statement might be logged. If there were any audit events, then we attempt to resolve the table names for which the audit events have occurred. To do the resolution we're using the current txn. Previously, if that txn has been aborted or committed, it would result in a scary-looking stack trace added to the log, and this commit fixes it. Epic: None Release note: None 91563: jobs: clear job claim after execution r=ajwerner a=stevendanna Since #89014 the job system reset a job's claim when transitioning it from pause-requested to paused and from cancel-requested to reverting. The job system signals these transitions to the running Resumer by cancelling the job's context and does not wait for the resumer to exit. Once the claim is clear, another node can adopt the job and start running it's OnFailOrCancel callback. As a result, clearing the context makes it more likely that OnFailOrCancel executions will overlap with Resume executions. In general, Jobs need to assume that Resume may still be running while OnFailOrCancel is called. But, making it more likely isn't in our interest. Here, we only clear the lease when we exit the job state machine. This makes it much more likely that OnFailOrCancel doesn't start until Resume has returned. Epic: None Release note: None 91874: colflow: temporarily disable test assertion about closers r=yuzefovich a=yuzefovich Informs: #91845. Epic: None Release note: None Co-authored-by: Yahor Yuzefovich <[email protected]> Co-authored-by: Steven Danna <[email protected]>
This was referenced Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Found here:
https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_BazelEssentialCi/7503537?showRootCauses=false&expandBuildChangesSection=true&expandBuildDeploymentsSection=true&expandBuildProblemsSection=true&expandBuildTestsSection=true
cc @yuzefovich for triage.
Jira issue: CRDB-21455
The text was updated successfully, but these errors were encountered: