Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/upgrade/upgrades: alter-system-users-add-index fails when validating descriptors #91293

Closed
renatolabs opened this issue Nov 4, 2022 · 0 comments · Fixed by #91296
Closed

pkg/upgrade/upgrades: alter-system-users-add-index fails when validating descriptors #91293

renatolabs opened this issue Nov 4, 2022 · 0 comments · Fixed by #91296
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@renatolabs
Copy link
Contributor

renatolabs commented Nov 4, 2022 •
edited by cockroach-jira-scripts
Loading

Describe the problem

The alter-system-users-add-index has been failing in our acceptance tests with the following error:

I221104 15:54:21.618708 4388 jobs/registry.go:1295 ⋮ [n4] 305  job 811030483993362436: running execution encountered retriable error: non-cancelable: running migration for 1000022.1-36: error while validating descriptors during operation alter-system-users-add-index: expected descriptor doesn't match with found descriptor: ‹ConstraintID: 1 != 2›

Example failed build: https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_Ci_Tests_LocalRoachtest/7323188?showRootCauses=false&expandBuildChangesSection=true&expandBuildTestsSection=true

Jira issue: CRDB-21191
@renatolabs renatolabs added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-schema-deprecated Use T-sql-foundations instead labels Nov 4, 2022
@ajwerner ajwerner mentioned this issue Nov 4, 2022
Merged
craig bot pushed a commit that referenced this issue Nov 4, 2022
@ajwerner @renatolabs
Merge #91296
b1b3489 
91296: upgrades: make adding an index indifferent to constraint ID r=ajwerner a=ajwerner

The allocated constraint ID may be different from the one added at bootstrap, and that is okay. This PR also refactors the logic to decide what to zero to be more maintainable.

Fixes #91293

Release note: None

Co-authored-by: Andrew Werner <[email protected]>
Co-authored-by: Renato Costa <[email protected]>
@craig craig bot closed this as completed in 2d68728 Nov 4, 2022
@exalate-issue-sync exalate-issue-sync bot added T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) and removed T-sql-schema-deprecated Use T-sql-foundations instead labels May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

upgrades: make adding an index indifferent to constraint ID ajwerner/cockroach
1 participant
@renatolabs