Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

batcheval: TestAddSSTableSSTTimestampToRequestTimestampRespectsClosedTS is flakey #91211

Closed
renatolabs opened this issue Nov 3, 2022 · 1 comment · Fixed by #91226
Closed

batcheval: TestAddSSTableSSTTimestampToRequestTimestampRespectsClosedTS is flakey #91211

renatolabs opened this issue Nov 3, 2022 · 1 comment · Fixed by #91226
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). T-kv KV Team

Comments

@renatolabs
Copy link
Contributor

renatolabs commented Nov 3, 2022 •
edited by cockroach-jira-scripts
Loading 

    cmd_add_sstable_test.go:1728: 
        	Error Trace:	/home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/8031/execroot/com_github_cockroachdb_cockroach/bazel-out/k8-fastbuild/bin/pkg/kv/kvserver/batcheval/batcheval_test_/batcheval_test.runfiles/com_github_cockroachdb_cockroach/pkg/kv/kvserver/batcheval/cmd_add_sstable_test.go:1728
        	Error:      	Should not be zero, but was 0,0
        	Test:       	TestAddSSTableSSTTimestampToRequestTimestampRespectsClosedTS

Seen this in a recent bors run:

https://teamcity.cockroachdb.com/viewLog.html?buildId=7301543&buildTypeId=Cockroach_BazelEssentialCi

It also doesn't take too long to reproduce it if you stress the test:

17 runs completed, 1 failures, over 3s

Jira issue: CRDB-21155
@renatolabs renatolabs added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). T-kv KV Team labels Nov 3, 2022
renatolabs added a commit to renatolabs/cockroach that referenced this issue Nov 3, 2022
@renatolabs
kv/kvserver/batcheval: skip TestAddSSTableSSTTimestampToRequestTimest…
0b0a6f5 
…ampRespectsClosedTS

Refs: cockroachdb#91211

Reason: flaky test

Generated by bin/skip-test.

Release justification: non-production code changes

Release note: None
@renatolabs renatolabs mentioned this issue Nov 3, 2022
Closed
@erikgrinaker
Copy link
Contributor

Bisected down to 2c1c354.

@erikgrinaker erikgrinaker mentioned this issue Nov 3, 2022
Merged
@craig craig bot closed this as completed in 8a36b94 Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). T-kv KV Team
Projects
None yet
Milestone
No milestone
2 participants
@erikgrinaker @renatolabs