Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: make the Events endpoint tenant-scoped #90272

Closed
THardy98 opened this issue Oct 19, 2022 · 0 comments
Closed

server: make the Events endpoint tenant-scoped #90272

THardy98 opened this issue Oct 19, 2022 · 0 comments
Assignees
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@THardy98
Copy link

THardy98 commented Oct 19, 2022

Is your feature request related to a problem? Please describe.
Part of: #89429

As part of our effort to migrate to a multi-tenant architecture, we need to ensure our existing events endpoint is tenant-scoped.

Fortunately, the existing endpoint is implemented using SQL, meaning the remaining work to be done is implementing the same endpoint for our tenantAdminServer, where we can use the same eventsHelper function.

Reference PR: #84620, making the Jobs and Job endpoints tenant-scoped

Jira issue: CRDB-20668

@THardy98 THardy98 added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-observability labels Oct 19, 2022
THardy98 pushed a commit to THardy98/cockroach that referenced this issue Nov 11, 2022
Part of: cockroachdb#89429

Addresses: cockroachdb#90272 (blocked from resolving by cockroachdb#80789)

This change migrates the existing `/events` request to use the
sql-over-http endpoint on apiV2, making this request tenant-scoped once
the sql-over-http endpoint is scoped to tenants (this should be the case
when cockroachdb#91323 is completed).

Release note: None
@THardy98 THardy98 self-assigned this Nov 14, 2022
THardy98 pushed a commit to THardy98/cockroach that referenced this issue Nov 15, 2022
Part of: cockroachdb#89429

Addresses: cockroachdb#90272 (blocked from resolving by cockroachdb#80789)

This change migrates the existing `/events` request to use the
sql-over-http endpoint on apiV2, making this request tenant-scoped once
the sql-over-http endpoint is scoped to tenants (this should be the case
when cockroachdb#91323 is completed).

Release note: None
THardy98 pushed a commit to THardy98/cockroach that referenced this issue Nov 21, 2022
Part of: cockroachdb#89429

Addresses: cockroachdb#90272 (blocked from resolving by cockroachdb#80789)

This change migrates the existing `/events` request to use the
sql-over-http endpoint on apiV2, making this request tenant-scoped once
the sql-over-http endpoint is scoped to tenants (this should be the case
when cockroachdb#91323 is completed).

Release note: None
craig bot pushed a commit that referenced this issue Nov 21, 2022
91745: ui: move events endpoint to use sql-over-http r=THardy98 a=THardy98

Part of: #89429

Addresses: #90272 (blocked from resolving by #80789)

Demo (DB-Console only): https://www.loom.com/share/bb67044a8560407fb703af2a6bbb2d9a

This change migrates the existing `/events` request to use the sql-over-http endpoint on apiV2, making this request tenant-scoped once the sql-over-http endpoint is scoped to tenants (this should be the case when #91323 is completed).

Release note: None

Co-authored-by: Thomas Hardy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Development

No branches or pull requests

1 participant