schemachanger: v22.1.5 invalid concurrent declarative schema change job and legacy schema change jobs #87945
Comments
cockroach-teamcity
added
C-bug
yuzefovich
changed the title
|
This one is alarming to me. The good news is that the error will surface to the user immediately, so hopefully we'll get a support ticket or some user telling us what happened. |
|
This will happen if you have a mutation job but no mutations, we won't trigger the problems in the builder but we will run into this failure: cockroach/pkg/sql/catalog/descriptor.go Lines 222 to 224 in e3124b1 Here we check on both the mutations and the mutation jobs cockroach/pkg/sql/catalog/tabledesc/table_desc.go Lines 66 to 68 in 2675c7c In validation, we check for just one side of this condition. Instead we ought to detect the corrupt state and return a user visible error from the builder. |
|
This seems like it's a one-liner fix, let's do it. |
Previously, the contents of this slice were almost not validated. This has become a problem because the declarative schema changer relies on it to forbid schema changes concurrent with the legacy schema changer. This patch addresses this by adding the missing validation logic. Henceforth a nonempty MutationJobs slice implies a nonempty Mutations slice. Fixes cockroachdb#87945. Release note: None
91747: tabledesc: add validation for MutationJobs r=postamar a=postamar Previously, the contents of this slice were almost not validated. This has become a problem because the declarative schema changer relies on it to forbid schema changes concurrent with the legacy schema changer. This patch addresses this by adding the missing validation logic. Henceforth a nonempty MutationJobs slice implies a nonempty Mutations slice. Fixes #87945. Release note: None 91871: colexecdisk: fix a rare flake in TestExternalSortMemoryAccounting r=yuzefovich a=yuzefovich We recently made a change in how we're growing the flat buffer for non-inlined values in the Bytes vector (we now double the capacity). This means that we now might exceed the memory limit sooner (in terms of the batches buffered) than previously since we now have larger allocated capacity. This also triggers a difference in how we're calculating the "proportional size" of the first `n` elements of the Bytes vector. As a result, a test became flaky since we now might create less partitions than the test expects, so this commit relaxes the assertion. I did spend some time looking into whether the new behavior is concerning, and I don't think it is. Fixes: #91850. Release note: None Co-authored-by: Marius Posta <[email protected]> Co-authored-by: Yahor Yuzefovich <[email protected]>
exalate-issue-sync
bot
added
T-sql-foundations
This issue was autofiled by Sentry. It represents a crash or reported error on a live cluster with telemetry enabled.
Sentry link: https://sentry.io/organizations/cockroach-labs/issues/3589297084/?referrer=webhooks_plugin
Panic message:
Stacktrace (expand for inline code snippets):
cockroach/pkg/sql/schemachanger/scrun/scrun.go
Lines 159 to 161 in a30a663
cockroach/pkg/sql/schemachanger/scrun/scrun.go
Lines 72 to 74 in a30a663
cockroach/pkg/sql/schemachanger/scrun/scrun.go
Lines 46 to 48 in a30a663
cockroach/pkg/sql/conn_executor.go
Lines 3200 to 3202 in a30a663
cockroach/pkg/sql/conn_executor_exec.go
Lines 946 to 948 in a30a663
cockroach/pkg/sql/conn_executor_exec.go
Lines 887 to 889 in a30a663
cockroach/pkg/sql/conn_executor_exec.go
Lines 2073 to 2075 in a30a663
cockroach/pkg/sql/conn_executor_exec.go
Lines 519 to 521 in a30a663
cockroach/pkg/sql/conn_executor_exec.go
Lines 733 to 735 in a30a663
cockroach/pkg/sql/conn_executor_exec.go
Lines 142 to 144 in a30a663
cockroach/pkg/sql/conn_executor.go
Lines 1883 to 1885 in a30a663
cockroach/pkg/sql/conn_executor.go
Lines 1887 to 1889 in a30a663
cockroach/pkg/sql/conn_executor.go
Lines 1809 to 1811 in a30a663
cockroach/pkg/sql/conn_executor.go
Lines 755 to 757 in a30a663
cockroach/pkg/sql/pgwire/conn.go
Lines 726 to 728 in a30a663
GOROOT/src/runtime/asm_amd64.s#L1580-L1582 in runtime.goexit
v22.1.5Jira issue: CRDB-19608
The text was updated successfully, but these errors were encountered: