Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: roachprod-stress artifacts aren't in the right place #87643

Closed
ajwerner opened this issue Sep 8, 2022 · 0 comments · Fixed by #87659
Closed

dev: roachprod-stress artifacts aren't in the right place #87643

ajwerner opened this issue Sep 8, 2022 · 0 comments · Fixed by #87659
Assignees
Labels
A-build-system C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-dev-inf

Comments

@ajwerner
Copy link
Contributor

ajwerner commented Sep 8, 2022

Is your feature request related to a problem? Please describe.
Here we assume that we have an artifacts directory where stuff lives, but the artifacts themselves aren't in the proper location.

roachprodStressArgs := []string{cluster, fmt.Sprintf("./%s", pkg), "-testbin", filepath.Join(workspace, "artifacts", testTargetBasename), "-stressbin", filepath.Join(workspace, "artifacts", "stress"), "-libdir", filepath.Join(workspace, "artifacts", "libgeos", "lib")}

I assume this comes from stageArtifacts, but the geos libs are not in artifacts/libgeos/lib/..., rather, they are in artifacts directly.

$ ls -la artifacts/
total 843852
drwxr-xr-x   8 ajwerner ajwerner      4096 Sep  8 19:43 .
drwxrwxr-x  43 ajwerner ajwerner      4096 Sep  8 19:55 ..
drwxr-xr-x   3 ajwerner ajwerner      4096 Aug 23 16:40 _runner-logs
drwxr-xr-x   3 ajwerner ajwerner      4096 Mar 22 18:39 acceptance
-rwxrwxrwx   1 ajwerner ajwerner 362715656 Jul 28 18:14 cockroach
-rwxrwxrwx   1 ajwerner ajwerner 343813208 Mar 22 18:04 cockroach-short
-rw-rw-r--   1 ajwerner ajwerner       592 Jun 23 14:45 dev.log
drwx------ 965 ajwerner ajwerner     20480 Mar 28 14:48 go-build2658530123
drwxr-xr-x   3 ajwerner ajwerner      4096 Mar 23 13:40 knex
-rwxrwxrwx   1 ajwerner ajwerner   2610888 Sep  8 19:56 libgeos.so
-rwxrwxrwx   1 ajwerner ajwerner    356184 Sep  8 19:56 libgeos_c.so
drwxr-xr-x   3 ajwerner ajwerner      4096 Aug 23 16:38 schemachange
-rwxrwxrwx   1 ajwerner ajwerner 151838184 Sep  8 19:56 schemachange_test
-rwxrwxrwx   1 ajwerner ajwerner   2701606 Sep  8 19:56 stress
drwxr-xr-x   3 ajwerner ajwerner      4096 Mar 18 01:12 tpcc

I'm not totally certain how they end up here.

Jira issue: CRDB-19457
Epic CRDB-15061

@ajwerner ajwerner added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Sep 8, 2022
healthy-pod pushed a commit to healthy-pod/cockroach that referenced this issue Sep 8, 2022
…ress

Previously, `geos libs` were created under the `artifacts` directory.

This code change copies them into their own directory. It also removes
a few unneeded steps.

Closes cockroachdb#87643

Release note: None
craig bot pushed a commit that referenced this issue Sep 9, 2022
87659: dev: ensure libdir is created and populated when running roachprod-stress r=rickystewart a=healthy-pod

Previously, `geos libs` were created under the `artifacts` directory.

This code change copies them into their own directory.
Closes #87643

Release note: None

87660: dev: build more stuff with linting turned on as part of `dev lint` r=healthy-pod a=rickystewart

This will find more failures in more components.

Release note: None

Co-authored-by: healthy-pod <[email protected]>
Co-authored-by: Ricky Stewart <[email protected]>
@craig craig bot closed this as completed in b756923 Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-build-system C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-dev-inf
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants