Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent capitalization of column headings and fields in Databases pages #87437

Closed
ghost opened this issue Sep 6, 2022 · 0 comments · Fixed by #87497
Closed

Consistent capitalization of column headings and fields in Databases pages #87437

ghost opened this issue Sep 6, 2022 · 0 comments · Fixed by #87497
Assignees
@j82w
Labels
A-sql-observability Related to observability of the SQL layer C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@ghost
Copy link

ghost commented Sep 6, 2022 •
edited by ghost
Loading

This one correctly shows heading case, which is every word having an initial cap.

Screen Shot 2022-09-06 at 10 42 31 AM

These three screenshots show inconsistent capitalization of column headings and fields. Some are heading case and some are sentence case, with only the first word with initial cap.

Screen Shot 2022-09-06 at 10 42 19 AM

Screen Shot 2022-09-06 at 10 42 44 AM

Screen Shot 2022-09-06 at 10 48 18 AM

The Index recommendations column should be Index Recommendations.
The Range count column should be Range Count
The Regions/nodes column and field should be Regions/Nodes

Jira issue: CRDB-19348
@ghost ghost added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-sql-observability Related to observability of the SQL layer T-sql-observability labels Sep 6, 2022
@ghost ghost changed the title Consistent capitalization of column headings in Databases pages Consistent capitalization of column headings and fields in Databases pages Sep 6, 2022
@j82w j82w self-assigned this Sep 7, 2022
@j82w j82w mentioned this issue Sep 7, 2022
Merged
craig bot pushed a commit that referenced this issue Sep 7, 2022
Merge #87497
1ac25dc 
87497: ui: fix database page column capitalization r=j82w a=j82w

Fixed capitalization on following fields Index recommendations to Index Recommendations, Range count to Range Count,
and Regions/nodes to Regions/Nodes

closes #87437

<img width="1707" alt="Screen Shot 2022-09-07 at 10 33 07 AM" src="https://user-images.githubusercontent.com/8868107/188905195-ff8148e6-d153-4114-a26d-d23657c8d674.png">

<img width="824" alt="Screen Shot 2022-09-07 at 10 33 40 AM" src="https://user-images.githubusercontent.com/8868107/188905166-bea29727-58ab-4429-ba34-12ae92bd02fa.png">

Release justification: Category 2: Bug fixes and
low-risk updates to new functionality

Release note: None

Co-authored-by: j82w <[email protected]>
@craig craig bot closed this as completed in 7603d84 Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@j82w j82w

Labels
A-sql-observability Related to observability of the SQL layer C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ui: fix database page column capitalization
1 participant
@j82w