Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: add column selector to statement insights page #87021

Closed
j82w opened this issue Aug 29, 2022 · 0 comments · Fixed by #87171
Closed

ui: add column selector to statement insights page #87021

j82w opened this issue Aug 29, 2022 · 0 comments · Fixed by #87171
Assignees
@j82w
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@j82w
Copy link
Contributor

j82w commented Aug 29, 2022 •
edited by cockroach-jira-scripts
Loading

The column selector needs to be added to the statement insights page based on figma: https://www.figma.com/file/xpnRkP9cLXERVceRC4cec4/22.2_SQL-obsrv_query-performance?node-id=1086%3A86673

Jira issue: CRDB-19103
@j82w j82w added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-observability labels Aug 29, 2022
@j82w j82w self-assigned this Aug 29, 2022
@j82w j82w mentioned this issue Aug 31, 2022
Merged
craig bot pushed a commit that referenced this issue Aug 31, 2022
@e-mbrown
Merge #86695 #87171
121ead5 
86695: sql: Update pgjdbc blocklist r=rafiss a=e-mbrown

Closes #85882

Release justification: Non-production code changes
Release note: None

87171: ui: add columns and column selector to statement insights r=j82w a=j82w

Adds column selector to statement insights page and adds 
new contention, full scan, transaction id, transaction fingerprint id,
and rows read/written.

closes #87021

https://www.loom.com/share/d4d6f567cefe4928a62cfbe39e9d15e0

Release justification: Category 2: Bug fixes and
low-risk updates to new functionality

Release note (ui change): Adds column selector to
statement insights page and adds new contention,
full scan, transaction id, transaction fingerprint id,
and rows read/written.

Co-authored-by: e-mbrown <[email protected]>
Co-authored-by: j82w <[email protected]>
@craig craig bot closed this as completed in c42be29 Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@j82w j82w

Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ui: add columns and column selector to statement insights
1 participant
@j82w