sql/schemachanger: Mixed version drop operations can fail due to OFFLINE state #86691
Assignees
Labels
branch-release-22.2
Used to mark GA and release blockers, technical advisories, and bugs for 22.2
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
release-blocker
Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.
T-sql-foundations
SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Comments
fqazi
added
C-bug
Xiang-Gu
pushed a commit
to Xiang-Gu/cockroach
that referenced
this issue
Aug 26, 2022
…ules Previously we had implicit rules in opgen which were used to enforce sequencing between transitions. This was brittle and made it hard to collapse certain edges. Now that we can represent a not-join, we can add the rules we want selectively, only when descriptors are not being dropped. Fixes cockroachdb#86691 Fixes cockroachdb#86626 Release justification: fixes a bug Release note: None
Xiang-Gu
pushed a commit
to ajwerner/cockroach
that referenced
this issue
Aug 29, 2022
…ules Previously we had implicit rules in opgen which were used to enforce sequencing between transitions. This was brittle and made it hard to collapse certain edges. Now that we can represent a not-join, we can add the rules we want selectively, only when descriptors are not being dropped. Fixes cockroachdb#86691 Fixes cockroachdb#86626 Release justification: fixes a bug Release note: None
ajwerner
added a commit
to ajwerner/cockroach
that referenced
this issue
Aug 30, 2022
…ules Previously we had implicit rules in opgen which were used to enforce sequencing between transitions. This was brittle and made it hard to collapse certain edges. Now that we can represent a not-join, we can add the rules we want selectively, only when descriptors are not being dropped. Fixes cockroachdb#86691 Fixes cockroachdb#86626 Release justification: fixes a bug Release note: None
Xiang-Gu
pushed a commit
to Xiang-Gu/cockroach
that referenced
this issue
Aug 31, 2022
…ules Previously we had implicit rules in opgen which were used to enforce sequencing between transitions. This was brittle and made it hard to collapse certain edges. Now that we can represent a not-join, we can add the rules we want selectively, only when descriptors are not being dropped. Fixes cockroachdb#86691 Fixes cockroachdb#86626 Release justification: fixes a bug Release note: None
postamar
pushed a commit
to postamar/cockroach
that referenced
this issue
Aug 31, 2022
…ules Previously we had implicit rules in opgen which were used to enforce sequencing between transitions. This was brittle and made it hard to collapse certain edges. Now that we can represent a not-join, we can add the rules we want selectively, only when descriptors are not being dropped. Fixes cockroachdb#86691 Fixes cockroachdb#86626 Release justification: fixes a bug Release note: None
postamar
pushed a commit
to postamar/cockroach
that referenced
this issue
Sep 1, 2022
…ules Previously we had implicit rules in opgen which were used to enforce sequencing between transitions. This was brittle and made it hard to collapse certain edges. Now that we can represent a not-join, we can add the rules we want selectively, only when descriptors are not being dropped. Fixes cockroachdb#86691 Fixes cockroachdb#86626 Release justification: fixes a bug Release note: None
ajwerner
added a commit
to ajwerner/cockroach
that referenced
this issue
Sep 1, 2022
…ules Previously we had implicit rules in opgen which were used to enforce sequencing between transitions. This was brittle and made it hard to collapse certain edges. Now that we can represent a not-join, we can add the rules we want selectively, only when descriptors are not being dropped. Fixes cockroachdb#86691 Fixes cockroachdb#86626 Release justification: fixes a bug Release note: None
ajwerner
added a commit
to ajwerner/cockroach
that referenced
this issue
Sep 1, 2022
…ules Previously we had implicit rules in opgen which were used to enforce sequencing between transitions. This was brittle and made it hard to collapse certain edges. Now that we can represent a not-join, we can add the rules we want selectively, only when descriptors are not being dropped. Fixes cockroachdb#86691 Fixes cockroachdb#86626 Release justification: fixes a bug Release note: None
exalate-issue-sync
bot
added
T-sql-foundations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When dropping objects in a mixed version state, we encountered failures related to the offline state:
failed to validate TestLogic_system_privileges_mixed_TestLogic_system_privileges_mixed_DROP DATABASE test CASCADE_1 with error invalid execution plan: final status is 15 instead of ABSENT at index 5 for adding Database:{DescID: 104}The previous version of cockroach at 22.1 cannot plan for this state, which could lead to issues. This can be reproduced by generating a corpus on logictest --declartaive-corpus option on 22.1 and using it on 22.1 via cockroach debug.
Jira issue: CRDB-18872
The text was updated successfully, but these errors were encountered: