Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql/opt: add table setting to disable statistics forecasting #86353

Closed
michae2 opened this issue Aug 17, 2022 · 0 comments · Fixed by #86986
Closed

sql/opt: add table setting to disable statistics forecasting #86353

michae2 opened this issue Aug 17, 2022 · 0 comments · Fixed by #86986
Assignees
Labels
A-sql-optimizer SQL logical planning and optimizations. A-sql-table-stats Table statistics (and their automatic refresh). C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-queries SQL Queries Team

Comments

@michae2
Copy link
Collaborator

michae2 commented Aug 17, 2022

Follow up from #79872: now that statistics forecasts are enabled for all tables, we should add a table setting to disable forecasting, similar to #78110. We already have some of this in place from #79025.

Jira issue: CRDB-18709

@michae2 michae2 added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-sql-optimizer SQL logical planning and optimizations. T-sql-queries SQL Queries Team labels Aug 17, 2022
@michae2 michae2 self-assigned this Aug 17, 2022
@michae2 michae2 added the A-sql-table-stats Table statistics (and their automatic refresh). label Aug 17, 2022
michae2 added a commit to michae2/cockroach that referenced this issue Aug 27, 2022
Add a new storage parameter (a.k.a. table setting) which can be used to
override cluster setting `sql.stats.forecasts.enabled`. This builds on
work done earlier in cockroachdb#79025 and cockroachdb#86932 so we don't have to do much, just
wire it all together.

Fixes: cockroachdb#86353

Release justification: Low-risk update to new functionality.

Release note (sql change): Add a new table setting
`sql_stats_forecasts_enabled` which controls whether statistics
forecasts are generated for a specific table. When set, this overrides
cluster setting `sql.stats.forecasts.enabled`.
craig bot pushed a commit that referenced this issue Aug 28, 2022
86986: sql/stats: add table setting to disable generation of stats forecasts r=rytaft,msirek a=michae2

Add a new storage parameter (a.k.a. table setting) which can be used to
override cluster setting `sql.stats.forecasts.enabled`. This builds on
work done earlier in #79025 and #86932 so we don't have to do much, just
wire it all together.

Fixes: #86353

Release justification: Low-risk update to new functionality.

Release note (sql change): Add a new table setting
`sql_stats_forecasts_enabled` which controls whether statistics
forecasts are generated for a specific table. When set, this overrides
cluster setting `sql.stats.forecasts.enabled`.

Co-authored-by: Michael Erickson <[email protected]>
@craig craig bot closed this as completed in f5936b0 Aug 28, 2022
@mgartner mgartner moved this to Done in SQL Queries Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sql-optimizer SQL logical planning and optimizations. A-sql-table-stats Table statistics (and their automatic refresh). C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-queries SQL Queries Team
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant