pkg/ccl/logictestccl/tests/multiregion-9node-3region-3azs/multiregion-9node-3region-3azs_test: TestCCLLogic_regional_by_row_query_behavior failed #86284
Assignees
Labels
branch-master
Failures and bugs on the master branch.
C-test-failure
Broken test (automatically or manually discovered).
O-robot
Originated from a bot.
T-sql-queries
SQL Queries Team
Milestone
Comments
cockroach-teamcity
added
branch-master
|
pkg/ccl/logictestccl/tests/multiregion-9node-3region-3azs/multiregion-9node-3region-3azs_test.TestCCLLogic_regional_by_row_query_behavior failed with artifacts on master @ 869d44cb46ba1900202eb9e33a3353eecf06b269: Parameters: |
|
@msirek can you please take a look at this? This is one of the test cases for locality optimized search with LIMIT |
msirek
pushed a commit
to msirek/cockroach
that referenced
this issue
Sep 5, 2022
Fixes cockroachdb#86284 This fixes a test flake in regional_by_row_query_behavior which is likely caused by zone configs not being made available between table creation time and query execution time. A sleep test directive is added to allow zone configs time to become available. Release justification: low risk fix for test flake Release note: None
msirek
pushed a commit
to msirek/cockroach
that referenced
this issue
Sep 8, 2022
Fixes cockroachdb#86284 This fixes a test flake in regional_by_row_query_behavior which is likely caused by 2 issues: 1. Zone configs not becoming available in `SystemConfig` between table creation time and query execution time. 2. Metamorphic settings cause the query plan to change and not choose locality-optimized search, which this test is dependent on. The flake can be reproduced via the command: ``` ./dev testlogic ccl --files=regional_by_row_query_behavior \ --config=multiregion-9node-3region-3azs --stress ``` For point 1, the `retry` logic test directive is enhanced to purge the zone config cache in the SystemConfig when a failing test is retried, allowing the updated zone config to be read. For point 2, the logic test blocking flag `!metamorphic` is repurposed to do what it says, skip the test if metamorphic settings are enabled in the current build. The pre-existing flag of the same name is renamed to `!metamorphic-batch-sizes` to avoid confusion, since it resets any batch size related metamorphic settings back to their default production values when running in metamorphic mode. Release justification: low risk fix for test flake Release note: None
msirek
pushed a commit
to msirek/cockroach
that referenced
this issue
Sep 8, 2022
Fixes cockroachdb#86284 This fixes a test flake in regional_by_row_query_behavior which is caused by 2 issues: 1. Zone configs not becoming available in `SystemConfig` between table creation time and query execution time. 2. Metamorphic testing modify the `coldata-batch-size` setting, causing a different number of kv reads to be done, which affects the kv trace results in this test. The flake can be reproduced via the command: ``` ./dev testlogic ccl --files=regional_by_row_query_behavior \ --config=multiregion-9node-3region-3azs --stress ``` For point 1, the `retry` logic test directive is enhanced to purge the zone config cache in the SystemConfig when a failing test is retried, allowing the updated zone config to be read. For point 2, the logic test blocking flag `!metamorphic` which resets batch size related settings that were modified in metamorphic mode back to their default production values, is updated to also cover the `coldata-batch-size` setting. The flag is renamed to `!metamorphic-batch-sizes` to better reflect its actual effect. Release justification: low risk fix for test flake Release note: None
msirek
pushed a commit
to msirek/cockroach
that referenced
this issue
Sep 8, 2022
Fixes cockroachdb#86284 This fixes a test flake in regional_by_row_query_behavior which is caused by 2 issues: 1. Zone configs not becoming available in `SystemConfig` between table creation time and query execution time. 2. Metamorphic testing modify the `coldata-batch-size` setting, causing a different number of kv reads to be done, which affects the kv trace results in this test. The flake can be reproduced via the command: ``` ./dev testlogic ccl --files=regional_by_row_query_behavior \ --config=multiregion-9node-3region-3azs --stress ``` For point 1, the `retry` logic test directive is enhanced to purge the zone config cache in the SystemConfig when a failing test is retried, allowing the updated zone config to be read. For point 2, the logic test blocking flag `!metamorphic` which resets batch size related settings that were modified in metamorphic mode back to their default production values, is updated to also cover the `coldata-batch-size` setting. The flag is renamed to `!metamorphic-batch-sizes` to better reflect its actual effect. Release justification: low risk fix for test flake Release note: None
msirek
pushed a commit
to msirek/cockroach
that referenced
this issue
Sep 8, 2022
Fixes cockroachdb#86284 This fixes a test flake in regional_by_row_query_behavior which is caused by 2 issues: 1. Zone configs not becoming available in `SystemConfig` between table creation time and query execution time. 2. Metamorphic testing modify the `coldata-batch-size` setting, causing a different number of kv reads to be done, which affects the kv trace results in this test. The flake can be reproduced via the command: ``` ./dev testlogic ccl --files=regional_by_row_query_behavior \ --config=multiregion-9node-3region-3azs --stress ``` For point 1, the `retry` logic test directive is enhanced to purge the zone config cache in the SystemConfig when a failing test is retried, allowing the updated zone config to be read. For point 2, the logic test blocking flag `!metamorphic` which resets batch size related settings that were modified in metamorphic mode back to their default production values, is updated to also cover the `coldata-batch-size` setting. The flag is renamed to `!metamorphic-batch-sizes` to better reflect its actual effect. Release justification: low risk fix for test flake Release note: None
craig bot
pushed a commit
that referenced
this issue
Sep 18, 2022
87391: logictestccl: Fix regional_by_row_query_behavior flake r=msirek a=msirek Fixes #86284 This fixes a test flake in regional_by_row_query_behavior which is caused by 2 issues: 1. Zone configs not becoming available in `SystemConfig` between table creation time and query execution time. 2. Metamorphic testing modify the `coldata-batch-size` setting, causing a different number of kv reads to be done, which affects the kv trace results in this test. The flake can be reproduced via the command: ``` ./dev testlogic ccl --files=regional_by_row_query_behavior \ --config=multiregion-9node-3region-3azs --stress ``` For point 1, the `retry` logic test directive is enhanced to purge the zone config cache in the SystemConfig when a failing test is retried, allowing the updated zone config to be read. For point 2, the logic test blocking flag `!metamorphic` which resets batch size related settings that were modified in metamorphic mode back to their default production values, is updated to also cover the `coldata-batch-size` setting. The flag is renamed to `!metamorphic-batch-sizes` to better reflect its actual effect. Release justification: low risk fix for test flake Release note: None Co-authored-by: Mark Sirek <[email protected]>
msirek
pushed a commit
to msirek/cockroach
that referenced
this issue
Jun 29, 2023
Fixes cockroachdb#86284 This fixes a test flake in regional_by_row_query_behavior which is caused by 2 issues: 1. Zone configs not becoming available in `SystemConfig` between table creation time and query execution time. 2. Metamorphic testing modify the `coldata-batch-size` setting, causing a different number of kv reads to be done, which affects the kv trace results in this test. The flake can be reproduced via the command: ``` ./dev testlogic ccl --files=regional_by_row_query_behavior \ --config=multiregion-9node-3region-3azs --stress ``` For point 1, the `retry` logic test directive is enhanced to purge the zone config cache in the SystemConfig when a failing test is retried, allowing the updated zone config to be read. For point 2, the logic test blocking flag `!metamorphic` which resets batch size related settings that were modified in metamorphic mode back to their default production values, is updated to also cover the `coldata-batch-size` setting. The flag is renamed to `!metamorphic-batch-sizes` to better reflect its actual effect. Release justification: low risk fix for test flake Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
pkg/ccl/logictestccl/tests/multiregion-9node-3region-3azs/multiregion-9node-3region-3azs_test.TestCCLLogic_regional_by_row_query_behavior failed with artifacts on master @ b173a16715e71e94115820374da1eb350b3b459d:
Parameters:
TAGS=bazel,gssHelp
See also: How To Investigate a Go Test Failure (internal)
This test on roachdash | Improve this report!
Jira issue: CRDB-18664
The text was updated successfully, but these errors were encountered: