Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: django failed #86010

Closed
cockroach-teamcity opened this issue Aug 12, 2022 · 8 comments · Fixed by #86273
Closed

roachtest: django failed #86010

cockroach-teamcity opened this issue Aug 12, 2022 · 8 comments · Fixed by #86273
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot.
Milestone
22.2

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Aug 12, 2022 •
edited by cockroach-jira-scripts
Loading

roachtest.django failed with artifacts on master @ 773f7d4445ce3e0e806b7a182adba70a0f270f19:

test artifacts and logs in: /artifacts/django/run_1
	orm_helpers.go:141,orm_helpers.go:117,django.go:223,django.go:234,test_runner.go:896: No tests ran! Fix the testing commands.

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=16 , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

/cc @cockroachdb/sql-experience

This test on roachdash | Improve this report!

Jira issue: CRDB-18524
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Aug 12, 2022
@cockroach-teamcity cockroach-teamcity added this to the 22.2 milestone Aug 12, 2022
@cockroach-teamcity cockroach-teamcity mentioned this issue Aug 12, 2022
Closed
@cockroach-teamcity
Copy link
Member Author

roachtest.django failed with artifacts on master @ 0dd438d3dc0b42543890455945a7a6b42811def1:

test artifacts and logs in: /artifacts/django/run_1
	orm_helpers.go:141,orm_helpers.go:117,django.go:223,django.go:234,test_runner.go:896: No tests ran! Fix the testing commands.

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=16 , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

roachtest.django failed with artifacts on master @ 0dd438d3dc0b42543890455945a7a6b42811def1:

test artifacts and logs in: /artifacts/django/run_1
	orm_helpers.go:141,orm_helpers.go:117,django.go:223,django.go:234,test_runner.go:896: No tests ran! Fix the testing commands.

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=16 , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

roachtest.django failed with artifacts on master @ d25cb57ccd9bc643ce9058ebd2057cab36b69ad5:

test artifacts and logs in: /artifacts/django/run_1
	orm_helpers.go:141,orm_helpers.go:117,django.go:223,django.go:234,test_runner.go:896: No tests ran! Fix the testing commands.

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=16 , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

roachtest.django failed with artifacts on master @ 41db784cb97d2749b162020c2c821979094f87b1:

test artifacts and logs in: /artifacts/django/run_1
	orm_helpers.go:141,orm_helpers.go:117,django.go:223,django.go:234,test_runner.go:896: No tests ran! Fix the testing commands.

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=16 , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@ZhouXing19 ZhouXing19 removed the release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. label Aug 15, 2022
@ZhouXing19
Copy link
Collaborator 

ImportError: cannot import name 'RemovedInDjango41Warning' from 'django.utils.deprecation' (/usr/local/lib/python3.8/dist-packages/django/utils/deprecation.py)

I suspect it's related to a version update too, as in #86011

@cockroach-teamcity
Copy link
Member Author

roachtest.django failed with artifacts on master @ f4042d47fa8062a612c38d4696eb6bee9cee7c21:

test artifacts and logs in: /artifacts/django/run_1
	orm_helpers.go:141,orm_helpers.go:117,django.go:223,django.go:234,test_runner.go:896: No tests ran! Fix the testing commands.

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=16 , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@ZhouXing19
Copy link
Collaborator

ZhouXing19 commented Aug 16, 2022 •
edited
Loading

I cannot repro this one either, in my local trial it just passed.

@ZhouXing19 ZhouXing19 mentioned this issue Aug 16, 2022
Merged
@cockroach-teamcity
Copy link
Member Author

roachtest.django failed with artifacts on master @ b173a16715e71e94115820374da1eb350b3b459d:

test artifacts and logs in: /artifacts/django/run_1
	orm_helpers.go:141,orm_helpers.go:117,django.go:223,django.go:234,test_runner.go:896: No tests ran! Fix the testing commands.

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=16 , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

This test on roachdash | Improve this report!

craig bot pushed a commit that referenced this issue Aug 17, 2022
@nvanbenschoten @adityamaru @ZhouXing19
Merge #86236 #86257 #86273
2aeed01 
86236: tracing: re-use childrenMetadata map across trace spans r=nvanbenschoten a=nvanbenschoten

This commit pools the `childrenMetadata` hash map across trace spans,
to avoid a source of per-span heap allocations. This hash map was
added in 4ddc350, after prior optimization passes were made over the
`util/tracing` package.

This should help close the performance gap between v22.1 and v22.2.

```
name                        old time/op    new time/op    delta
KV/Insert/Native/rows=1-10    41.7µs ± 2%    41.4µs ± 1%  -0.72%  (p=0.026 n=20+18)
KV/Insert/SQL/rows=1-10        123µs ± 2%     124µs ± 2%    ~     (p=0.665 n=19+19)
KV/Update/Native/rows=1-10    66.0µs ± 2%    65.8µs ± 1%    ~     (p=0.258 n=20+19)
KV/Update/SQL/rows=1-10        170µs ± 3%     170µs ± 4%    ~     (p=0.851 n=18+20)
KV/Delete/Native/rows=1-10    41.5µs ± 2%    41.4µs ± 1%    ~     (p=0.740 n=20+18)
KV/Delete/SQL/rows=1-10        137µs ± 2%     137µs ± 2%    ~     (p=0.377 n=20+18)
KV/Scan/Native/rows=1-10      17.2µs ± 2%    17.2µs ± 3%    ~     (p=0.920 n=20+20)
KV/Scan/SQL/rows=1-10         92.2µs ± 1%    92.2µs ± 2%    ~     (p=0.667 n=20+19)

name                        old alloc/op   new alloc/op   delta
KV/Scan/SQL/rows=1-10         24.8kB ± 0%    24.3kB ± 0%  -2.00%  (p=0.000 n=19+19)
KV/Scan/Native/rows=1-10      7.80kB ± 0%    7.65kB ± 0%  -1.86%  (p=0.000 n=20+18)
KV/Delete/Native/rows=1-10    15.9kB ± 1%    15.6kB ± 0%  -1.48%  (p=0.000 n=20+17)
KV/Update/Native/rows=1-10    22.8kB ± 0%    22.5kB ± 0%  -1.44%  (p=0.000 n=17+19)
KV/Update/SQL/rows=1-10       52.4kB ± 0%    51.8kB ± 0%  -1.16%  (p=0.000 n=20+20)
KV/Insert/Native/rows=1-10    16.1kB ± 0%    15.9kB ± 0%  -1.15%  (p=0.000 n=20+20)
KV/Insert/SQL/rows=1-10       45.2kB ± 0%    44.8kB ± 0%  -0.85%  (p=0.000 n=20+20)
KV/Delete/SQL/rows=1-10       52.2kB ± 0%    51.8kB ± 0%  -0.72%  (p=0.000 n=19+19)

name                        old allocs/op  new allocs/op  delta
KV/Scan/Native/rows=1-10        57.0 ± 0%      54.0 ± 0%  -5.26%  (p=0.000 n=20+18)
KV/Update/Native/rows=1-10       189 ± 0%       182 ± 0%  -3.66%  (p=0.000 n=20+19)
KV/Scan/SQL/rows=1-10            289 ± 0%       279 ± 0%  -3.46%  (p=0.000 n=17+19)
KV/Delete/Native/rows=1-10       131 ± 0%       127 ± 0%  -3.05%  (p=0.000 n=20+20)
KV/Insert/Native/rows=1-10       132 ± 0%       128 ± 0%  -3.03%  (p=0.000 n=20+20)
KV/Insert/SQL/rows=1-10          367 ± 0%       359 ± 0%  -2.32%  (p=0.000 n=16+20)
KV/Update/SQL/rows=1-10          533 ± 0%       520 ± 0%  -2.30%  (p=0.000 n=20+20)
KV/Delete/SQL/rows=1-10          394 ± 0%       386 ± 0%  -2.03%  (p=0.000 n=20+18)
```

Release justification: avoids performance regression.

cc. `@erikgrinaker` 

86257: externalconn: register azure as a supported External Connection r=benbardin a=adityamaru

`azure` URIs can now be represented using External Connections.

Release note (sql change): Users can now
`CREATE EXTERNAL CONNECTION` to represent an `azure` URI.

Release justification: low risk change to new functionality that registers azure as a supported External Connection provider

86273: roachtest: update django version r=ecwall a=ZhouXing19

fixes #86010

Release justification: bug fix
Release note: none

Co-authored-by: Nathan VanBenschoten <[email protected]>
Co-authored-by: Aditya Maru <[email protected]>
Co-authored-by: Jane Xing <[email protected]>
@craig craig bot closed this as completed in e543dc9 Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot.
Projects
None yet
Milestone
22.2
Development

Successfully merging a pull request may close this issue.

roachtest: update django version ZhouXing19/cockroach
2 participants
@cockroach-teamcity @ZhouXing19