Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

settings: redefine TenantReadOnly to take its value from the system tenant #85729

Closed
knz opened this issue Aug 8, 2022 · 1 comment · Fixed by #110758
Closed

settings: redefine TenantReadOnly to take its value from the system tenant #85729

knz opened this issue Aug 8, 2022 · 1 comment · Fixed by #110758
Assignees
@knz
Labels
A-configurability Pertains to cluster settings, CLI flags, env vars etc C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-shared-systems Shared Systems Team

Comments

@knz
Copy link
Contributor

knz commented Aug 8, 2022 •
edited by cockroach-jira-scripts
Loading

As discussed with @stevendanna @dt and @ajwerner :

  • we want a setting class which uses a single shared value between system and secondary tenants.
  • the current behavior of TenantReadOnly (one value per tenant) can be readily emulated by a TenantReadWrite setting + an OVERRIDE in the system tenant.

So to achieve point 1, we can redefine TenantReadOnly to make settings take their value from the system tenant.

Informs #77472

Epic: CRDB-6671

Jira issue: CRDB-18406
@knz knz added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-configurability Pertains to cluster settings, CLI flags, env vars etc labels Aug 8, 2022
@exalate-issue-sync exalate-issue-sync bot added the T-shared-systems Shared Systems Team label Aug 8, 2022
@knz knz mentioned this issue Aug 11, 2022
Merged
@knz
Copy link
Contributor Author

knz commented Aug 11, 2022

RFC: #85970

@knz knz self-assigned this Sep 27, 2023
@knz knz mentioned this issue Sep 27, 2023
Merged
11 tasks
craig bot pushed a commit that referenced this issue Sep 29, 2023
@knz
Merge #85970
1edd24d 
85970: rfcs: update the RFC on multi-tenant cluster settings r=dt a=knz

**Note: this is a RFC update, not a new RFC. We are evaluating the 'diff' between the previous and the new version.**

Informs #85729

Text of RFC: https://github.com/knz/cockroach/blob/20220811-tenant-settings/docs/RFCS/20211106_multitenant_cluster_settings.md

Release note: None

Co-authored-by: Raphael 'kena' Poss <[email protected]>
@craig craig bot closed this as completed in 1787e21 Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@knz knz

Labels
A-configurability Pertains to cluster settings, CLI flags, env vars etc C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-shared-systems Shared Systems Team
Projects
No open projects
(OBSOLETE) Multi-tenant
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

server,settings: properly cascade defaults for TenantReadOnly knz/cockroach
1 participant
@knz