Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kvserver: lease acquisition timeouts mask NotLeaseHolderError #85115

Closed
erikgrinaker opened this issue Jul 27, 2022 · 1 comment · Fixed by #84865
Closed

kvserver: lease acquisition timeouts mask NotLeaseHolderError #85115

erikgrinaker opened this issue Jul 27, 2022 · 1 comment · Fixed by #84865
Assignees
@erikgrinaker
Labels
A-kv-replication Relating to Raft, consensus, and coordination. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@erikgrinaker
Copy link
Contributor

erikgrinaker commented Jul 27, 2022 •
edited by cockroach-jira-scripts
Loading

As seen in #84258, lease acquisition timeouts are returned as a TimeoutError wrapping the NotLeaseHolderError, which prevents the DistSender from handling these, instead returning them to the client.

Jira issue: CRDB-18049
@erikgrinaker erikgrinaker added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-kv-replication labels Jul 27, 2022
@erikgrinaker erikgrinaker self-assigned this Jul 27, 2022
@blathers-crl
Copy link

blathers-crl bot commented Jul 27, 2022

cc @cockroachdb/replication

@blathers-crl blathers-crl bot added the A-kv-replication Relating to Raft, consensus, and coordination. label Jul 27, 2022
@erikgrinaker erikgrinaker mentioned this issue Jul 27, 2022
Merged
@craig craig bot closed this as completed in 314baa5 Aug 1, 2022
This was referenced Aug 1, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erikgrinaker erikgrinaker

Labels
A-kv-replication Relating to Raft, consensus, and coordination. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

kvserver: always return NLHE on lease acquisition timeouts erikgrinaker/cockroach
1 participant
@erikgrinaker