-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
roachtest: kv50/enc=false/nodes=1/conc=8192 failed #84258
Comments
roachtest.kv50/enc=false/nodes=1/conc=8192 failed with artifacts on release-21.2 @ 28873f5636faa3e7a1f00c03f3a6d28f9cb19cda:
|
This most recent test failed with:
This is fallout from #81816. That PR already made it into v21.2.13, so there's no point in treating this as a release blocker so I'll remove the label. However, I think this is a surprising error to see all the way up in the client. @erikgrinaker did we consider returning a NotLeaseHolderError back to the client in these cases so that the DistSender would retry on another node, instead of returning the context deadline exceeded error which will propagate back to a client? |
Oof, yeah -- I seem to recall there was some context error handling involved there, but don't remember the specifics. Seems reasonable to have the DistSender retry these on a different replica. I'll have a closer look tomorrow. |
roachtest.kv50/enc=false/nodes=1/conc=8192 failed with artifacts on release-21.2 @ 97c5b1cbd23c109798597e9873544b91da651802:
Reproduce
See: roachtest README
This test on roachdash | Improve this report!
Jira issue: CRDB-17554
The text was updated successfully, but these errors were encountered: