Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

privilege: introduce CREATEEXTERNALCONNECTION system privilege #85006

Closed
adityamaru opened this issue Jul 25, 2022 · 1 comment · Fixed by #85007
Closed

privilege: introduce CREATEEXTERNALCONNECTION system privilege #85006

adityamaru opened this issue Jul 25, 2022 · 1 comment · Fixed by #85007
Assignees
Labels
A-disaster-recovery C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-disaster-recovery

Comments

@adityamaru
Copy link
Contributor

adityamaru commented Jul 25, 2022

CREATE EXTERNAL CONNECTION will be a privileged operation and a user must have the appropriate system privilege for this. We introduce a CREATEEXTERNALCONNECTION privilege for this, where root and admin have these system privileges by default.

Epic CRDB-15001

Jira issue: CRDB-18036

Epic CRDB-15001

@adityamaru adityamaru added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-disaster-recovery labels Jul 25, 2022
@adityamaru adityamaru self-assigned this Jul 25, 2022
@blathers-crl
Copy link

blathers-crl bot commented Jul 25, 2022

cc @cockroachdb/bulk-io

adityamaru added a commit to adityamaru/cockroach that referenced this issue Jul 25, 2022
This change introduces a `CREATEEXTERNALCONNECTION` system privilege.
This privilege is required by a user to be able to create an external
connection. Root and admin have these system privileges by default, and
are capable of granting this privilege to other users/roles with or without
the grant option.

Fixes: cockroachdb#85006

Release note (sql change): introduce a `CREATEEXTERNALCONNECTION`
system privilege that is required to create an External Connection object
to represent an underlying resource.
craig bot pushed a commit that referenced this issue Jul 26, 2022
85007: privilege,externalconn: add EXTERNALCONNECTION system privilege r=benbardin a=adityamaru

This change introduces a `EXTERNALCONNECTION` system privilege.
This privilege is required by a user to be able to create an external
connection. Root and admin have these system privileges by default, and
are capable of granting this privilege to other users/roles with or without
the grant option.

Fixes: #85006

Release note (sql change): introduce a `EXTERNALCONNECTION`
system privilege that is required to create an External Connection object
to represent an underlying resource.

85037: ui: remove unused end-to-end UI tests r=nathanstilwell a=sjbarag

The end-to-end UI tests written in Cypress weren't updated since October
2021, and haven't been run in at least as long. They in fact no longer
seemed to execute, and there were six major-version releases of
Cypress since the one used in this project. There had been enough skew
in both the CockroachDB product and in the Cypress platform that
upgrading to a newer version in-place is more work than simply tearing
out the old tests and starting from scratch. Remove the existing
db-console Cypress tests in preparation for a from-scratch
reimplementation.

Release note: None

85040: roachtest: preserve vmodule settings for upgraded servers r=lidorcarmel a=lidorcarmel

Without this patch upgraded servers in a roachtest are using the default
settings. For example, the rebalance roachtest is upgrading servers in
order to run with mixed version binaries, and those servers are running
without the right settings for logging (don't use vmodule).

This small fix makes sure that we pass the right options to the upgraded
binary, so that for the rebalance roachtest we will maintain the 'vmodule'
settings.

Release note: None

85071: kvserver: forward-port deflake of TestAddReplicaViaLearner r=erikgrinaker a=itsbilal

In #84223, we noticed that TestAddReplicaViaLearner was
flaky on CI in release-22.1, for something that the test
was not testing. This change forward-ports the fix that
worked there.

Release note: None.

Co-authored-by: Aditya Maru <[email protected]>
Co-authored-by: Sean Barag <[email protected]>
Co-authored-by: Lidor Carmel <[email protected]>
Co-authored-by: Bilal Akhtar <[email protected]>
@craig craig bot closed this as completed in 10fe096 Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-disaster-recovery C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-disaster-recovery
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant