Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.1: roachtest/sqlsmith: Float.SetFloat64(NaN) with st_snaptogrid #82793

Closed
cockroach-teamcity opened this issue Jun 12, 2022 · 7 comments
Closed

release-22.1: roachtest/sqlsmith: Float.SetFloat64(NaN) with st_snaptogrid #82793

cockroach-teamcity opened this issue Jun 12, 2022 · 7 comments
Assignees
@rytaft
Labels
branch-release-22.1 Used to mark GA and release blockers, technical advisories, and bugs for 22.1 C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. T-sql-queries SQL Queries Team

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Jun 12, 2022 •
edited by rytaft
Loading

roachtest.sqlsmith/setup=rand-tables/setting=no-ddl failed with artifacts on release-22.1 @ 3181b7faa2f3b41d6a15ab4b74d2c60bcfe5132d:

The test failed on branch=release-22.1, cloud=gce:
test artifacts and logs in: /artifacts/sqlsmith/setup=rand-tables/setting=no-ddl/run_1
	sqlsmith.go:284,sqlsmith.go:304,test_runner.go:883: ping node 1: dial tcp 35.231.14.75:26257: connect: connection refused
		previous sql:
		UPDATE
			defaultdb.public.table5 AS tab_160204
		SET
			col5_1 = 'f68:8278:8d4e:6bd3:13bb:7732:59fd:3d93/10':::INET,
			col5_0 = st_snaptogrid(tab_160204.col5_3::GEOMETRY, tab_160204.col5_10::FLOAT8)::GEOMETRY
		LIMIT
			37:::INT8;
Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

/cc @cockroachdb/sql-queries

This test on roachdash | Improve this report!

Epic: CRDB-14914
Jira issue: CRDB-16666
@cockroach-teamcity cockroach-teamcity added branch-release-22.1 Used to mark GA and release blockers, technical advisories, and bugs for 22.1 C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Jun 12, 2022
@blathers-crl blathers-crl bot added the T-sql-queries SQL Queries Team label Jun 12, 2022
@yuzefovich
Copy link
Member

Doesn't look like a release blocker:

E220612 05:40:15.567037 2394 9@sql/conn_executor.go:1029 ⋮ [n1,client=35.237.102.59:40502,user=root] 2389  a SQL panic has occurred while executing the following statement:
E220612 05:40:15.567037 2394 9@sql/conn_executor.go:1029 ⋮ [n1,client=35.237.102.59:40502,user=root] 2389 +‹UPDATE defaultdb.public.table5 AS tab_160204 SET col5_1 = 'f68:8278:8d4e:6bd3:13bb:7732:59fd:3d93/10':::INET, col5_0 = st_snaptogrid(tab_160204.col5_3::GEOMETRY, tab_160204.col5_10::FLOAT8)::GEOMETRY LIMIT 37:::INT8›
E220612 05:40:15.567540 2394 1@util/log/logcrash/crash_reporting.go:174 ⋮ [n1,client=35.237.102.59:40502,user=root] 2390  a panic has occurred!
E220612 05:40:15.567540 2394 1@util/log/logcrash/crash_reporting.go:174 ⋮ [n1,client=35.237.102.59:40502,user=root] 2390 +‹Float.SetFloat64(NaN)›
E220612 05:40:15.567540 2394 1@util/log/logcrash/crash_reporting.go:174 ⋮ [n1,client=35.237.102.59:40502,user=root] 2390 +(1) attached stack trace
E220612 05:40:15.567540 2394 1@util/log/logcrash/crash_reporting.go:174 ⋮ [n1,client=35.237.102.59:40502,user=root] 2390 +  -- stack trace:
E220612 05:40:15.567540 2394 1@util/log/logcrash/crash_reporting.go:174 ⋮ [n1,client=35.237.102.59:40502,user=root] 2390 +  | github.com/cockroachdb/cockroach/pkg/sql.(*Server).ServeConn.func1
E220612 05:40:15.567540 2394 1@util/log/logcrash/crash_reporting.go:174 ⋮ [n1,client=35.237.102.59:40502,user=root] 2390 +  | 	github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:746
E220612 05:40:15.567540 2394 1@util/log/logcrash/crash_reporting.go:174 ⋮ [n1,client=35.237.102.59:40502,user=root] 2390 +  | [...repeated from below...]
E220612 05:40:15.567540 2394 1@util/log/logcrash/crash_reporting.go:174 ⋮ [n1,client=35.237.102.59:40502,user=root] 2390 +Wraps: (2) while executing: UPDATE _ AS _ SET _ = '_':::INET, _ = st_snaptogrid(_._::GEOMETRY, _._::FLOAT8)::GEOMETRY LIMIT _:::INT8
E220612 05:40:15.567540 2394 1@util/log/logcrash/crash_reporting.go:174 ⋮ [n1,client=35.237.102.59:40502,user=root] 2390 +Wraps: (3) attached stack trace
E220612 05:40:15.567540 2394 1@util/log/logcrash/crash_reporting.go:174 ⋮ [n1,client=35.237.102.59:40502,user=root] 2390 +  -- stack trace:
E220612 05:40:15.567540 2394 1@util/log/logcrash/crash_reporting.go:174 ⋮ [n1,client=35.237.102.59:40502,user=root] 2390 +  | github.com/cockroachdb/cockroach/pkg/sql.(*Server).ServeConn.func1
E220612 05:40:15.567540 2394 1@util/log/logcrash/crash_reporting.go:174 ⋮ [n1,client=35.237.102.59:40502,user=root] 2390 +  | 	github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:746
E220612 05:40:15.567540 2394 1@util/log/logcrash/crash_reporting.go:174 ⋮ [n1,client=35.237.102.59:40502,user=root] 2390 +  | runtime.gopanic
E220612 05:40:15.567540 2394 1@util/log/logcrash/crash_reporting.go:174 ⋮ [n1,client=35.237.102.59:40502,user=root] 2390 +  | 	GOROOT/src/runtime/panic.go:1038
E220612 05:40:15.567540 2394 1@util/log/logcrash/crash_reporting.go:174 ⋮ [n1,client=35.237.102.59:40502,user=root] 2390 +  | github.com/cockroachdb/cockroach/pkg/sql/colexecerror.CatchVectorizedRuntimeError.func1
E220612 05:40:15.567540 2394 1@util/log/logcrash/crash_reporting.go:174 ⋮ [n1,client=35.237.102.59:40502,user=root] 2390 +  | 	github.com/cockroachdb/cockroach/pkg/sql/colexecerror/error.go:58
E220612 05:40:15.567540 2394 1@util/log/logcrash/crash_reporting.go:174 ⋮ [n1,client=35.237.102.59:40502,user=root] 2390 +  | runtime.gopanic
E220612 05:40:15.567540 2394 1@util/log/logcrash/crash_reporting.go:174 ⋮ [n1,client=35.237.102.59:40502,user=root] 2390 +  | 	GOROOT/src/runtime/panic.go:1038
E220612 05:40:15.567540 2394 1@util/log/logcrash/crash_reporting.go:174 ⋮ [n1,client=35.237.102.59:40502,user=root] 2390 +  | math/big.(*Float).SetFloat64
E220612 05:40:15.567540 2394 1@util/log/logcrash/crash_reporting.go:174 ⋮ [n1,client=35.237.102.59:40502,user=root] 2390 +  | 	GOROOT/src/math/big/float.go:549
E220612 05:40:15.567540 2394 1@util/log/logcrash/crash_reporting.go:174 ⋮ [n1,client=35.237.102.59:40502,user=root] 2390 +  | github.com/golang/geo/r3.precFloat
E220612 05:40:15.567540 2394 1@util/log/logcrash/crash_reporting.go:174 ⋮ [n1,client=35.237.102.59:40502,user=root] 2390 +  | 	github.com/golang/geo/r3/external/com_github_golang_geo/r3/precisevector.go:49
E220612 05:40:15.567540 2394 1@util/log/logcrash/crash_reporting.go:174 ⋮ [n1,client=35.237.102.59:40502,user=root] 2390 +  | github.com/golang/geo/r3.NewPreciseVector
E220612 05:40:15.567540 2394 1@util/log/logcrash/crash_reporting.go:174 ⋮ [n1,client=35.237.102.59:40502,user=root] 2390 +  | 	github.com/golang/geo/r3/external/com_github_golang_geo/r3/precisevector.go:82
E220612 05:40:15.567540 2394 1@util/log/logcrash/crash_reporting.go:174 ⋮ [n1,client=35.237.102.59:40502,user=root] 2390 +  | github.com/golang/geo/r3.PreciseVectorFromVector
E220612 05:40:15.567540 2394 1@util/log/logcrash/crash_reporting.go:174 ⋮ [n1,client=35.237.102.59:40502,user=root] 2390 +  | 	github.com/golang/geo/r3/external/com_github_golang_geo/r3/precisevector.go:75
E220612 05:40:15.567540 2394 1@util/log/logcrash/crash_reporting.go:174 ⋮ [n1,client=35.237.102.59:40502,user=root] 2390 +  | github.com/golang/geo/s2.exactSign
E220612 05:40:15.567540 2394 1@util/log/logcrash/crash_reporting.go:174 ⋮ [n1,client=35.237.102.59:40502,user=root] 2390 +  | 	github.com/golang/geo/s2/external/com_github_golang_geo/s2/predicates.go:262
E220612 05:40:15.567540 2394 1@util/log/logcrash/crash_reporting.go:174 ⋮ [n1,client=35.237.102.59:40502,user=root] 2390 +  | github.com/golang/geo/s2.expensiveSign
E220612 05:40:15.567540 2394 1@util/log/logcrash/crash_reporting.go:174 ⋮ [n1,client=35.237.102.59:40502,user=root] 2390 +  | 	github.com/golang/geo/s2/external/com_github_golang_geo/s2/predicates.go:235
E220612 05:40:15.567540 2394 1@util/log/logcrash/crash_reporting.go:174 ⋮ [n1,client=35.237.102.59:40502,user=root] 2390 +  | github.com/golang/geo/s2.RobustSign
E220612 05:40:15.567540 2394 1@util/log/logcrash/crash_reporting.go:174 ⋮ [n1,client=35.237.102.59:40502,user=root] 2390 +  | 	github.com/golang/geo/s2/external/com_github_golang_geo/s2/predicates.go:139
E220612 05:40:15.567540 2394 1@util/log/logcrash/crash_reporting.go:174 ⋮ [n1,client=35.237.102.59:40502,user=root] 2390 +  | github.com/golang/geo/s2.OrderedCCW
E220612 05:40:15.567540 2394 1@util/log/logcrash/crash_reporting.go:174 ⋮ [n1,client=35.237.102.59:40502,user=root] 2390 +  | 	github.com/golang/geo/s2/external/com_github_golang_geo/s2/point.go:112
E220612 05:40:15.567540 2394 1@util/log/logcrash/crash_reporting.go:174 ⋮ [n1,client=35.237.102.59:40502,user=root] 2390 +  | github.com/golang/geo/s2.(*Loop).initOriginAndBound
E220612 05:40:15.567540 2394 1@util/log/logcrash/crash_reporting.go:174 ⋮ [n1,client=35.237.102.59:40502,user=root] 2390 +  | 	github.com/golang/geo/s2/external/com_github_golang_geo/s2/loop.go:150
E220612 05:40:15.567540 2394 1@util/log/logcrash/crash_reporting.go:174 ⋮ [n1,client=35.237.102.59:40502,user=root] 2390 +  | github.com/golang/geo/s2.LoopFromPoints
E220612 05:40:15.567540 2394 1@util/log/logcrash/crash_reporting.go:174 ⋮ [n1,client=35.237.102.59:40502,user=root] 2390 +  | 	github.com/golang/geo/s2/external/com_github_golang_geo/s2/loop.go:77
E220612 05:40:15.567540 2394 1@util/log/logcrash/crash_reporting.go:174 ⋮ [n1,client=35.237.102.59:40502,user=root] 2390 +  | github.com/cockroachdb/cockroach/pkg/geo/geoindex.(*s2GeometryIndex).s2RegionsFromPlanarGeomT
E220612 05:40:15.567540 2394 1@util/log/logcrash/crash_reporting.go:174 ⋮ [n1,client=35.237.102.59:40502,user=root] 2390 +  | 	github.com/cockroachdb/cockroach/pkg/geo/geoindex/pkg/geo/geoindex/s2_geometry_index.go:466
E220612 05:40:15.567540 2394 1@util/log/logcrash/crash_reporting.go:174 ⋮ [n1,client=35.237.102.59:40502,user=root] 2390 +  | github.com/cockroachdb/cockroach/pkg/geo/geoindex.(*s2GeometryIndex).InvertedIndexKeys
E220612 05:40:15.567540 2394 1@util/log/logcrash/crash_reporting.go:174 ⋮ [n1,client=35.237.102.59:40502,user=root] 2390 +  | 	github.com/cockroachdb/cockroach/pkg/geo/geoindex/pkg/geo/geoindex/s2_geometry_index.go:190
E220612 05:40:15.567540 2394 1@util/log/logcrash/crash_reporting.go:174 ⋮ [n1,client=35.237.102.59:40502,user=root] 2390 +  | github.com/cockroachdb/cockroach/pkg/sql/rowenc.EncodeGeoInvertedIndexTableKeys
E220612 05:40:15.567540 2394 1@util/log/logcrash/crash_reporting.go:174 ⋮ [n1,client=35.237.102.59:40502,user=root] 2390 +  | 	github.com/cockroachdb/cockroach/pkg/sql/rowenc/index_encoding.go:792
E220612 05:40:15.567540 2394 1@util/log/logcrash/crash_reporting.go:174 ⋮ [n1,client=35.237.102.59:40502,user=root] 2390 +  | github.com/cockroachdb/cockroach/pkg/sql/rowenc.EncodeInvertedIndexKeys
E220612 05:40:15.567540 2394 1@util/log/logcrash/crash_reporting.go:174 ⋮ [n1,client=35.237.102.59:40502,user=root] 2390 +  | 	github.com/cockroachdb/cockroach/pkg/sql/rowenc/index_encoding.go:520
E220612 05:40:15.567540 2394 1@util/log/logcrash/crash_reporting.go:174 ⋮ [n1,client=35.237.102.59:40502,user=root] 2390 +  | github.com/cockroachdb/cockroach/pkg/sql/rowenc.EncodeSecondaryIndex
E220612 05:40:15.567540 2394 1@util/log/logcrash/crash_reporting.go:174 ⋮ [n1,client=35.237.102.59:40502,user=root] 2390 +  | 	github.com/cockroachdb/cockroach/pkg/sql/rowenc/index_encoding.go:959
...

@yuzefovich yuzefovich removed the release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. label Jun 12, 2022
This was referenced Jun 16, 2022
Closed
Closed
@blathers-crl blathers-crl bot added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label Jun 23, 2022
@cockroach-teamcity cockroach-teamcity mentioned this issue Jun 23, 2022
Closed
@cockroach-teamcity

This comment was marked as off-topic.

Sign in to view
@yuzefovich yuzefovich changed the title roachtest: sqlsmith/setup=rand-tables/setting=no-ddl failed release-22.1: roachtest/sqlsmith: Float.SetFloat64(NaN) with st_snaptogrid Jun 28, 2022
@rafiss
Copy link
Collaborator

rafiss commented Jul 7, 2022

@mgartner i'm putting this back onto the sql-queries board since the last two failures seem more in the Queries area. If you feel otherwise, let's discuss it on Slack.

@rafiss rafiss removed the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label Jul 7, 2022
@yuzefovich
Copy link
Member

"cannot resolve types in DistSQL by name" failure has been extracted into #83496.

my understanding was that sql-queries owns spatial indexes

Maybe, but I think @otan almost exclusive fixed issues like this in the past :)

@rafiss
Copy link
Collaborator

rafiss commented Jul 7, 2022

I see. With @otan moving to the Migrations team, I think you'd need to either get this tracked on the Migrations team project, or get the knowledge transferred from him so sql-queries can fix it.

@otan
Copy link
Contributor

otan commented Jul 7, 2022

i think this is #81609 which was agreed was a queries issue since it's index related :D

@rytaft
Copy link
Collaborator

rytaft commented Jul 23, 2022

Closing as a dup of #81609

@rytaft rytaft closed this as completed Jul 23, 2022
@mgartner mgartner moved this to Done in SQL Queries Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rytaft rytaft

Labels
branch-release-22.1 Used to mark GA and release blockers, technical advisories, and bugs for 22.1 C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. T-sql-queries SQL Queries Team
Projects
SQL Queries
Archived in project
Milestone
No milestone
Development

No branches or pull requests
5 participants
@rafiss @rytaft @otan @yuzefovich @cockroach-teamcity