roachtest: sqlsmith/setup=empty/setting=no-mutations failed #81277
Labels
branch-master
Failures and bugs on the master branch.
C-test-failure
Broken test (automatically or manually discovered).
O-roachtest
O-robot
Originated from a bot.
T-sql-foundations
SQL Foundations Team (formerly SQL Schema + SQL Sessions)
T-sql-queries
SQL Queries Team
Comments
cockroach-teamcity
added
branch-master
|
The horrible beast and the stacktrace it produced: |
|
Reduced: SELECT st_minimumboundingcircle(
st_makepoint(
(-0.23349138300862382)::FLOAT8,
(-1.0):::FLOAT8::FLOAT8 ^ (0.7478831141483115:::FLOAT8 - (0))::FLOAT8
)
); |
blathers-crl
bot
added
the
T-sql-foundations
rytaft
removed
the
release-blocker
|
Not a release blocker, but another |
craig bot
pushed a commit
that referenced
this issue
May 18, 2022
80894: build,gcp: enable nightly config to run GCP unit tests r=adityamaru a=adityamaru Previously, the `pkg/cloud/gcp` tests package was skipped on CI because most of the tests require credentials, and we risked exfiltration of these secrets when running on public teamcity agents. With the ability to run tests on agents that are not part of the public pool we now have a `Cloud Unit Test` config that runs these tests nightly. This change adds the script invoked by the config and cleans up the unit tests to be more uniform in their authentication and environment variable checks. Informs: #80877 Release note: None 81200: ui: Improve time picker keyboard input r=jocrl a=jocrl Fixes #80655, mostly. Previously, users had to type `1:03 PM (UTC)` in order to enter text into the time picker. This commit modifies the time picker so that users would instead type either - `1:03`, or - `01:03` to enter text into the time picker. Copying and re-pasting the text from a time picker still works. Alternate approaches not pursued (these are not needed with the removal of AM/PM). 1) Make our own time picker component, and style it to look like antd's. There's a general issue of antd's components not being keyboard friendly: ant-design/ant-design#5685 2) Upgrade to `antd` version 4, and use an undocumented prop type. `antd`'s time picker uses the time picker from the `rc-picker` library under the hood. In `rc-picker`, the `format` prop is of type `String | String[]`, where if it's an array the first value will be used for display and the remaining ones will be used for parsing, as documented [here](https://react-component.github.io/picker). In theory, `antd` passes `format` (and also any remaining, additional props in addition to the specified ones) to the `rc-picker` component. So even though the `antd` `TimePicker` component `format` prop is not documented to take in a string array, one might think that passing in a string array anyway would work. In practice, passing in a string array works in `antd` version `4.20.4`, as tested in the [antd sandbox](https://ant.design/docs/react/getting-started) (render `<TimePicker format={ ["h:mm A", "h:mma"]}/>`). However, this does not work in our codebase (which installs `antd` `v3.25.2`), or in the `antd` version `3.x` [sandbox](https://3x.ant.design/docs/react/getting-started). The errors that appear in these two situations are different, and in a way demonstrate the potential for breakage from using an undocumented feature in future upgrades from a version that we've to work. If we do this, we should add a test. 3) Dead end: The `antd` `TimePicker` component takes an `onChange` prop with a second `timeString` paramater. However, `onChange` only fires if the input is of the correct, parsable format. The specific code that ignores text input that is not of a parsable format is in `rc-picker`, [here](https://github.com/react-component/picker/blob/5306c8938aded49c5d6f6b6d4761ddab25e3cce9/src/Picker.tsx#L237). This prevents us from being the one to do the fuzzy matching and passing the value back to the component. Release note (ui): The time picker component has been improved such that users can use keyboard input to select a time without having to type `" (UTC)"` 81330: authors: add annrpom to authors r=annrpom a=annrpom Release note: None 81406: geomfn: check NaN coordinates for ST_MinimumBoundingCircle r=rafiss a=otan Resolves #81277 Release note (bug fix): Fix a bug where ST_MinimumBoundingCircle with NaN coordinates could panic. Co-authored-by: Aditya Maru <[email protected]> Co-authored-by: Josephine Lee <[email protected]> Co-authored-by: Annie Pompa <[email protected]> Co-authored-by: Oliver Tan <[email protected]>
This was referenced May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
roachtest.sqlsmith/setup=empty/setting=no-mutations failed with artifacts on master @ bc5f5b7159ed2b7dbffa94bb2a590fdddb642b9b:
Help
See: roachtest README
See: How To Investigate (internal)
This test on roachdash | Improve this report!
Jira issue: CRDB-15258
The text was updated successfully, but these errors were encountered: