Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: activerecord failed #81211

Closed
cockroach-teamcity opened this issue May 12, 2022 · 8 comments · Fixed by #81473
Closed

roachtest: activerecord failed #81211

cockroach-teamcity opened this issue May 12, 2022 · 8 comments · Fixed by #81473
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented May 12, 2022 •
edited by cockroach-jira-scripts
Loading

roachtest.activerecord failed with artifacts on master @ bc1ee7c7c276984fce8ff5ba4fcfcdff335dde50:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /artifacts/activerecord/run_1
	orm_helpers.go:193,orm_helpers.go:119,activerecord.go:251,test_runner.go:876: 
		Tests run on Cockroach v22.1.0-alpha.4-1584-gbc1ee7c7c2
		Tests run against activerecord 6.1.5
		6664 Total Tests Run
		6662 tests passed
		2 tests failed
		18 tests skipped
		5 tests ignored
		0 tests passed unexpectedly
		2 tests failed unexpectedly
		0 tests expected failed but skipped
		0 tests expected failed but not run
		---
		--- FAIL: ActiveRecord::Migration::IndexTest#test_rename_index_with_symbol (unexpected)
		--- PASS: SerializedAttributeTest#test_unexpected_serialized_type (expected)
		--- FAIL: InsertAllTest#test_insert_all_and_upsert_all_with_expression_index (unexpected)
		For a full summary look at the activerecord artifacts 
		
		An updated blocklist (activeRecordBlockList22_1) is available in the artifacts' activerecord log
Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

/cc @cockroachdb/sql-experience

This test on roachdash | Improve this report!

Jira issue: CRDB-15296
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels May 12, 2022
@blathers-crl blathers-crl bot added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label May 12, 2022
@cockroach-teamcity
Copy link
Member Author

roachtest.activerecord failed with artifacts on master @ 9a179ea1aa8d6723fb12a988f2212ac8493e5dfc:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /artifacts/activerecord/run_1
	orm_helpers.go:193,orm_helpers.go:119,activerecord.go:251,test_runner.go:876: 
		Tests run on Cockroach v22.1.0-alpha.4-1588-g9a179ea1aa
		Tests run against activerecord 6.1.5
		6664 Total Tests Run
		6662 tests passed
		2 tests failed
		18 tests skipped
		5 tests ignored
		0 tests passed unexpectedly
		2 tests failed unexpectedly
		0 tests expected failed but skipped
		0 tests expected failed but not run
		---
		--- FAIL: InsertAllTest#test_insert_all_and_upsert_all_with_expression_index (unexpected)
		--- PASS: SerializedAttributeTest#test_unexpected_serialized_type (expected)
		--- FAIL: ActiveRecord::Migration::IndexTest#test_rename_index_with_symbol (unexpected)
		For a full summary look at the activerecord artifacts 
		
		An updated blocklist (activeRecordBlockList22_1) is available in the artifacts' activerecord log
Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

roachtest.activerecord failed with artifacts on master @ 16c484aa84d3718bfc82557f8e935ab78e6753b6:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /artifacts/activerecord/run_1
	orm_helpers.go:193,orm_helpers.go:119,activerecord.go:251,test_runner.go:876: 
		Tests run on Cockroach v22.1.0-alpha.4-1601-g16c484aa84
		Tests run against activerecord 6.1.6
		6666 Total Tests Run
		6665 tests passed
		1 test failed
		19 tests skipped
		5 tests ignored
		0 tests passed unexpectedly
		1 test failed unexpectedly
		0 tests expected failed but skipped
		0 tests expected failed but not run
		---
		--- PASS: SerializedAttributeTest#test_unexpected_serialized_type (expected)
		--- FAIL: ActiveRecord::Migration::IndexTest#test_rename_index_with_symbol (unexpected)
		For a full summary look at the activerecord artifacts 
		
		An updated blocklist (activeRecordBlockList22_1) is available in the artifacts' activerecord log
Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity cockroach-teamcity mentioned this issue May 14, 2022
Closed
@cockroach-teamcity
Copy link
Member Author

roachtest.activerecord failed with artifacts on master @ bc5f5b7159ed2b7dbffa94bb2a590fdddb642b9b:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /artifacts/activerecord/run_1
	orm_helpers.go:193,orm_helpers.go:119,activerecord.go:251,test_runner.go:876: 
		Tests run on Cockroach v22.1.0-alpha.4-1607-gbc5f5b7159
		Tests run against activerecord 6.1.6
		6666 Total Tests Run
		6665 tests passed
		1 test failed
		19 tests skipped
		5 tests ignored
		0 tests passed unexpectedly
		1 test failed unexpectedly
		0 tests expected failed but skipped
		0 tests expected failed but not run
		---
		--- PASS: SerializedAttributeTest#test_unexpected_serialized_type (expected)
		--- FAIL: ActiveRecord::Migration::IndexTest#test_rename_index_with_symbol (unexpected)
		For a full summary look at the activerecord artifacts 
		
		An updated blocklist (activeRecordBlockList22_1) is available in the artifacts' activerecord log
Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@rafiss rafiss removed the release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. label May 16, 2022
@ecwall
Copy link
Contributor

ecwall commented May 16, 2022

test_insert_all_and_upsert_all_with_expression_index has been resolved
test_rename_index_with_symbol needs to be looked into

@cockroach-teamcity
Copy link
Member Author

roachtest.activerecord failed with artifacts on master @ 2c264bd12c15b8811553adc9d90f9230065f3ff3:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /artifacts/activerecord/run_1
	orm_helpers.go:193,orm_helpers.go:119,activerecord.go:251,test_runner.go:876: 
		Tests run on Cockroach v22.1.0-alpha.4-1649-g2c264bd12c
		Tests run against activerecord 6.1.6
		6666 Total Tests Run
		6665 tests passed
		1 test failed
		19 tests skipped
		5 tests ignored
		0 tests passed unexpectedly
		1 test failed unexpectedly
		0 tests expected failed but skipped
		0 tests expected failed but not run
		---
		--- PASS: SerializedAttributeTest#test_unexpected_serialized_type (expected)
		--- FAIL: ActiveRecord::Migration::IndexTest#test_rename_index_with_symbol (unexpected)
		For a full summary look at the activerecord artifacts 
		
		An updated blocklist (activeRecordBlockList22_1) is available in the artifacts' activerecord log
Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity cockroach-teamcity mentioned this issue May 17, 2022
Closed
@cockroach-teamcity
Copy link
Member Author

roachtest.activerecord failed with artifacts on master @ a35b848edb3f5562199b0f56bc27a6c576073d5d:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /artifacts/activerecord/run_1
	orm_helpers.go:193,orm_helpers.go:119,activerecord.go:251,test_runner.go:876: 
		Tests run on Cockroach v22.1.0-alpha.4-1716-ga35b848edb
		Tests run against activerecord 6.1.6
		6666 Total Tests Run
		6665 tests passed
		1 test failed
		19 tests skipped
		5 tests ignored
		0 tests passed unexpectedly
		1 test failed unexpectedly
		0 tests expected failed but skipped
		0 tests expected failed but not run
		---
		--- FAIL: ActiveRecord::Migration::IndexTest#test_rename_index_with_symbol (unexpected)
		--- PASS: SerializedAttributeTest#test_unexpected_serialized_type (expected)
		For a full summary look at the activerecord artifacts 
		
		An updated blocklist (activeRecordBlockList22_1) is available in the artifacts' activerecord log
Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@ecwall
Copy link
Contributor

ecwall commented May 18, 2022

The error can be reproduced by creating and renaming an index inside a transaction.

statement ok
CREATE TABLE t1(a int)

statement ok
BEGIN

statement ok
CREATE INDEX i1 ON t1(a)

statement error pgcode XX000 cannot add a version of descriptor with a different original version than it was previously added with
ALTER INDEX i1 RENAME TO i2

statement ok
COMMIT

@ecwall ecwall added the T-sql-schema-deprecated Use T-sql-foundations instead label May 18, 2022
@ecwall ecwall removed the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label May 18, 2022
@ecwall ecwall assigned ecwall and unassigned ecwall May 18, 2022
@chengxiong-ruan chengxiong-ruan mentioned this issue May 18, 2022
Merged
@cockroach-teamcity
Copy link
Member Author

roachtest.activerecord failed with artifacts on master @ ce66acdbba801de88f1dd645eaedeb3834f23dbd:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /artifacts/activerecord/run_1
	orm_helpers.go:193,orm_helpers.go:119,activerecord.go:251,test_runner.go:876: 
		Tests run on Cockroach v22.1.0-alpha.4-1757-gce66acdbba
		Tests run against activerecord 6.1.6
		6666 Total Tests Run
		6665 tests passed
		1 test failed
		19 tests skipped
		5 tests ignored
		0 tests passed unexpectedly
		1 test failed unexpectedly
		0 tests expected failed but skipped
		0 tests expected failed but not run
		---
		--- FAIL: ActiveRecord::Migration::IndexTest#test_rename_index_with_symbol (unexpected)
		--- PASS: SerializedAttributeTest#test_unexpected_serialized_type (expected)
		For a full summary look at the activerecord artifacts 
		
		An updated blocklist (activeRecordBlockList22_1) is available in the artifacts' activerecord log
Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

This test on roachdash | Improve this report!

craig bot pushed a commit that referenced this issue May 19, 2022
@chengxiong-ruan
Merge #81473
52868f8 
81473: sql: fix expandIndexName to return correct table mutable r=chengxiong-ruan a=chengxiong-ruan

Fixes #81211
A regression was introduced with #80769 that the table mutable
got created from a uncommitted descriptor. This pr tries to fix
that.

Release note: None.

Co-authored-by: Chengxiong Ruan <[email protected]>
@craig craig bot closed this as completed in 239de46 May 19, 2022
jbowens pushed a commit to jbowens/cockroach that referenced this issue May 19, 2022
@chengxiong-ruan @jbowens
sql: fix expandIndexName to return correct table mutable
3a3dc1f 
Fixes cockroachdb#81211
A regression was introduced with cockroachdb#80769 that the table mutable
got created from a uncommitted descriptor. This pr tries to fix
that.

Release note: None.
andrewbaptist pushed a commit to andrewbaptist/cockroach that referenced this issue May 25, 2022
@chengxiong-ruan @andrewbaptist
sql: fix expandIndexName to return correct table mutable
e1a9362 
Fixes cockroachdb#81211
A regression was introduced with cockroachdb#80769 that the table mutable
got created from a uncommitted descriptor. This pr tries to fix
that.

Release note: None.
@exalate-issue-sync exalate-issue-sync bot added T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) and removed T-sql-schema-deprecated Use T-sql-foundations instead labels May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: fix expandIndexName to return correct table mutable chengxiong-ruan/cockroach
4 participants
@jlinder @rafiss @ecwall @cockroach-teamcity