changefeeds, ui: changefeed status is not reported in db console when there's a checkpoint #80496
Assignees
Comments
dhartunian
added
C-bug
|
cc @cockroachdb/cdc |
|
Hey @dhartunian I think the problem here is that we aren't updating the DB console enough, we should be showing PAUSED and CANCELED in the status field of the changefeed. RUNNING doesnt really give us any information about the changefeed, so I don't think we should add an extra columns |
|
Moving this to the jobs board for discussion around the best way to communicate protection/ other important data for jobs |
|
@amruss I think I didn't correctly convey how the code works today. If the job contains a "highwater_timestamp" field the status column will never show a status like "running"/"paused" etc. no matter how often it updates. So the changefeed jobs end up looking confusing in the table. I think making it look more like the SQL output will help. Here's an example that always renders the status column for every job including changefeeds and adds a highwater timestamp column for changefeed jobs: I agree that "Running" status is low-info for a changefeed so if you think it makes sense we can also just show the highwater timestamp when its in running status and avoid the extra column. Also a small example of moving the highwater timestamp to the sidebar for job details |
dhartunian
added a commit
to dhartunian/cockroach
that referenced
this issue
May 12, 2022
Previously, when a job contained a `highwater_timestamp` column value
(present for changefeeds) the status column in DB console would
*always* show that value instead of the job status ("running", "paused",
etc.). This would cause confusion for operators because the SQL output
for job status always included both a `status` column and a separate
`highwater_timestamp` column.
This change moves the `highwater_timestamp` into a separate column and
always renders the `status` column with the "pill" component that shows
the current job status.
The highwater timestamp is also moved to the sidebar in the job details
page instead of replacing the status pill, for similar consistency.
Resolves cockroachdb#80496
Release note (ui change): The job status page in the DB Console will now
show the status column for changefeed jobs and display the
`highwater_timestamp` value in a separate column. Thise more closely
matches the SQL output of `SHOW changefeed JOBS`.
dhartunian
added a commit
to dhartunian/cockroach
that referenced
this issue
May 12, 2022
Previously, when a job contained a `highwater_timestamp` column value
(present for changefeeds) the status column in DB console would
*always* show that value instead of the job status ("running", "paused",
etc.). This would cause confusion for operators because the SQL output
for job status always included both a `status` column and a separate
`highwater_timestamp` column.
This change moves the `highwater_timestamp` into a separate column and
always renders the `status` column with the "pill" component that shows
the current job status.
The highwater timestamp is also moved to the sidebar in the job details
page instead of replacing the status pill, for similar consistency.
Finally, the highwater timestamp now displays the nanosecond decimal
value by default and the human-readable formatted value in the tooltip.
This faciliates easier copy/paste behavior from the UI as the decimal is
more useful.
Resolves cockroachdb#80496
Release note (ui change): The job status page in the DB Console will now
show the status column for changefeed jobs and display the
`highwater_timestamp` value in a separate column. Thise more closely
matches the SQL output of `SHOW changefeed JOBS`. The highwater
timestamp now displays as the nanosecond system time value by default
with the human-readable value in the tooltip since the decimal value is
copy/pasted more often.
craig bot
pushed a commit
that referenced
this issue
May 24, 2022
81108: *: improve inline code comments r=maryliag a=Azhng Release note: None 81123: sql : sequence value out of bounds r=rafiss a=mosquito2333 Previously, an additional out-of-range sequence value may have been generated. The original criterion was whether the previous endSequence value exceeded the limit. However, when the current endSequence is 1, the increment is 2 and the MaxValue is 2, the previous endSequence value is 1 and the program does not report an error. However, when the current endSequenceValue 3 exceeds the limit, an error should be reported In incrementSequenceUsingCache, the criterion for determining whether a cache's data is eligible is modified to whether the first data that may be stored in the cache exceeds the limit. Fixes #74127. Release note (bug fix): Fixed a bug where sequences could return values that are out-of-bounds in some cases. 81213: ui, changefeeds: better status col in db console r=abarganier,HonoreDB a=dhartunian Previously, when a job contained a `highwater_timestamp` column value (present for changefeeds) the status column in DB console would *always* show that value instead of the job status ("running", "paused", etc.). This would cause confusion for operators because the SQL output for job status always included both a `status` column and a separate `highwater_timestamp` column. This change moves the `highwater_timestamp` into a separate column and always renders the `status` column with the "pill" component that shows the current job status. The highwater timestamp is also moved to the sidebar in the job details page instead of replacing the status pill, for similar consistency. Finally, the highwater timestamp now displays the nanosecond decimal value by default and the human-readable formatted value in the tooltip. This faciliates easier copy/paste behavior from the UI as the decimal is more useful.   Resolves #80496 Release note (ui change): The job status page in the DB Console will now show the status column for changefeed jobs and display the `highwater_timestamp` value in a separate column. Thise more closely matches the SQL output of `SHOW changefeed JOBS`. The highwater timestamp now displays as the nanosecond system time value by default with the human-readable value in the tooltip since the decimal value is copy/pasted more often. Co-authored-by: Azhng <[email protected]> Co-authored-by: mosquito2333 <[email protected]> Co-authored-by: David Hartunian <[email protected]>
blathers-crl bot
pushed a commit
that referenced
this issue
May 24, 2022
Previously, when a job contained a `highwater_timestamp` column value
(present for changefeeds) the status column in DB console would
*always* show that value instead of the job status ("running", "paused",
etc.). This would cause confusion for operators because the SQL output
for job status always included both a `status` column and a separate
`highwater_timestamp` column.
This change moves the `highwater_timestamp` into a separate column and
always renders the `status` column with the "pill" component that shows
the current job status.
The highwater timestamp is also moved to the sidebar in the job details
page instead of replacing the status pill, for similar consistency.
Finally, the highwater timestamp now displays the nanosecond decimal
value by default and the human-readable formatted value in the tooltip.
This faciliates easier copy/paste behavior from the UI as the decimal is
more useful.
Resolves #80496
Release note (ui change): The job status page in the DB Console will now
show the status column for changefeed jobs and display the
`highwater_timestamp` value in a separate column. Thise more closely
matches the SQL output of `SHOW changefeed JOBS`. The highwater
timestamp now displays as the nanosecond system time value by default
with the human-readable value in the tooltip since the decimal value is
copy/pasted more often.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, when a changefeed row contains a "high watermark", its status isn't reported separately in the DB console under the "status" column because it's assumed that the checkpoint is what's important.
Goal: the changefeed view should show BOTH the current status of the job and a high watermark if it's available to provide a complete picture of the job in the DB Console and match the view in SQL.
Jira issue: CRDB-15592
The text was updated successfully, but these errors were encountered: