Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: TestHeartbeatHealthTransport failed #80034

Closed
cockroach-teamcity opened this issue Apr 16, 2022 · 1 comment
Closed

rpc: TestHeartbeatHealthTransport failed #80034

cockroach-teamcity opened this issue Apr 16, 2022 · 1 comment
Labels
branch-release-22.1 Used to mark GA and release blockers, technical advisories, and bugs for 22.1 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-server-and-security DB Server & Security

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Apr 16, 2022

rpc.TestHeartbeatHealthTransport failed with artifacts on release-22.1 @ e53d691e4d46799b1fa9499401cc353fa5a208e5:

=== RUN   TestHeartbeatHealthTransport
    context_test.go:763: rpc error: code = Unknown desc = client cluster ID "8b3d7a87-c1de-4226-9c92-4fa79c4e2ff1" doesn't match server cluster ID "f078fed5-622f-4df9-a8cc-8f9d417c517c"
--- FAIL: TestHeartbeatHealthTransport (0.07s)
Help

See also: How To Investigate a Go Test Failure (internal)
Parameters in this failure:

  • TAGS=bazel,gss,deadlock

Same failure on other branches

/cc @cockroachdb/server

This test on roachdash | Improve this report!

Jira issue: CRDB-15666

@cockroach-teamcity cockroach-teamcity added branch-release-22.1 Used to mark GA and release blockers, technical advisories, and bugs for 22.1 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels Apr 16, 2022
@blathers-crl blathers-crl bot added the T-server-and-security DB Server & Security label Apr 16, 2022
@cockroach-teamcity
Copy link
Member Author

rpc.TestHeartbeatHealthTransport failed with artifacts on release-22.1 @ 7ea1f8f26e9c712f7ffd9a2291c184d706e5c837:

=== RUN   TestHeartbeatHealthTransport
    context_test.go:746: close tcp 127.0.0.1:36057->127.0.0.1:39350: use of closed network connection
--- FAIL: TestHeartbeatHealthTransport (0.04s)
Help

See also: How To Investigate a Go Test Failure (internal)
Parameters in this failure:

  • TAGS=bazel,gss

Same failure on other branches

This test on roachdash | Improve this report!

@jlinder jlinder added sync-me and removed sync-me labels May 20, 2022
@knz knz closed this as completed Jun 16, 2022
andrewbaptist added a commit to andrewbaptist/cockroach that referenced this issue Apr 3, 2023
We close the listener before closing the connection. This can result in
a spurious failure due to the Listener also closing our connection.

Epic: none
Fixes: cockroachdb#100391
Fixes: cockroachdb#77754
Informs: cockroachdb#80034

Release note: None
craig bot pushed a commit that referenced this issue Apr 4, 2023
100189:  kvcoord: Restart ranges on a dedicated goroutine. r=miretskiy a=miretskiy

Restart ranges on a dedicated goroutine (if needed).
Fix logic bug in stuck range handling.
Increase verbosity of logging to help debug mux rangefeed issues.

Informs #99560
Informs #99640
Informs #99214
Informs #98925
Informs #99092
Informs #99212
Informs #99910
Informs #99560

Release note: None

100525: rpc: Handle closed error r=erikgrinaker a=andrewbaptist

We close the listener before closing the connection. This can result in a spurious failure due to the Listener also closing our connection.

Epic: none
Fixes: #100391
Fixes: #77754
Informs: #80034

Release note: None

100528: sql: fix flaky TestSQLStatsCompactor r=j82w a=j82w

The test failure is showing more total wide scans
than expected. Change the compact stats job to run
once a year to avoid it running at the same time
as the test.

The interceptor is disabled right after delete
reducing the possibility of another operation
causing a conflict.

Epic: none
closes: #99653

Release note: none

100589: allocator: deflake full disk test r=andrewbaptist a=kvoli

In #97409 we introduced cluster settings to control the disk fullness threshold for rebalancing towards a store and shedding replicas off of the store. The `TestAllocatorFullDisks` assumes the total number of range bytes is equal or less than the rebalance threshold of the nodes, however the test was updated to use the shed threshold instead. This caused the test to flake occasionally as there was more than the expected amount of total range bytes.

This patch changes the ranges per node calculation to use the rebalance threshold again, instead of the shed threshold

```
dev test pkg/kv/kvserver/allocator/allocatorimpl -f TestAllocatorFullDisks -v --stress
...
15714 runs so far, 0 failures, over 39m45s
```

Fixes: #100033

Release note: None

100610: roachtest: set config.Quiet to true r=herkolategan a=srosenberg

After refactoring in [1], the default of config.Quiet was set to false since the roachprod CLI option is intended to set it to true. This resulted in an unwanted side-effect, namely roachtests running with the new default. Consequently, test_runner's log ended up with a bunch of (terminal) escape codes due to (status) spinner.

This change ensures roachtest explicitly sets config.Quiet to true.

[1] #99133

Epic: none

Release note: None

Co-authored-by: Yevgeniy Miretskiy <[email protected]>
Co-authored-by: Andrew Baptist <[email protected]>
Co-authored-by: j82w <[email protected]>
Co-authored-by: Austen McClernon <[email protected]>
Co-authored-by: Stan Rosenberg <[email protected]>
blathers-crl bot pushed a commit that referenced this issue Apr 4, 2023
We close the listener before closing the connection. This can result in
a spurious failure due to the Listener also closing our connection.

Epic: none
Fixes: #100391
Fixes: #77754
Informs: #80034

Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-release-22.1 Used to mark GA and release blockers, technical advisories, and bugs for 22.1 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-server-and-security DB Server & Security
Projects
None yet
Development

No branches or pull requests

3 participants