Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changefeedccl, settings: retire kv.rangefeed.catchup_scan_iterator_optimization.enabled #79728

Closed
shermanCRL opened this issue Apr 9, 2022 · 4 comments · Fixed by #82450
Closed

changefeedccl, settings: retire kv.rangefeed.catchup_scan_iterator_optimization.enabled #79728

shermanCRL opened this issue Apr 9, 2022 · 4 comments · Fixed by #82450
Assignees
@erikgrinaker
Labels
A-cdc Change Data Capture A-kv-replication Relating to Raft, consensus, and coordination. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-quick-win Likely to be a quick win for someone experienced.

Comments

@shermanCRL
Copy link
Contributor

shermanCRL commented Apr 9, 2022 •
edited by cockroach-jira-scripts
Loading

The kv.rangefeed.catchup_scan_iterator_optimization.enabled is an improvement that has been defaulted to true for v22.1. We intend to default it to true for future patch versions of v21.2.

I suggest we retire (remove) the setting for v22.1, as we did for this related setting.

Retiring this setting will remove “one more thing” to troubleshoot when dealing with CDC problems. It will simplify the support process, and make this article (internal) largely moot moving forward, a good thing.

This is not a zero-risk change, but I believe we are highly confident in it. It has been running in production for large customers, and on the v22.1 branch, for some time. See this comment for details. As such, I believe the benefits outweigh the risks.

Jira issue: CRDB-15942
@shermanCRL shermanCRL added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-cdc Change Data Capture labels Apr 9, 2022
@blathers-crl blathers-crl bot added the T-cdc label Apr 9, 2022
@blathers-crl
Copy link

blathers-crl bot commented Apr 9, 2022

cc @cockroachdb/cdc

@shermanCRL shermanCRL added the E-quick-win Likely to be a quick win for someone experienced. label Apr 9, 2022
@shermanCRL
Copy link
Contributor Author

cc @stevendanna, will leave this for you to make a call

samiskin added a commit to samiskin/cockroach that referenced this issue Apr 19, 2022
@samiskin
changefeedccl: cleanup deprecated catchup_scan_iterator_optimization …
21d28d0 
…setting

Resolves cockroachdb#79728

The catchup_scan_iterator_optimization option was defaulted to `true` in
22.1 and later patches of 21.2.  This change removes the option entirely
to avoid uncertainty during troubleshooting.

Release note (enterprise change): removed the
kv.rangefeed.catchup_scan_iterator_optimization.enabled option, treating
it as `true` at all times.
@erikgrinaker erikgrinaker mentioned this issue Apr 27, 2022
Merged
@jlinder jlinder added sync-me and removed sync-me labels May 20, 2022
@erikgrinaker erikgrinaker mentioned this issue Jun 5, 2022
Merged
@blathers-crl
Copy link

blathers-crl bot commented Jun 5, 2022

cc @cockroachdb/replication

@blathers-crl blathers-crl bot added the A-kv-replication Relating to Raft, consensus, and coordination. label Jun 5, 2022
@erikgrinaker erikgrinaker changed the title changefeedccl, settings: retire kv.rangefeed.catchup_scan_iterator_optimization.enabled in v22.1 changefeedccl, settings: retire kv.rangefeed.catchup_scan_iterator_optimization.enabled Jun 5, 2022
@erikgrinaker erikgrinaker assigned erikgrinaker and unassigned samiskin Jun 5, 2022
@craig craig bot closed this as completed in f0372fd Jun 6, 2022
@blathers-crl
Copy link

blathers-crl bot commented Jun 7, 2022

cc @cockroachdb/replication

@exalate-issue-sync exalate-issue-sync bot removed the T-cdc label Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erikgrinaker erikgrinaker

Labels
A-cdc Change Data Capture A-kv-replication Relating to Raft, consensus, and coordination. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-quick-win Likely to be a quick win for someone experienced.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

kvserver/rangefeed: always use time-bound iterators for catchup scans erikgrinaker/cockroach
4 participants
@jlinder @erikgrinaker @samiskin @shermanCRL