Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel,dev: dev generate process should have as few dependencies as possible #79660

Open
rickystewart opened this issue Apr 8, 2022 · 4 comments
Labels
A-build-system C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-dev-inf

Comments

@rickystewart
Copy link
Collaborator

rickystewart commented Apr 8, 2022

dev generate (which includes dev generate bazel go+docs) has too many dependencies. For example, generating the docs requires building a full cockroach-short binary to generate docs/generated/settings/settings{,-for-tenants}.html.

We should require building as little of cockroach as possible for this.

Original issue: #79455

Jira issue: CRDB-14969

@rickystewart rickystewart added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-build-system T-dev-inf labels Apr 8, 2022
@irfansharif
Copy link
Contributor

Is dev gen docs the only generator that requires building the cockroach binary? I think we ought to stop checking in the settings files #76910, which would make this issue less important. I'm not sure what value we get out of checking them in.

@rickystewart
Copy link
Collaborator Author

dev gen docs is the only generator that requires building the cockroach binary, yes. However more improvements could stand to be made here. For example docs/generated/swagger requires constructing a full go_path based on pkg/server which is a pretty huge dependency. That could definitely be trimmed. It stands to reason that generating code and docs should also not require any c-deps (besides protoc), but I don't think that's true today either.

@kenliu-crl
Copy link
Contributor

manually reviewed and brought up to date

Copy link

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
10 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-build-system C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-dev-inf
Projects
None yet
Development

No branches or pull requests

3 participants