Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/generated: stop checking-in files #76910

Open
irfansharif opened this issue Feb 22, 2022 · 2 comments
Open

docs/generated: stop checking-in files #76910

irfansharif opened this issue Feb 22, 2022 · 2 comments
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@irfansharif
Copy link
Contributor

irfansharif commented Feb 22, 2022

Is your feature request related to a problem? Please describe.

We currently check in generated doc files. A few of them see very frequent change (https://github.com/cockroachdb/cockroach/blob/master/docs/generated/settings/settings-for-tenants.txt) for e.g. and a frequent source of benign merge conflicts and forgot-to-generate-and-need-to-rerun-CI activity, which is not great and time consuming.

Describe the solution you'd like

Do we get much out of these things being checked in? If not, we should .gitignore them.

Jira issue: CRDB-13319

@irfansharif irfansharif added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Feb 22, 2022
@irfansharif
Copy link
Contributor Author

@knz, do you know off-hand if we need to be checking in these files?

@github-actions
Copy link

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
10 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Development

No branches or pull requests

2 participants