Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: update props for raft messages component #79614

Closed
Santamaura opened this issue Apr 7, 2022 · 0 comments · Fixed by #79772
Closed

ui: update props for raft messages component #79614

Santamaura opened this issue Apr 7, 2022 · 0 comments · Fixed by #79772
Assignees
@Santamaura
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@Santamaura
Copy link
Contributor

Santamaura commented Apr 7, 2022 •
edited by cockroach-jira-scripts
Loading

Describe the problem
The datepicker and graph timewindow selector are broken on /#/raft/messages/all. This can be fixed by passing the RaftMessages component the setMetricsFixedWindow and setTimeScale props and passing those into the MetricsDataProvider.

To Reproduce

What did you do? Describe in your own words.
Load the raft messages page from the advanced debug tab and try dragging-to-zoom on a timeframe on the graph or selecting a date/time with the datepicker.

Expected behavior
Be able to drag-to-zoom to a timeframe and use the datepicker.

Additional data / screenshots
If the problem is SQL-related, include a copy of the SQL query and the schema
of the supporting tables.

If a node in your cluster encountered a fatal error, supply the contents of the
log directories (at minimum of the affected node(s), but preferably all nodes).

Note that log files can contain confidential information. Please continue
creating this issue, but contact [email protected] to submit the log
files in private.

If applicable, add screenshots to help explain your problem.

Environment:

  • Latest CRDB version

Additional context
What was the impact?

Add any other context about the problem here.

Jira issue: CRDB-14944
@Santamaura Santamaura added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Apr 7, 2022
@Santamaura Santamaura self-assigned this Apr 7, 2022
Santamaura added a commit to Santamaura/cockroach that referenced this issue Apr 11, 2022
@Santamaura
ui: fix raft messages graph
1de4532 
Previously, when a user attempted to drag-to-zoom on the graph it would
not work properly. This is due to missing props that set the time window
and the time scale. Therefore, this patch updates the props to include
these in order to have the date picker and graph drag-to-zoom working
again.

resolves cockroachdb#79614

Release note (bug fix): Update props on the raft messages page to
include functions to set the time window and time scale in order
to fix date picker and drag-to-zoom functionality.
@Santamaura Santamaura mentioned this issue Apr 11, 2022
Merged
@craig craig bot closed this as completed in 3582a90 Apr 11, 2022
blathers-crl bot pushed a commit that referenced this issue Apr 11, 2022
@Santamaura
ui: fix raft messages graph
97a27f4 
Previously, when a user attempted to drag-to-zoom on the graph it would
not work properly. This is due to missing props that set the time window
and the time scale. Therefore, this patch updates the props to include
these in order to have the date picker and graph drag-to-zoom working
again.

resolves #79614

Release note (bug fix): Update props on the raft messages page to
include functions to set the time window and time scale in order
to fix date picker and drag-to-zoom functionality.
@blathers-crl blathers-crl bot mentioned this issue Apr 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Santamaura Santamaura

Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[CRDB-14944] ui: fix raft messages graph Santamaura/cockroach
1 participant
@Santamaura