Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Index help page does not reflect updated hash-sharded index storage parameter #79044

Closed
nickvigilante opened this issue Mar 30, 2022 · 1 comment · Fixed by #79045
Closed
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@nickvigilante
Copy link
Contributor

nickvigilante commented Mar 30, 2022

I noticed in the \h create index; page in the CRDB CLI, the hash-sharded index sample doesn't use the new storage parameter (USING HASH WITH (bucket_count = <shard_buckets>). Instead, it uses the 21.2 syntax:

[email protected]:26257/defaultdb> \h create index;
Command:     CREATE INDEX
Description: create a new index
Category:    schema manipulation
Syntax:
CREATE [UNIQUE | INVERTED] INDEX [CONCURRENTLY] [IF NOT EXISTS] [<idxname>]
       ON <tablename> ( <colname> [ASC | DESC] [, ...] )
       [USING HASH WITH BUCKET_COUNT = <shard_buckets>] [STORING ( <colnames...> )]
       [PARTITION BY <partition params>]
       [WITH <storage_parameter_list] [WHERE <where_conds...>]

See also:
  SHOW TABLES
  CREATE TABLE
  SHOW INDEXES
  SHOW CREATE,
https://www.cockroachlabs.com/docs/v22.1/create-index.html

[email protected]:26257/defaultdb>

Jira issue: CRDB-14515

@nickvigilante nickvigilante added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Mar 30, 2022
@ajwerner
Copy link
Contributor

I'm inclined to remove the BUCKET_COUNT from the held entirely given we have the storage_parameter_list.

craig bot pushed a commit that referenced this issue Mar 30, 2022
79024: sql/schemachanger: rework gcjob creation for descriptions r=ajwerner a=ajwerner

This should also be a bit easier to extend in directions we'll need to go in
the future.

Part of dealing with #78030.

Release note: None

79045: sql/parser: remove mention of BUCKET_COUNT from help text r=ajwerner a=ajwerner

Fixes #79044

Release note (sql change): Help text for creating indexes or primary key
constraints no longer mentions BUCKET_COUNT because it can now be omitted
and a default is used.

Co-authored-by: Andrew Werner <[email protected]>
@craig craig bot closed this as completed in 9416c64 Mar 30, 2022
blathers-crl bot pushed a commit that referenced this issue Mar 30, 2022
Fixes #79044

Release note (sql change): Help text for creating indexes or primary key
constraints no longer mentions BUCKET_COUNT because it can now be omitted
and a default is used.
fqazi pushed a commit to fqazi/cockroach that referenced this issue Apr 4, 2022
Fixes cockroachdb#79044

Release note (sql change): Help text for creating indexes or primary key
constraints no longer mentions BUCKET_COUNT because it can now be omitted
and a default is used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants