-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cdc: crdb_internal.complete_replication_stream causes panic: UpdateDeadline() called on leaf txn #78553
Comments
roachtest.sqlsmith/setup=seed/setting=no-mutations failed with artifacts on master @ 834eaa0e83350486830867b5edd6e8809b52aa55:
|
roachtest.sqlsmith/setup=seed/setting=no-mutations failed with artifacts on master @ 32b45c4bcf1ab41f0ba3abd36cb670eea7f450fd:
|
All three of the above failures were due to
|
All of these queries include |
cc @cockroachdb/cdc |
Don't use crdb_internal.complete_replication_stream when generating sqlsmith queries, since it currently causes a panic. Informs cockroachdb#78553 Release note: None
78435: opt: fix deduplication of unique constraints in test catalog r=mgartner a=mgartner This commit fixes a bug in the test catalog which incorrectly de-duplicated unique constraints that had the same columns but different predicates. Fixes #76994 Release note: None 78524: zcfg: rename UpdateZoneConfigForTables to RefreshZoneConfigsForTable r=arulajmani a=RichardJCai Release note: None Fixes #77641 78533: ui: don't download .dll.js bundles r=sjbarag a=sjbarag Loading the CockroachDB admin UI (served from port 8080) would previously download three JS files: `bundle.js`, `vendor.dll.js`, and `protos.dll.js`. Neither `vendor.dll.js` nor `protos.dll.js` need to be included via `<script/>` tag, as they're used only as build-time tooling to accelerate webpack builds. Only a single file -- `bundle.js` -- needs to be loaded for the admin UI to be functional, and Bazel-produced builds don't have any `.dll.js` files to serve. Don't load `.dll.js` files via index.html. Since dll file aren't being served directly to users anymore, there's no need to embed them in the `cockroach` binary. Stop copying `.dll.js` files into `pkg/ui/dist{oss,ccl}` during builds, reducing the `cockroach` binary size by ~19MB (darwin, x86) when built with GNU make. 78607: sqlsmith: skip crdb_internal.complete_replication_stream r=rytaft a=rytaft Don't use crdb_internal.complete_replication_stream when generating sqlsmith queries, since it currently causes a panic. Informs #78553 Release note: None 78609: cli: de-flake TestDockerCLI/test_demo_node_cmds.tcl r=ajwerner a=tbg Touches #76391. (Not closing since `@ajwerner` requested so) This test is very flaky, so we need a stop-gap. It's also not really useful to get into the gossip info from a cli test. Release note: None Co-authored-by: Marcus Gartner <[email protected]> Co-authored-by: richardjcai <[email protected]> Co-authored-by: Sean Barag <[email protected]> Co-authored-by: Rebecca Taft <[email protected]> Co-authored-by: Tobias Grieger <[email protected]>
@rytaft can we close this? |
I updated SQLSmith so we won't get more failures like this, but I'm not sure if y'all are concerned about the failures that we saw, |
Seems to be fixed. |
roachtest.sqlsmith/setup=seed/setting=no-mutations failed with artifacts on master @ 090d481f2ec1d1c3e668274f50e4f152b4596a1b:
Help
See: roachtest README
See: How To Investigate (internal)
This test on roachdash | Improve this report!
Jira issue: CRDB-14177
Epic CRDB-11732
The text was updated successfully, but these errors were encountered: