-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/ccl/testccl/workload/schemachange/schemachange_test: TestWorkload failed #78478
Comments
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed with artifacts on master @ 090d481f2ec1d1c3e668274f50e4f152b4596a1b:
Help
See also: How To Investigate a Go Test Failure (internal)
Same failure on other branches
|
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed with artifacts on master @ 834eaa0e83350486830867b5edd6e8809b52aa55:
Help
See also: How To Investigate a Go Test Failure (internal)
Same failure on other branches
|
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed with artifacts on master @ 32b45c4bcf1ab41f0ba3abd36cb670eea7f450fd:
Help
See also: How To Investigate a Go Test Failure (internal)
Same failure on other branches
|
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed with artifacts on master @ 29716850b181718594663889ddb5f479fef7a305:
Help
See also: How To Investigate a Go Test Failure (internal)
Same failure on other branches
|
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed with artifacts on master @ dce0a307cd242d8575f59a153026b1af9e6a7936:
Help
See also: How To Investigate a Go Test Failure (internal)
Same failure on other branches
|
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed with artifacts on master @ a3ca09014c8c8bab727d8a3dfaeaafe3cab7e08f:
Help
See also: How To Investigate a Go Test Failure (internal)
Same failure on other branches
|
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed with artifacts on master @ a3ca09014c8c8bab727d8a3dfaeaafe3cab7e08f:
Help
See also: How To Investigate a Go Test Failure (internal)
Same failure on other branches
|
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed with artifacts on master @ a3ca09014c8c8bab727d8a3dfaeaafe3cab7e08f:
Help
See also: How To Investigate a Go Test Failure (internal)
Same failure on other branches
|
not sure why this didn't get automatically traiged to sql schema. Just hit this flake here: https://teamcity.cockroachdb.com/viewLog.html?buildId=5041477&buildTypeId=Cockroach_UnitTests |
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed with artifacts on master @ 97e72bacbeb9574f09f7475a62ef45c3e228183e:
Help
See also: How To Investigate a Go Test Failure (internal)
Same failure on other branches
|
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed with artifacts on master @ 97e72bacbeb9574f09f7475a62ef45c3e228183e:
Help
See also: How To Investigate a Go Test Failure (internal)
Same failure on other branches
|
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed with artifacts on master @ 97e72bacbeb9574f09f7475a62ef45c3e228183e:
Help
See also: How To Investigate a Go Test Failure (internal)
Same failure on other branches
|
Let me re-enable this again on master, since it should be stable enough now. |
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed with artifacts on master @ c030b8b6dcf61628f9e72f61848f8f9dd972fdde:
Parameters: Same failure on other branches
|
This one is linked to binding a schema and not having it visible, I'll add retry logic in another spot. |
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed with artifacts on master @ 47df1bc3a28f705e56ff4efc3d81c6fc90e096b5:
Parameters: Same failure on other branches
|
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed with artifacts on master @ 8f23486add4b1e2e8356b2f6b04d1741b4141da4:
Parameters: Same failure on other branches
|
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed with artifacts on master @ 8d34ef1ea15850ee1c70470610b6652df4c317de:
Parameters: Same failure on other branches
|
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed with artifacts on master @ 8d34ef1ea15850ee1c70470610b6652df4c317de:
Parameters: Same failure on other branches
|
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed with artifacts on master @ 8d34ef1ea15850ee1c70470610b6652df4c317de:
Parameters: Same failure on other branches
|
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed with artifacts on master @ 8d34ef1ea15850ee1c70470610b6652df4c317de:
Parameters: Same failure on other branches
|
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed with artifacts on master @ 5c2c62ecf1bea60c807edc6b4da22d900ad4ae03:
Parameters: Same failure on other branches
|
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed with artifacts on master @ 5c2c62ecf1bea60c807edc6b4da22d900ad4ae03:
|
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed with artifacts on master @ a0d8839aa6164af81a9ebb140147d3baf5321287:
Parameters: Same failure on other branches
|
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed with artifacts on master @ cb55144cdec54d2a70f074ad64b4eca5e6c6891a:
Parameters: Same failure on other branches
|
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed with artifacts on master @ 41c005eb7eb885d2a5b21b01459e121daf5ba18c:
Parameters: Same failure on other branches
|
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed with artifacts on master @ 869d44cb46ba1900202eb9e33a3353eecf06b269:
|
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed with artifacts on master @ 869d44cb46ba1900202eb9e33a3353eecf06b269:
Parameters: Same failure on other branches
|
Spent time investigating these failures majority of them are linked to: #85677. There is one other interesting failure assuming we address that, still digging into that one |
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed with artifacts on master @ e6c418fdfc9f4b32e07cffaf3bb7285abcd0613b:
|
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed with artifacts on master @ 770ff3c545a51752490403da64d56fb397f49c5e:
|
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed with artifacts on master @ 3b16435371a43d603d193a1e2b480a23fba3f07a:
|
The failure here:
should we bump the size of the test? |
#85677 is a common source of failures here. It's not all of them, it's a large number of them. |
The 5 minute timeout is that somewhere we're leaking a lease on the database descriptor. |
One failure here, after squashing the weird bugs that come out of #85677 is that we fail to take into consideration the computed column expressions when performing inserts: Consider a computed column like |
Okay, another issue is For now I'm going to skip inserts with this issue and revisit both of these later. |
This is very flakey. Some of it is due to cockroachdb#87672. Some of it was due to cockroachdb#85677. There are some issues with inserts which need to be fixed. Until this stabilizes, it's causing problems. Along the way, I'm marking cockroachdb#78478 as a GA blocker so we do actually fix it. Release note: None
80474: gcp: make per-chunk retry upload timeout configurable r=dt a=adityamaru This change adds a cluster setting `cloudstorage.gs.chunking.retry_timeout` that can be used to change the default per-chunk retry timeout that GCS imposes when chunking of file upload is enabled. The default value is set to 60 seconds, which is double of the default google sdk value of 30s. This change was motivated by sporadic occurrences of a 503 service unavailable error during backups. On its own this change is not expected to solve the resiliency issues of backup when the upload service is unavailable, but it is nice to have configurable setting nonetheless. Release note (sql change): `cloudstorage.gs.chunking.retry_timeout` is a cluster setting that can be used to configure the per-chunk retry timeout of files to Google Cloud Storage. The default value is 60 seconds. 86696: sql/gcjob: make index GC robust to descriptors being deleted r=ajwerner a=ajwerner First commit is #86690 If the descriptor was deleted, the GC job should exit gracefully. Fixes #86340 Release justification: bug fix for backport Release note (bug fix): In some scenarios, when a DROP INDEX was run around the same time as a DROP TABLE or DROP DATABASE covering the same data, the `DROP INDEX` gc job could get caught retrying indefinitely. This has been fixed. 87378: builtins: stream consistency checker output r=pavelkalinnikov a=tbg Also makes it resilient to per-Range errors, which now no longer tank the entire operation. ```sql -- avoid buffering in cli \set display_format=csv; -- avoid rows getting buffered at server set avoid_buffering=true; -- compute as fast as possible SET CLUSTER SETTING server.consistency_check.max_rate = '1tb'; SELECT * FROM crdb_internal.check_consistency(false, '', ''); ``` Release justification: improvement for a debugging-related feature Release note: None 87657: Makefile: always use `cockroach-short` for file generation r=knz a=rickystewart This defaults to the full `cockroach` executable which requires pulling in all the UI stuff. Use `cockroach-short` to make generation require fewer dependencies. Release note: None 87701: testccl/workload/schemachange: skip random schema test r=ajwerner a=ajwerner This is very flakey. Some of it is due to #87672. Some of it was due to #85677. There are some issues with inserts which need to be fixed. Until this stabilizes, it's causing problems. Along the way, I'm marking #78478 as a GA blocker so we do actually fix it. Release note: None Co-authored-by: Aditya Maru <[email protected]> Co-authored-by: Andrew Werner <[email protected]> Co-authored-by: Tobias Grieger <[email protected]> Co-authored-by: Ricky Stewart <[email protected]>
Fixed via #88085 |
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed with artifacts on master @ cb10bfe399528718776711068b2560e5f6d53b55:
Help
See also: How To Investigate a Go Test Failure (internal)
Parameters in this failure:
Same failure on other branches
This test on roachdash | Improve this report!
Jira issue: CRDB-14146
The text was updated successfully, but these errors were encountered: