sem/tree: v21.2.7: incorrect type conversion in ColumnAccessExpr - maybe DNull check is missing? #78159

cockroach-teamcity · 2022-03-20T21:12:21Z

This issue was autofiled by Sentry. It represents a crash or reported error on a live cluster with telemetry enabled.

Sentry link: https://sentry.io/organizations/cockroach-labs/issues/3118425943/?referrer=webhooks_plugin

Panic message:

error.go:88: unexpected error from the vectorized engine: ×
--
*barriers.barrierError
*errutil.withPrefix: unexpected error from the vectorized engine (1)
error.go:88: *withstack.withStack (top exception)
*assert.withAssertionFailure
*colexecerror.notInternalError
*colexecerror.notInternalError
(check the extra data payloads)

Stacktrace (expand for inline code snippets):

cockroach/pkg/sql/colexecerror/error.go

Lines 87 to 89 in 37dee54

    
           	// unexpected. 
        
           	retErr = errors.NewAssertionErrorWithWrappedErrf(err, "unexpected error from the vectorized engine") 
        
           }

in pkg/sql/colexecerror.CatchVectorizedRuntimeError.func1
/usr/local/go/src/runtime/panic.go#L964-L966 in runtime.gopanic
/usr/local/go/src/runtime/iface.go#L260-L262 in runtime.panicdottypeE
/usr/local/go/src/runtime/iface.go#L270-L272 in runtime.panicdottypeI

cockroach/pkg/sql/sem/tree/eval.go

Lines 4109 to 4111 in 37dee54

    
           	} 
        
           	return d.(*DTuple).D[expr.ColIndex], nil 
        
           }

in pkg/sql/sem/tree.(*ColumnAccessExpr).Eval

cockroach/pkg/sql/sem/tree/eval.go

Lines 4355 to 4357 in 37dee54

    
           func (expr *IsNotNullExpr) Eval(ctx *EvalContext) (Datum, error) { 
        
           	d, err := expr.Expr.(TypedExpr).Eval(ctx) 
        
           	if err != nil {

in pkg/sql/sem/tree.(*IsNotNullExpr).Eval

cockroach/pkg/sql/execinfrapb/expr.go

Lines 210 to 212 in 37dee54

    
           d, err := filter.Eval(evalCtx) 
        
           if err != nil {

in pkg/sql/execinfrapb.RunFilter

cockroach/pkg/sql/execinfrapb/expr.go

Lines 199 to 201 in 37dee54

    
           eh.evalCtx.PushIVarContainer(eh) 
        
           pass, err := RunFilter(eh.Expr, eh.evalCtx) 
        
           eh.evalCtx.PopIVarContainer()

in pkg/sql/execinfrapb.(*ExprHelper).EvalFilter

cockroach/pkg/sql/rowexec/filterer.go

Lines 94 to 96 in 37dee54

    
           // Perform the actual filtering. 
        
           passes, err := f.filter.EvalFilter(row) 
        
           if err != nil {

in pkg/sql/rowexec.(*filtererProcessor).Next

cockroach/pkg/sql/row_source_to_plan_node.go

Lines 75 to 77 in 37dee54

    
           var p *execinfrapb.ProducerMetadata 
        
           r.row, p = r.source.Next()

in pkg/sql.(*rowSourceToPlanNode).Next

cockroach/pkg/sql/apply_join.go

Lines 194 to 196 in 37dee54

    
           // We need a new row on the left. 
        
           ok, err := a.input.plan.Next(params) 
        
           if err != nil {

in pkg/sql.(*applyJoinNode).Next

cockroach/pkg/sql/plan_node_to_row_source.go

Lines 186 to 188 in 37dee54

    
           for p.State == execinfra.StateRunning { 
        
           	valid, err := p.node.Next(p.params) 
        
           	if err != nil || !valid {

in pkg/sql.(*planNodeToRowSource).Next

cockroach/pkg/sql/colexec/columnarizer.go

Lines 221 to 223 in 37dee54

    
           for ; nRows < c.batch.Capacity(); nRows++ { 
        
           	row, meta := c.input.Next() 
        
           	if meta != nil {

in pkg/sql/colexec.(*Columnarizer).Next

cockroach/pkg/sql/colexec/materializer.go

Lines 260 to 262 in 37dee54

    
           // Get a fresh batch. 
        
           m.batch = m.input.Next() 
        
           if m.batch.Length() == 0 {

in pkg/sql/colexec.(*Materializer).next

cockroach/pkg/sql/colexec/materializer.go

Lines 285 to 287 in 37dee54

    
           func (m *Materializer) nextAdapter() { 
        
           	m.outputRow = m.next() 
        
           }

in pkg/sql/colexec.(*Materializer).nextAdapter

cockroach/pkg/sql/colexecerror/error.go

Lines 90 to 92 in 37dee54

    
           }() 
        
           operation() 
        
           return retErr

in pkg/sql/colexecerror.CatchVectorizedRuntimeError

cockroach/pkg/sql/colexec/materializer.go

Lines 291 to 293 in 37dee54

    
           for m.State == execinfra.StateRunning { 
        
           	if err := colexecerror.CatchVectorizedRuntimeError(m.nextAdapter); err != nil { 
        
           		m.MoveToDraining(err)

in pkg/sql/colexec.(*Materializer).Next

cockroach/pkg/sql/colflow/flow_coordinator.go

Lines 126 to 128 in 37dee54

    
           if f.State == execinfra.StateRunning { 
        
           	row, meta := f.input.Next() 
        
           	if meta != nil {

in pkg/sql/colflow.(*FlowCoordinator).next

cockroach/pkg/sql/colflow/flow_coordinator.go

Lines 143 to 145 in 37dee54

    
           func (f *FlowCoordinator) nextAdapter() { 
        
           	f.row, f.meta = f.next() 
        
           }

in pkg/sql/colflow.(*FlowCoordinator).nextAdapter

cockroach/pkg/sql/colexecerror/error.go

Lines 90 to 92 in 37dee54

    
           }() 
        
           operation() 
        
           return retErr

in pkg/sql/colexecerror.CatchVectorizedRuntimeError

cockroach/pkg/sql/colflow/flow_coordinator.go

Lines 148 to 150 in 37dee54

    
           func (f *FlowCoordinator) Next() (rowenc.EncDatumRow, *execinfrapb.ProducerMetadata) { 
        
           	if err := colexecerror.CatchVectorizedRuntimeError(f.nextAdapter); err != nil { 
        
           		f.MoveToDraining(err)

in pkg/sql/colflow.(*FlowCoordinator).Next

cockroach/pkg/sql/execinfra/base.go

Lines 185 to 187 in 37dee54

    
           for { 
        
           	row, meta := src.Next() 
        
           	// Emit the row; stop if no more rows are needed.

in pkg/sql/execinfra.Run

cockroach/pkg/sql/execinfra/processorsbase.go

Lines 730 to 732 in 37dee54

    
           	pb.self.Start(ctx) 
        
           	Run(pb.Ctx, pb.self, pb.Output) 
        
           }

in pkg/sql/execinfra.(*ProcessorBaseNoHelper).Run

cockroach/pkg/sql/flowinfra/flow.go

Lines 446 to 448 in 37dee54

    
           	log.VEventf(ctx, 1, "running %T in the flow's goroutine", headProc) 
        
           	headProc.Run(ctx) 
        
           }

in pkg/sql/flowinfra.(*FlowBase).Run

cockroach/pkg/sql/colflow/vectorized_flow.go

Lines 244 to 246 in 37dee54

    
           // as the root, so we run this flow with the default implementation. 
        
           f.FlowBase.Run(ctx, doneFn) 
        
           return

in pkg/sql/colflow.(*vectorizedFlow).Run

cockroach/pkg/sql/distsql_running.go

Lines 547 to 549 in 37dee54

    
           // TODO(radu): this should go through the flow scheduler. 
        
           flow.Run(ctx, func() {})

in pkg/sql.(*DistSQLPlanner).Run

cockroach/pkg/sql/distsql_running.go

Lines 1288 to 1290 in 37dee54

    
           recv.expectedRowsRead = int64(physPlan.TotalEstimatedScannedRows) 
        
           runCleanup := dsp.Run(planCtx, txn, physPlan, recv, evalCtx, nil /* finishedSetupFn */) 
        
           return func() {

in pkg/sql.(*DistSQLPlanner).PlanAndRun

cockroach/pkg/sql/apply_join.go

Lines 317 to 319 in 37dee54

    
           params.p.extendedEvalCtx.ExecCfg.DistSQLPlanner.PlanAndRun( 
        
           	params.ctx, evalCtx, planCtx, params.p.Txn(), plan.main, recv,

in pkg/sql.runPlanInsidePlan

cockroach/pkg/sql/recursive_cte.go

Lines 128 to 130 in 37dee54

    
           if err := runPlanInsidePlan(params, newPlan.(*planComponents), &n.workingRows); err != nil { 
        
           	return false, err

in pkg/sql.(*recursiveCTENode).Next

cockroach/pkg/sql/plan_node_to_row_source.go

Lines 186 to 188 in 37dee54

    
           for p.State == execinfra.StateRunning { 
        
           	valid, err := p.node.Next(p.params) 
        
           	if err != nil || !valid {

in pkg/sql.(*planNodeToRowSource).Next

cockroach/pkg/sql/colexec/columnarizer.go

Lines 221 to 223 in 37dee54

    
           for ; nRows < c.batch.Capacity(); nRows++ { 
        
           	row, meta := c.input.Next() 
        
           	if meta != nil {

in pkg/sql/colexec.(*Columnarizer).Next

cockroach/pkg/sql/colflow/stats.go

Lines 97 to 99 in 37dee54

    
           bic.stopwatch.Start() 
        
           batch = bic.Operator.Next() 
        
           bic.stopwatch.Stop()

in pkg/sql/colflow.(*batchInfoCollector).Next

pkg/sql/colexecerror/error.go in pkg/sql/colexecerror.CatchVectorizedRuntimeError.func1 at line 88
/usr/local/go/src/runtime/panic.go in runtime.gopanic at line 965
/usr/local/go/src/runtime/iface.go in runtime.panicdottypeE at line 261
/usr/local/go/src/runtime/iface.go in runtime.panicdottypeI at line 271
pkg/sql/sem/tree/eval.go in pkg/sql/sem/tree.(*ColumnAccessExpr).Eval at line 4110
pkg/sql/sem/tree/eval.go in pkg/sql/sem/tree.(*IsNotNullExpr).Eval at line 4356
pkg/sql/execinfrapb/expr.go in pkg/sql/execinfrapb.RunFilter at line 211
pkg/sql/execinfrapb/expr.go in pkg/sql/execinfrapb.(*ExprHelper).EvalFilter at line 200
pkg/sql/rowexec/filterer.go in pkg/sql/rowexec.(*filtererProcessor).Next at line 95
pkg/sql/row_source_to_plan_node.go in pkg/sql.(*rowSourceToPlanNode).Next at line 76
pkg/sql/apply_join.go in pkg/sql.(*applyJoinNode).Next at line 195
pkg/sql/plan_node_to_row_source.go in pkg/sql.(*planNodeToRowSource).Next at line 187
pkg/sql/colexec/columnarizer.go in pkg/sql/colexec.(*Columnarizer).Next at line 222
pkg/sql/colexec/materializer.go in pkg/sql/colexec.(*Materializer).next at line 261
pkg/sql/colexec/materializer.go in pkg/sql/colexec.(*Materializer).nextAdapter at line 286
pkg/sql/colexecerror/error.go in pkg/sql/colexecerror.CatchVectorizedRuntimeError at line 91
pkg/sql/colexec/materializer.go in pkg/sql/colexec.(*Materializer).Next at line 292
pkg/sql/colflow/flow_coordinator.go in pkg/sql/colflow.(*FlowCoordinator).next at line 127
pkg/sql/colflow/flow_coordinator.go in pkg/sql/colflow.(*FlowCoordinator).nextAdapter at line 144
pkg/sql/colexecerror/error.go in pkg/sql/colexecerror.CatchVectorizedRuntimeError at line 91
pkg/sql/colflow/flow_coordinator.go in pkg/sql/colflow.(*FlowCoordinator).Next at line 149
pkg/sql/execinfra/base.go in pkg/sql/execinfra.Run at line 186
pkg/sql/execinfra/processorsbase.go in pkg/sql/execinfra.(*ProcessorBaseNoHelper).Run at line 731
pkg/sql/flowinfra/flow.go in pkg/sql/flowinfra.(*FlowBase).Run at line 447
pkg/sql/colflow/vectorized_flow.go in pkg/sql/colflow.(*vectorizedFlow).Run at line 245
pkg/sql/distsql_running.go in pkg/sql.(*DistSQLPlanner).Run at line 548
pkg/sql/distsql_running.go in pkg/sql.(*DistSQLPlanner).PlanAndRun at line 1289
pkg/sql/apply_join.go in pkg/sql.runPlanInsidePlan at line 318
pkg/sql/recursive_cte.go in pkg/sql.(*recursiveCTENode).Next at line 129
pkg/sql/plan_node_to_row_source.go in pkg/sql.(*planNodeToRowSource).Next at line 187
pkg/sql/colexec/columnarizer.go in pkg/sql/colexec.(*Columnarizer).Next at line 222
pkg/sql/colflow/stats.go in pkg/sql/colflow.(*batchInfoCollector).Next at line 98

Tag	Value
Cockroach Release	`v21.2.7`
Cockroach SHA:	`37dee54`
Platform	linux amd64
Distribution	CCL
Environment	v21.2.7
Command	start-single-node
Go Version	``
# of CPUs
# of Goroutines

Jira issue: CRDB-14021

The text was updated successfully, but these errors were encountered:

mgartner · 2022-03-23T21:53:31Z

Good eye @yuzefovich! I was able to reverse engineer a reproduction from the clue you left:

defaultdb> CREATE TABLE t (b BOOL);
CREATE TABLE

defaultdb> INSERT INTO t VALUES (false);
INSERT 1

defaultdb> SELECT (CASE WHEN b THEN ((ROW(1) AS a)) ELSE NULL END).a from t;
ERROR: internal error: unexpected error from the vectorized engine: interface conversion: tree.Datum is tree.dNull, not *tree.DTuple
SQLSTATE: XX000
DETAIL: stack trace:
/go/src/github.com/cockroachdb/cockroach/pkg/sql/colexecerror/error.go:88: func1()
/usr/local/go/src/runtime/panic.go:965: gopanic()
/usr/local/go/src/runtime/iface.go:261: panicdottypeE()
/usr/local/go/src/runtime/iface.go:271: panicdottypeI()
/go/src/github.com/cockroachdb/cockroach/pkg/sql/sem/tree/eval.go:4110: Eval()
/go/src/github.com/cockroachdb/cockroach/pkg/sql/execinfrapb/expr.go:229: Eval()
/go/src/github.com/cockroachdb/cockroach/pkg/sql/execinfra/processorsbase.go:281: ProcessRow()
/go/src/github.com/cockroachdb/cockroach/pkg/sql/execinfra/processorsbase.go:699: ProcessRowHelper()
/go/src/github.com/cockroachdb/cockroach/pkg/sql/rowexec/noop.go:87: Next()
/go/src/github.com/cockroachdb/cockroach/pkg/sql/colexec/columnarizer.go:222: Next()
/go/src/github.com/cockroachdb/cockroach/pkg/sql/colflow/stats.go:98: Next()
/go/src/github.com/cockroachdb/cockroach/pkg/sql/colflow/flow_coordinator.go:239: nextAdapter()
/go/src/github.com/cockroachdb/cockroach/pkg/sql/colexecerror/error.go:91: CatchVectorizedRuntimeError()
/go/src/github.com/cockroachdb/cockroach/pkg/sql/colflow/flow_coordinator.go:243: next()
/go/src/github.com/cockroachdb/cockroach/pkg/sql/colflow/flow_coordinator.go:282: Run()
/go/src/github.com/cockroachdb/cockroach/pkg/sql/colflow/vectorized_flow.go:258: Run()
/go/src/github.com/cockroachdb/cockroach/pkg/sql/distsql_running.go:548: Run()
/go/src/github.com/cockroachdb/cockroach/pkg/sql/distsql_running.go:1289: PlanAndRun()
/go/src/github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:1381: execWithDistSQLEngine()
/go/src/github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:1072: dispatchToExecutionEngine()
/go/src/github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:709: execStmtInOpenState()
/go/src/github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:129: execStmt()
/go/src/github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:1705: func1()
/go/src/github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:1707: execCmd()
/go/src/github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:1629: run()
/go/src/github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:668: ServeConn()
/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn.go:648: func1()
/usr/local/go/src/runtime/asm_amd64.s:1371: goexit()

HINT: You have encountered an unexpected error.

Please check the public issue tracker to check whether this problem is
already tracked. If you cannot find it there, please report the error
with details by creating a new issue.

If you would rather not post publicly, please contact us directly
using the support form.

We appreciate your feedback.

mgartner · 2022-03-24T14:13:58Z

Postgres doesn't support our syntax for labelled tuples, but I think this is an equivalent statement that shows that a column access of NULL should result in NULL:

marcus=# CREATE TABLE t (b BOOL);
CREATE TABLE

marcus=# INSERT INTO t VALUES (false);
INSERT 0 1

marcus=# SELECT (CASE WHEN b THEN ((ROW(b)::t)) ELSE NULL END).b FROM t;
  b
------
 NULL
(1 row)

Previously, `ColumnAccessExpr.Eval` would panic if the `ColumnAccessExpr`'s inner expression evaluated to `NULL`, because it attempted to cast this `NULL` to a `DTuple`. Now, if the inner expression is `NULL`, `ColumnAccessExpr.Eval` returns `NULL`. Fixes cockroachdb#78159 Release note (bug fix): A bug has been fixed that caused an internal error when the inner expression of a column access expression evaluated to `NULL`. For example, evaluation of the expression `(CASE WHEN b THEN ((ROW(1) AS a)) ELSE NULL END).a` would error when `b` is `false`. This bug has been present since version 19.1 or earlier.

78423: sql: fix ColumnAccessExpr.Eval with NULL inner expression r=mgartner a=mgartner #### sql: fix ColumnAccessExpr.Eval with NULL inner expression Previously, `ColumnAccessExpr.Eval` would panic if the `ColumnAccessExpr`'s inner expression evaluated to `NULL`, because it attempted to cast this `NULL` to a `DTuple`. Now, if the inner expression is `NULL`, `ColumnAccessExpr.Eval` returns `NULL`. Fixes #78159 Release note (bug fix): A bug has been fixed that caused an internal error when the inner expression of a column access expression evaluated to `NULL`. For example, evaluation of the expression `(CASE WHEN b THEN ((ROW(1) AS a)) ELSE NULL END).a` would error when `b` is `false`. This bug has been present since version 19.1 or earlier. #### sql: include tuple labels in types returned from typeCheckSameTypedTupleExprs Previously, an expression that produced a tuple from several potential values was typed as a tuple without any labels. This prevented a tuple's column to be accessed by a label name. For example, the expression below would result in the error "could not identify column 'a' in record data type". SELECT (CASE WHEN true THEN (ROW(1) AS a) ELSE (ROW(2) AS a) END).a Now, the labels of the first tuple are used in the type of the outer expression. Fixes #78515 Release note (bug fix): A bug has been fixed that caused an error when accessing a named column of a labelled tuple. The bug only occurred when an expression could produce one of several different tuples. For example, `(CASE WHEN true THEN (ROW(1) AS a) ELSE (ROW(2) AS a) END).a` would fail to evaluate. This bug was present since version 22.1.0. Although present in previous versions, it was impossible to encounter due to limitations that prevented using tuples in this way. Co-authored-by: Marcus Gartner <[email protected]>

Previously, `ColumnAccessExpr.Eval` would panic if the `ColumnAccessExpr`'s inner expression evaluated to `NULL`, because it attempted to cast this `NULL` to a `DTuple`. Now, if the inner expression is `NULL`, `ColumnAccessExpr.Eval` returns `NULL`. Fixes #78159 Release note (bug fix): A bug has been fixed that caused an internal error when the inner expression of a column access expression evaluated to `NULL`. For example, evaluation of the expression `(CASE WHEN b THEN ((ROW(1) AS a)) ELSE NULL END).a` would error when `b` is `false`. This bug has been present since version 19.1 or earlier.

This uncomments a unit test from cockroachdb#78159 which was fixed by cockroachdb#109635. Informs: cockroachdb#109105 Release note: None

cockroach-teamcity added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. O-sentry Originated from an in-the-wild panic report. labels Mar 20, 2022

blathers-crl bot added the T-sql-queries SQL Queries Team label Mar 22, 2022

mgartner self-assigned this Mar 22, 2022

mgartner mentioned this issue Mar 24, 2022

sql: fix ColumnAccessExpr.Eval with NULL inner expression #78423

Merged

craig bot closed this as completed in 6b838d9 Apr 6, 2022

craig bot closed this as completed in #78423 Apr 6, 2022

blathers-crl bot mentioned this issue Apr 6, 2022

release-21.1: sql: fix ColumnAccessExpr.Eval with NULL inner expression #79527

Merged

blathers-crl bot mentioned this issue Apr 6, 2022

release-21.2: sql: fix ColumnAccessExpr.Eval with NULL inner expression #79528

Merged

blathers-crl bot mentioned this issue Apr 6, 2022

release-22.1: sql: fix ColumnAccessExpr.Eval with NULL inner expression #79529

Merged

jlinder added the sync-me-3 label May 24, 2022

mgartner added this to SQL Queries Jul 24, 2023

mgartner moved this to Done in SQL Queries Jul 24, 2023

This was referenced Aug 24, 2023

sql: CASE with RECORD type and NULL causes internal error with vectorized engine #109105

Closed

sql/tests: TestRandomSyntaxFunctions failed [int64 varint decoding failed] #109486

Closed

msirek pushed a commit to msirek/cockroach that referenced this issue Sep 8, 2023

logictest: Uncomment t78159 test case

2a617ea

This uncomments a unit test from cockroachdb#78159 which was fixed by cockroachdb#109635. Informs: cockroachdb#109105 Release note: None

msirek mentioned this issue Sep 8, 2023

logictest: Uncomment t78159 test case #110260

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

sem/tree: v21.2.7: incorrect type conversion in ColumnAccessExpr - maybe DNull check is missing? #78159

sem/tree: v21.2.7: incorrect type conversion in ColumnAccessExpr - maybe DNull check is missing? #78159

cockroach-teamcity commented Mar 20, 2022 •

edited by cockroach-jira-scripts

Loading

mgartner commented Mar 23, 2022

mgartner commented Mar 24, 2022

sem/tree: v21.2.7: incorrect type conversion in ColumnAccessExpr - maybe DNull check is missing? #78159

sem/tree: v21.2.7: incorrect type conversion in ColumnAccessExpr - maybe DNull check is missing? #78159

Comments

cockroach-teamcity commented Mar 20, 2022 • edited by cockroach-jira-scripts Loading

mgartner commented Mar 23, 2022

mgartner commented Mar 24, 2022

cockroach-teamcity commented Mar 20, 2022 •

edited by cockroach-jira-scripts

Loading