Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kvserver: slow tests #77951

Open
tbg opened this issue Mar 16, 2022 · 4 comments
Open

kvserver: slow tests #77951

tbg opened this issue Mar 16, 2022 · 4 comments
Labels
C-investigation Further steps needed to qualify. C-label will change. T-kv KV Team

Comments

@tbg
Copy link
Member

tbg commented Mar 16, 2022 •
edited
Loading

We should spend some time understanding why these are to slow, fix common root causes, and mark the rest as skip.UnderShort.

new list: #77951 (comment)

Jira issue: CRDB-13867
@tbg tbg added the C-investigation Further steps needed to qualify. C-label will change. label Mar 16, 2022
@blathers-crl blathers-crl bot added the T-kv KV Team label Mar 16, 2022
@nvanbenschoten
Copy link
Member

@tbg we're looking to jump on some of these slow tests during the stability period. Which of these slow tests will be resolved by #75248?

@tbg
Copy link
Member Author

tbg commented Mar 28, 2022 •
edited
Loading

Only some of the ones taking 45s+. I spot checked a few and crossed out some of the entries that are now fast and definitely some of the slow data-movement based ones are still slow.
I think it makes sense to put together a one-liner that lists the slowest tests by package from an invocation of that package's tests. Perhaps @cockroachdb/bazel-team can help with that; I would only know how to do it with go test -json and jq.

@jlinder
Copy link
Collaborator

jlinder commented Mar 28, 2022

cc @rickystewart

@nvanbenschoten nvanbenschoten mentioned this issue Sep 2, 2022
Closed
@tbg
Copy link
Member Author

tbg commented Nov 16, 2022 •
edited
Loading

I updated this, here's the new list: https://gist.github.com/tbg/9f3e0b11dbc074d7ac75dda73a2cbf37
Link to Snowflake (not sure if this works for folks, but it's all I've got and I don't seem to be able to get a shareable link).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-investigation Further steps needed to qualify. C-label will change. T-kv KV Team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jlinder @tbg @nvanbenschoten