Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make accept builds on linux take *forever* #7701

Closed
glycerine opened this issue Jul 8, 2016 · 2 comments
Closed

make accept builds on linux take *forever* #7701

glycerine opened this issue Jul 8, 2016 · 2 comments

Comments

@glycerine
Copy link
Contributor

apparently they are building rocksdb from c++ scratch every darn time, inside the docker container.

I don't thinks RocksDB is changing that much. The docker container could just come with pre-built rocksdb and pre-built c-rockdsb, and this would save a ton of time (and perhaps CI cost).

@tbg
Copy link
Member

tbg commented Jul 8, 2016

make acceptance does cache all the build artifacts (in the host machine
GOPATH; that's what we suspected screwed up your linker) and it does not
usually build RocksDB new at all. Are you sure they do that? We've also had
an issue in which a go list ./... inside of the container takes forever.

On Fri, Jul 8, 2016 at 12:53 PM Jason E. Aten, Ph.D. <
[email protected]> wrote:

apparently they are building rocksdb from c++ scratch every darn time,
inside the docker container.

I don't thinks RocksDB is changing that much. The docker container could
just come with pre-built rocksdb and pre-built c-rockdsb, and this would
save a ton of time (and perhaps CI cost).


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#7701, or mute the thread
https://github.com/notifications/unsubscribe/AE135EFaHYBsDM918PnTmHAsm1qJNutJks5qToCKgaJpZM4JINS7
.

-- Tobias

@glycerine
Copy link
Contributor Author

I think with #7703 in place I'm not seeing this anymore, so I'll close it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants