-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kvserver: version gate the new StoreRebalancer
implementation
#76702
Labels
A-kv-distribution
Relating to rebalancing and leasing.
branch-release-22.1
Used to mark GA and release blockers, technical advisories, and bugs for 22.1
GA-blocker
T-kv
KV Team
Comments
Hi @aayushshah15, please add a C-ategory label to your issue. Check out the label system docs. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
Hi @aayushshah15, please add branch-* labels to identify which branch(es) this release-blocker affects. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
nvanbenschoten
added
the
branch-release-22.1
Used to mark GA and release blockers, technical advisories, and bugs for 22.1
label
Mar 22, 2022
aayushshah15
added a commit
to aayushshah15/cockroach
that referenced
this issue
Apr 19, 2022
This commit introduces a set of deprecated store rebalancer methods corresponding to the pre-22.1 load-rebalancing scheme. Until a store detects that the version upgrade (to 22.1) has been finalized, the store will fall back to the old (pre-22.1) load-based rebalancing logic that wasn't locality aware. This is done in order to minimize risk of unexpected behavior in mixed version clusters. Resolves cockroachdb#76702 Release note: None
aayushshah15
added a commit
to aayushshah15/cockroach
that referenced
this issue
Apr 20, 2022
This commit introduces a set of deprecated store rebalancer methods corresponding to the pre-22.1 load-rebalancing scheme. Until a store detects that the version upgrade (to 22.1) has been finalized, the store will fall back to the old (pre-22.1) load-based rebalancing logic that wasn't locality aware. This is done in order to minimize risk of unexpected behavior in mixed version clusters. Resolves cockroachdb#76702 Release note: None
aayushshah15
added a commit
to aayushshah15/cockroach
that referenced
this issue
Apr 25, 2022
This commit introduces a set of deprecated store rebalancer methods corresponding to the pre-22.1 load-rebalancing scheme. Until a store detects that the version upgrade (to 22.1) has been finalized, the store will fall back to the old (pre-22.1) load-based rebalancing logic that wasn't locality aware. This is done in order to minimize risk of unexpected behavior in mixed version clusters. Resolves cockroachdb#76702 Release note: None
aayushshah15
added a commit
to aayushshah15/cockroach
that referenced
this issue
Apr 25, 2022
This commit introduces a set of deprecated store rebalancer methods corresponding to the pre-22.1 load-rebalancing scheme. Until a store detects that the version upgrade (to 22.1) has been finalized, the store will fall back to the old (pre-22.1) load-based rebalancing logic that wasn't locality aware. This is done in order to minimize risk of unexpected behavior in mixed version clusters. Resolves cockroachdb#76702 Release note: None
aayushshah15
added a commit
to aayushshah15/cockroach
that referenced
this issue
Apr 26, 2022
This commit introduces a set of deprecated store rebalancer methods corresponding to the pre-22.1 load-rebalancing scheme. Until a store detects that the version upgrade (to 22.1) has been finalized, the store will fall back to the old (pre-22.1) load-based rebalancing logic that wasn't locality aware. This is done in order to minimize risk of unexpected behavior in mixed version clusters. Resolves cockroachdb#76702 Release note: None
aayushshah15
added a commit
to aayushshah15/cockroach
that referenced
this issue
Apr 26, 2022
This commit introduces a set of deprecated store rebalancer methods corresponding to the pre-22.1 load-rebalancing scheme. Until a store detects that the version upgrade (to 22.1) has been finalized, the store will fall back to the old (pre-22.1) load-based rebalancing logic that wasn't locality aware. This is done in order to minimize risk of unexpected behavior in mixed version clusters. Resolves cockroachdb#76702 Release note: None
nvanbenschoten
pushed a commit
to nvanbenschoten/cockroach
that referenced
this issue
May 31, 2022
This commit introduces a set of deprecated store rebalancer methods corresponding to the pre-22.1 load-rebalancing scheme. Until a store detects that the version upgrade (to 22.1) has been finalized, the store will fall back to the old (pre-22.1) load-based rebalancing logic that wasn't locality aware. This is done in order to minimize risk of unexpected behavior in mixed version clusters. Resolves cockroachdb#76702 Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-kv-distribution
Relating to rebalancing and leasing.
branch-release-22.1
Used to mark GA and release blockers, technical advisories, and bugs for 22.1
GA-blocker
T-kv
KV Team
We rewrote the load-based rebalancing scheme in #65379 and #72296. We'll need to version gate this implementation of the
StoreRebalancer
for mixed version settings and probably have mixed version clusters behave identically to 21.2 clusters in terms of their load-based rebalancing behavior.To this end, we should introduce a
DeprecatedStoreRebalancer
that is the 21.2 implementation and only switch to the new implementation after the version upgrade is finalized.Jira issue: CRDB-13240
The text was updated successfully, but these errors were encountered: