Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bazel,dev: cannot rewrite from different package #76513

Closed
Tracked by #75453
ajwerner opened this issue Feb 14, 2022 · 0 comments · Fixed by #77679
Closed
Tracked by #75453

bazel,dev: cannot rewrite from different package #76513

ajwerner opened this issue Feb 14, 2022 · 0 comments · Fixed by #77679
Assignees
@irfansharif
Labels
A-testing Testing tools and infrastructure C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-dev-inf

Comments

@ajwerner
Copy link
Contributor

ajwerner commented Feb 14, 2022 •
edited by cockroach-jira-scripts
Loading

Describe the problem

Some of our tests share testdata between ccl and non-ccl packages. Importantly, we run all the logictests in sql/logic/testdata under ccl/logictestccl for the tenant configurations. When trying to rewrite, we get this sad error:

logic.go:3433: open /private/var/tmp/_bazel_ajwerner/b3d58fe5cfe2626204f99f33b47d6f4a/sandbox/darwin-sandbox/872/execroot/cockroach/bazel-out/darwin-fastbuild/bin/pkg/ccl/logictestccl/logictestccl_test_/logictestccl_test.runfiles/cockroach/pkg/sql/logictest/testdata/logic_test/distsql_automatic_stats: operation not permitted

Repro:

To Reproduce

./dev testlogic ccl --rewrite --show-logs  -v --files distsql_automatic_stats --config 3node-tenant

Epic CRDB-8036

Jira issue: CRDB-13160
@ajwerner ajwerner added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-testing Testing tools and infrastructure labels Feb 14, 2022
@ajwerner ajwerner changed the title bazel,dev: cannot rewrite from difference package bazel,dev: cannot rewrite from different package Feb 14, 2022
@irfansharif irfansharif self-assigned this Feb 14, 2022
This was referenced Mar 11, 2022
Merged
Closed
craig bot pushed a commit that referenced this issue Mar 14, 2022
@irfansharif
Merge #77679
0e53a5c 
77679: dev: fix --rewrite for logictestccl r=irfansharif a=irfansharif

Fixes #76513. The ccl logictest target shares the testdata directory
with the base logictest target. Since dev's --rewrite only makes an
allowance for the testdata/ directory under the package being tested,
this didn't work. This PR accommodates the one test target where
testdata/ is being used from elsewhere.

Release justification: non-production code change
Release note: None

Co-authored-by: irfan sharif <[email protected]>
@craig craig bot closed this as completed in c1f2877 Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@irfansharif irfansharif

Labels
A-testing Testing tools and infrastructure C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-dev-inf
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dev: fix --rewrite for logictestccl irfansharif/cockroach
3 participants
@ajwerner @rickystewart @irfansharif