Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: decommission/drains failed #75774

Closed
cockroach-teamcity opened this issue Feb 1, 2022 · 5 comments · Fixed by #75881
Closed

roachtest: decommission/drains failed #75774

cockroach-teamcity opened this issue Feb 1, 2022 · 5 comments · Fixed by #75881
Assignees
@cameronnunez
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-server-and-security DB Server & Security

Comments

@cockroach-teamcity
Copy link
Member

roachtest.decommission/drains failed with artifacts on master @ 8548987813ff9e1b8a9878023d3abfc6911c16db:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /artifacts/decommission/drains/run_1
	test_impl.go:274,assertions.go:262,assertions.go:1332,require.go:1231,decommission.go:1088,retry.go:189,retry.go:166,retry.go:188,decommission.go:1075,decommission.go:74,test_runner.go:780: 
			Error Trace:	decommission.go:1088
			            				retry.go:189
			            				retry.go:166
			            				retry.go:188
			            				decommission.go:1075
			            				decommission.go:74
			            				test_runner.go:780
			            				asm_amd64.s:1581
			Error:      	Received unexpected error:
			            	pq: server is not accepting clients, try another node
			Test:       	decommission/drains
Help

See: roachtest README

See: How To Investigate (internal)

/cc @cockroachdb/server

This test on roachdash | Improve this report!
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Feb 1, 2022
@blathers-crl blathers-crl bot added the T-server-and-security DB Server & Security label Feb 1, 2022
@cockroach-teamcity
Copy link
Member Author

roachtest.decommission/drains failed with artifacts on master @ 95c82a7dbc6d6fecb63edbd666c9986d1ad3885b:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/decommission/drains/run_1
	test_impl.go:274,assertions.go:262,assertions.go:1332,require.go:1231,decommission.go:1088,retry.go:189,retry.go:166,retry.go:188,decommission.go:1075,decommission.go:74,test_runner.go:780: 
			Error Trace:	decommission.go:1088
			            				retry.go:189
			            				retry.go:166
			            				retry.go:188
			            				decommission.go:1075
			            				decommission.go:74
			            				test_runner.go:780
			            				asm_amd64.s:1581
			Error:      	Received unexpected error:
			            	pq: server is not accepting clients, try another node
			Test:       	decommission/drains
Help

See: roachtest README

See: How To Investigate (internal)

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

roachtest.decommission/drains failed with artifacts on master @ 8548987813ff9e1b8a9878023d3abfc6911c16db:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /artifacts/decommission/drains/run_1
	test_impl.go:274,assertions.go:262,assertions.go:1332,require.go:1231,decommission.go:1088,retry.go:189,retry.go:166,retry.go:188,decommission.go:1075,decommission.go:74,test_runner.go:780: 
			Error Trace:	decommission.go:1088
			            				retry.go:189
			            				retry.go:166
			            				retry.go:188
			            				decommission.go:1075
			            				decommission.go:74
			            				test_runner.go:780
			            				asm_amd64.s:1581
			Error:      	Received unexpected error:
			            	pq: server is not accepting clients, try another node
			Test:       	decommission/drains
Help

See: roachtest README

See: How To Investigate (internal)

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

roachtest.decommission/drains failed with artifacts on master @ 16859b99637d1adedb915a67998749dbfa4c0663:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/decommission/drains/run_1
	test_impl.go:274,assertions.go:262,assertions.go:1332,require.go:1231,decommission.go:1088,retry.go:189,retry.go:166,retry.go:188,decommission.go:1075,decommission.go:74,test_runner.go:780: 
			Error Trace:	decommission.go:1088
			            				retry.go:189
			            				retry.go:166
			            				retry.go:188
			            				decommission.go:1075
			            				decommission.go:74
			            				test_runner.go:780
			            				asm_amd64.s:1581
			Error:      	Received unexpected error:
			            	pq: server is not accepting clients, try another node
			Test:       	decommission/drains
Help

See: roachtest README

See: How To Investigate (internal)

This test on roachdash | Improve this report!

@cameronnunez cameronnunez mentioned this issue Feb 2, 2022
Merged
@cockroach-teamcity
Copy link
Member Author

roachtest.decommission/drains failed with artifacts on master @ 8548987813ff9e1b8a9878023d3abfc6911c16db:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /artifacts/decommission/drains/run_1
	test_impl.go:274,assertions.go:262,assertions.go:1332,require.go:1231,decommission.go:1088,retry.go:189,retry.go:166,retry.go:188,decommission.go:1075,decommission.go:74,test_runner.go:780: 
			Error Trace:	decommission.go:1088
			            				retry.go:189
			            				retry.go:166
			            				retry.go:188
			            				decommission.go:1075
			            				decommission.go:74
			            				test_runner.go:780
			            				asm_amd64.s:1581
			Error:      	Received unexpected error:
			            	pq: server is not accepting clients, try another node
			Test:       	decommission/drains
Help

See: roachtest README

See: How To Investigate (internal)

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

roachtest.decommission/drains failed with artifacts on master @ f20c1a8d824f0d00f18c0d58ed8b4bc4955e0969:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/decommission/drains/run_1
	test_impl.go:274,assertions.go:262,assertions.go:1332,require.go:1231,decommission.go:1088,retry.go:189,retry.go:166,retry.go:188,decommission.go:1075,decommission.go:74,test_runner.go:780: 
			Error Trace:	decommission.go:1088
			            				retry.go:189
			            				retry.go:166
			            				retry.go:188
			            				decommission.go:1075
			            				decommission.go:74
			            				test_runner.go:780
			            				asm_amd64.s:1581
			Error:      	Received unexpected error:
			            	pq: server is not accepting clients, try another node
			Test:       	decommission/drains
Help

See: roachtest README

See: How To Investigate (internal)

This test on roachdash | Improve this report!

craig bot pushed a commit that referenced this issue Feb 3, 2022
@jbowens @adityamaru
@Fenil-P @cameronnunez
Merge #74314 #75122 #75461 #75881
0b16926 
74314: storage: remove obsolete encryption-at-rest code r=sumeerbhola a=jbowens

Remove encryption-at-rest code that handles the upgrade process to the 21.2
encryption-at-rest formats and all code that reads the 21.1 and earlier
formats.

Fix #72520.

Release note: None

75122: spanconfigsql{watcher,reconciler}: setup SQLWatcher to watch for pts updates r=adityamaru a=adityamaru

This change sets up a rangefeed on the `system.pts_records` table,
and adds this to the set of rangefeeds managed by the SQLWatcher. We
switch the unit emitted by the SQLWatcher to a union type called
`SQLUpdate` which captures either an update to a descriptor or to a
protected timestamp target. The zones and descriptor table rangefeeds
will continue to emit descriptor updates. The pts rangefeed will emit
descriptor updates for records that target schema objects, and pts target
updates for records that target cluster or tenants.

The SQLWatcher continues to dedup the SQLUpdates that it emits, so as to
ensure there is only one SQLUpdate per descriptor ID, and one SQLUpdate
per cluster or tenant target. The reconciler registers a handler that
is invoked everytime a batch of SQLUpdates are emitted by the SQLWatcher.
There is change in semantics in this part of the code, a future PR will teach
the reconciler to parse the pts target SQLUpdates, and in turn instruct the
SQLTranslator to generate the appropriate `SystemSpanConfigs`.

Note, this file moves the sqlwatcher tests into a ccl package so as to be
able to run backup statements to test the rangefeed on the pts table.

Informs: #73727

Release note: None

75461: sql: New tables added will have columns in the correct order r=Fenil-P a=Fenil-P

Release note (sql change): Reordered unimplemented vtables columns in pg_catalog and information_schema

75881: roachtest: fix drain check in `decommission/drains` r=irfansharif a=cameronnunez

Fixes #75774.

This patch fixes the drain check in the test, which was previously
done incorrectly.

Release note: None

Co-authored-by: Jackson Owens <[email protected]>
Co-authored-by: Aditya Maru <[email protected]>
Co-authored-by: Fenil Patel <[email protected]>
Co-authored-by: Cameron Nunez <[email protected]>
@craig craig bot closed this as completed in 817b12d Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cameronnunez cameronnunez

Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-server-and-security DB Server & Security
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

roachtest: fix drain check in decommission/drains cameronnunez/cockroach
2 participants
@cockroach-teamcity @cameronnunez