-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: TestRemoveDeadReplicas failed #75133
Comments
@irfansharif could this be fallout from the zonecfg change? I don't think we've touched this test. @aliher1911 has been working on LOQ recovery but I don't think he touched this test (?) |
cli.TestRemoveDeadReplicas failed with artifacts on master @ e1068d77afbd39b162978281c9da7cbea49c1c3a:
Help
See also: How To Investigate a Go Test Failure (internal)
|
I'll try looking today, though dreading the 25s runtime for the test. |
PS: I'm not actively investigating this. Letting it sit on the server board to remind ourselves to address it during stability at the latest. My earlier stress attempts were unfruitful. |
In https://teamcity.cockroachdb.com/viewLog.html?buildId=4448409&buildTypeId=Cockroach_UnitTests |
cli.TestRemoveDeadReplicas failed with artifacts on master @ d84f07e856dbb3d62f0336f4e8439280e2a018ed:
Help
See also: How To Investigate a Go Test Failure (internal)
|
cli.TestRemoveDeadReplicas failed with artifacts on master @ e02793d3e214c5b716149963369aa72f9338ac0d:
Help
See also: How To Investigate a Go Test Failure (internal)
|
cli.TestRemoveDeadReplicas failed with artifacts on master @ 63ea9139e2ca996e38b5fe7c7b43a97e625242f5:
Help
See also: How To Investigate a Go Test Failure (internal)
|
cli.TestRemoveDeadReplicas failed with artifacts on master @ 43457fc6e2f5324823cca4156d9799453753b9cc:
Help
See also: How To Investigate a Go Test Failure (internal)
|
@aliher1911 interesting failure mode:
|
I'm not sure this is anything new, and it does happen during a test that exercises recovery from loss of quorum, but it's worth a second look before GA potentially. |
Let's make sure this gets timely attention and doesn't hold up the RCs. @aliher1911 Have you had a look at this, and/or would you like a hand? |
Stressed this for a couple of hours, no hits. I'm mostly interested in the |
I'm suspecting #75761, which fits time-wise. #76248 seems unlikely, but possible. CC @sumeerbhola. |
Tracked by #79074. |
I think this could be as simple as Lines 1248 to 1252 in 87610fe
We're changing the replica ID in the local range descriptor, but not updating @aliher1911 We'll probably have to handle this in the new LoQ tooling too. |
Removing GA blocker, since we've merged the 22.1.0 backport in #80626. Will look into addressing the test flake here when I have time. |
cli.TestRemoveDeadReplicas failed with artifacts on master @ d63a3693480d2b62aebd15c11799d2ccdc8564a4:
Help
See also: How To Investigate a Go Test Failure (internal)
Same failure on other branches
|
cli.TestRemoveDeadReplicas failed with artifacts on master @ 1a91d7cb7b93dfef5dcaf872125875cefa3e0190:
Help
See also: How To Investigate a Go Test Failure (internal)
Same failure on other branches
|
cli.TestRemoveDeadReplicas failed with artifacts on master @ 16c484aa84d3718bfc82557f8e935ab78e6753b6:
Help
See also: How To Investigate a Go Test Failure (internal)
Same failure on other branches
|
cli.TestRemoveDeadReplicas failed with artifacts on master @ 8d34ef1ea15850ee1c70470610b6652df4c317de:
Parameters: Same failure on other branches
|
Refs: cockroachdb#75133 Reason: flaky test Generated by bin/skip-test. Release justification: non-production code changes Release note: None
83389: testutils: add `storageutils` test utilities r=nicktrav a=erikgrinaker This patch adds a bunch of test utilities to `storageutils`, replacing the old `sstutil` package. This is done to ease testing of MVCC range keys in tests outside the `storage` package. Unfortunately, these are mostly duplicates of utilities in `storage`. Storage tests use the `storage` package rather than `storage_test`, and can't make use of `storageutils` yet because it causes an import cycle with `storage`. This will (hopefully) be addressed separately. Release note: None 83448: cli: skip TestRemoveDeadReplicas r=erikgrinaker a=tbg Refs: #75133 Reason: flaky test Generated by bin/skip-test. Release justification: non-production code changes Release note: None 83561: backupccl: deflake TestMetadataSST r=stevendanna a=stevendanna This is a temporary fix for failures in TestMetadataSST. First, backup_metadata_test.go:49: error executing 'BACKUP TO $1': pq: a CCL binary is required to use this statement type: *tree.Backup is solved by moving the test back into the backupccl package so that the plan hook for BACKUP is definitely registered. Second, backup_metadata_test.go:89: file /0/BACKUP_MANIFEST does not exist in the UserFileTableSystem: external_storage: file doesn't exist is solved by disabling tenants by default in the setup functions in backuputils. There is duplication between these functions and the functions in backupccl, where we already disable tenants. The error above is likely the result of us directly using the internal executor of the server to query the userfile storage, which may be incorrect if we were actually talking to a tenant. Release note: None Co-authored-by: Erik Grinaker <[email protected]> Co-authored-by: Tobias Grieger <[email protected]> Co-authored-by: Steven Danna <[email protected]>
We'll remove this test when we remove the tool itself over in #84807. |
cli.TestRemoveDeadReplicas failed with artifacts on master @ 912964e02ddd951c77d4f71981ae18b3894e9084:
Help
See also: How To Investigate a Go Test Failure (internal)
Parameters in this failure:
This test on roachdash | Improve this report!
Jira issue: CRDB-12480
The text was updated successfully, but these errors were encountered: