Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kvserver: emit trace from failed replica circuit breaker probes #74699

Closed
tbg opened this issue Jan 11, 2022 · 2 comments
Closed

kvserver: emit trace from failed replica circuit breaker probes #74699

tbg opened this issue Jan 11, 2022 · 2 comments
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) no-issue-activity X-stale

Comments

@tbg
Copy link
Member

tbg commented Jan 11, 2022 •
edited by cockroach-jira-scripts
Loading

Is your feature request related to a problem? Please describe.
In #71806 we're introducing per-replica circuit breakers (#33007). This is well
and good, but when a breaker trips we want to know as much about that as
possible.

Describe the solution you'd like

Do whatever the outcome in #74404 is, where @joshimhoff is considering a similar problem for kvprober.

Jira issue: CRDB-12217
@tbg tbg added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Jan 11, 2022
@joshimhoff
Copy link
Collaborator

Exciting!

@dhartunian dhartunian mentioned this issue Jan 12, 2022
Open
dhartunian added a commit to dhartunian/cockroach that referenced this issue Jan 12, 2022
@dhartunian
log: add docs on when new logging channels are warranted
c512d70 
Motivated by cockroachdb#74404 and cockroachdb#74699

Release note: None
@tbg tbg self-assigned this Jan 14, 2022
@tbg tbg mentioned this issue Jan 14, 2022
Closed
@tbg tbg removed their assignment May 31, 2022
@github-actions GitHub Actions
Copy link

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
10 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) no-issue-activity X-stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@erikgrinaker @joshimhoff @tbg