Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify the Statements and Transactions tables to aggregate rows across aggregation intervals #74513

Closed
jocrl opened this issue Jan 6, 2022 · 0 comments · Fixed by #76301
Closed

Modify the Statements and Transactions tables to aggregate rows across aggregation intervals #74513

jocrl opened this issue Jan 6, 2022 · 0 comments · Fixed by #76301
Assignees
@maryliag
Labels
A-sql-console-general SQL Observability issues on the DB console spanning multiple areas. Includes Cockroach Cloud Console C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@jocrl
Copy link
Contributor

jocrl commented Jan 6, 2022

On both DB Console and Cluster UI
Figma mockups: https://www.figma.com/file/xdmwvnFQd6KkO9RJ0XLDH0/22.1_SQL-obsrv_query-performance?node-id=3488%3A10430
Epic: CRDB-6564
@jocrl jocrl added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-observability A-sql-console-general SQL Observability issues on the DB console spanning multiple areas. Includes Cockroach Cloud Console labels Jan 6, 2022
@jocrl jocrl self-assigned this Jan 6, 2022
@maryliag maryliag assigned maryliag and unassigned jocrl Feb 4, 2022
maryliag added a commit to maryliag/cockroach that referenced this issue Feb 4, 2022
@maryliag
sql,roachpb,ui: add plan hash correct value to persisted stats
2b0e45c 
Previously, we didn't have the plan hash/gist values, so
a dummy value was being used instead. Now that we have the value,
this commit uses those values to be corrected stored.
The Plan Hash is saved on its own column and is part of a
statement key. A plan gist is a string saved in the metadata
and can later on converted back into a logical plan.

Partially addresses cockroachdb#72129

The new query to collect statement now ignores plan hash and
the aggregation ts as keys. So this commits also removes the
aggreagted ts value on the UI, since it no longer applies.

Fixes cockroachdb#74513

Release note (sql change): Saving plan hash/gist to the Statements
persisted stats.

Release note (ui change): We don't show information about
aggregations ts in Statements overview and Details pages, since
now all the statement fingerprints are grouped inside the same
time selection.
@maryliag maryliag mentioned this issue Feb 4, 2022
Merged
maryliag added a commit to maryliag/cockroach that referenced this issue Feb 9, 2022
@maryliag
server, ui: aggregate statements on period selected
e42a90b 
Previously, the aggregation timestamp was used as part
of the key of a statement. The new query to collect
statement now ignores aggregation ts as keys.
This commits also removes the aggreagted ts value on the UI,
 since it no longer applies.

Fixes cockroachdb#74513

Release note (ui change): We don't show information about
aggregations ts in Statements overview and Details pages, since
now all the statement fingerprints are grouped inside the same
time selection.
@maryliag maryliag mentioned this issue Feb 9, 2022
Merged
craig bot pushed a commit that referenced this issue Feb 14, 2022
@maryliag @rafiss
Merge #76301 #76511
3be8121 
76301: server, ui: aggregate statements on period selected r=maryliag a=maryliag

Previously, the aggregation timestamp was used as part
of the key of a statement. The new query to collect
statement now ignores aggregation timestamp as keys.
This commit also removes the aggregated timestamp value on the UI,
 since it no longer applies.

Fixes #74513

Release note (ui change): We don't show information about
aggregations timestamp in Statements overview and Details pages, since
now all the statement fingerprints are grouped inside the same
time selection.

76511: pgwire: fix flaky cancel tests r=RichardJCai a=rafiss

fixes #76494
fixes #76493

One required a nil guard, and the other required the telemetry counter
to be incremented before the connection is closed.

Release note: None

Co-authored-by: Marylia Gutierrez <[email protected]>
Co-authored-by: Rafi Shamim <[email protected]>
@craig craig bot closed this as completed in 71ef6b8 Feb 14, 2022
RajivTS pushed a commit to RajivTS/cockroach that referenced this issue Mar 6, 2022
@maryliag @RajivTS
server, ui: aggregate statements on period selected
01684ca 
Previously, the aggregation timestamp was used as part
of the key of a statement. The new query to collect
statement now ignores aggregation timestamp as keys.
This commit also removes the aggregated timestamp value
on the UI, since it no longer applies.

Fixes cockroachdb#74513

Release note (ui change): We don't show information about
aggregations timestamp in Statements overview and Details pages,
since now all the statement fingerprints are grouped inside the same
time selection.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maryliag maryliag

Labels
A-sql-console-general SQL Observability issues on the DB console spanning multiple areas. Includes Cockroach Cloud Console C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

server, ui: aggregate statements on period selected maryliag/cockroach
2 participants
@maryliag @jocrl